Page MenuHomePhabricator
Create Task
Maniphest T361247

[REPO][SW] PHP Notice: Undefined index: <blank> (or lldwiki)
Open, Needs TriagePublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined index:
error.stack_trace
from /srv/mediawiki/php-1.42.0-wmf.24/includes/site/SiteList.php(237)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.42.0-wmf.24/includes/site/SiteList.php(237): ArrayObject->offsetGet(NULL)
#2 /srv/mediawiki/php-1.42.0-wmf.24/extensions/Wikibase/repo/includes/Rdf/SiteLinksRdfBuilder.php(89): MediaWiki\Site\SiteList->getSite(string)
#3 /srv/mediawiki/php-1.42.0-wmf.24/extensions/Wikibase/repo/includes/Rdf/SiteLinksRdfBuilder.php(144): Wikibase\Repo\Rdf\SiteLinksRdfBuilder->addSiteLinks(Wikibase\DataModel\Entity\Item)
#4 /srv/mediawiki/php-1.42.0-wmf.24/extensions/Wikibase/repo/includes/Rdf/ItemRdfBuilder.php(56): Wikibase\Repo\Rdf\SiteLinksRdfBuilder->addEntity(Wikibase\DataModel\Entity\Item)
#5 /srv/mediawiki/php-1.42.0-wmf.24/extensions/Wikibase/repo/includes/Rdf/RdfBuilder.php(317): Wikibase\Repo\Rdf\ItemRdfBuilder->addEntity(Wikibase\DataModel\Entity\Item)
#6 /srv/mediawiki/php-1.42.0-wmf.24/extensions/Wikibase/repo/includes/Rdf/RdfBuilder.php(302): Wikibase\Repo\Rdf\RdfBuilder->addSingleEntity(Wikibase\DataModel\Entity\Item)
#7 /srv/mediawiki/php-1.42.0-wmf.24/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(206): Wikibase\Repo\Rdf\RdfBuilder->addEntity(Wikibase\DataModel\Entity\Item)
#8 /srv/mediawiki/php-1.42.0-wmf.24/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(152): Wikibase\Repo\LinkedData\EntityDataSerializationService->rdfSerialize(Wikibase\Lib\Store\EntityRevision, NULL, array, Wikibase\Repo\Rdf\RdfBuilder, string)
#9 /srv/mediawiki/php-1.42.0-wmf.24/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(555): Wikibase\Repo\LinkedData\EntityDataSerializationService->getSerializedData(string, Wikibase\Lib\Store\EntityRevision, NULL, array, string)
#10 /srv/mediawiki/php-1.42.0-wmf.24/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(289): Wikibase\Repo\LinkedData\EntityDataRequestHandler->showData(MediaWiki\Request\WebRequest, MediaWiki\Output\OutputPage, string, Wikibase\DataModel\Entity\ItemId, integer)
#11 /srv/mediawiki/php-1.42.0-wmf.24/extensions/Wikibase/repo/includes/Specials/SpecialEntityData.php(112): Wikibase\Repo\LinkedData\EntityDataRequestHandler->handleRequest(string, MediaWiki\Request\WebRequest, MediaWiki\Output\OutputPage)
#12 /srv/mediawiki/php-1.42.0-wmf.24/includes/specialpage/SpecialPage.php(720): Wikibase\Repo\Specials\SpecialEntityData->execute(string)
#13 /srv/mediawiki/php-1.42.0-wmf.24/includes/specialpage/SpecialPageFactory.php(1652): MediaWiki\SpecialPage\SpecialPage->run(string)
#14 /srv/mediawiki/php-1.42.0-wmf.24/includes/actions/ActionEntryPoint.php(504): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#15 /srv/mediawiki/php-1.42.0-wmf.24/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#16 /srv/mediawiki/php-1.42.0-wmf.24/includes/MediaWikiEntryPoint.php(199): MediaWiki\Actions\ActionEntryPoint->execute()
#17 /srv/mediawiki/php-1.42.0-wmf.24/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}
Notes
  • Happening on wikidata
  • Seems to have increased since rolling out wmf.24

Details

Request URL
https://www.wikidata.org/wiki/Special:EntityData/Q14684295.rdf?flavor=*

Event Timeline

thcipriani created this task.Mar 28 2024, 3:25 PM
Restricted Application added a project: wmde-wikidata-tech. · View Herald TranscriptMar 28 2024, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
thcipriani moved this task from Untriaged to Mar 2024 on the Wikimedia-production-error board.Mar 28 2024, 3:25 PM
ArthurTaylor renamed this task from PHP Notice: Undefined index: <blank> (or lldwiki) to [REPO[SW]PHP Notice: Undefined index: <blank> (or lldwiki).Tue, Apr 2, 2:39 PM
ArthurTaylor renamed this task from [REPO[SW]PHP Notice: Undefined index: <blank> (or lldwiki) to [REPO][SW]PHP Notice: Undefined index: <blank> (or lldwiki).
ArthurTaylor renamed this task from [REPO][SW]PHP Notice: Undefined index: <blank> (or lldwiki) to [REPO][SW] PHP Notice: Undefined index: <blank> (or lldwiki).
Lucas_Werkmeister_WMDE subscribed.Tue, Apr 2, 2:43 PM

Seems to have recovered on its own, no longer happening since 28 March:

image.png (300×680 px, 16 KB)

It also happened for a lot of other wiki IDs, not just blank and lldwiki:
image.png (382×910 px, 63 KB)

There’s a FIXME in the code that we should improve, but also, this does seem like a strange situation that we’d want to log in some way rather than just silently skip the sitelink.

SiteLinksRdfBuilder::addSiteLinks()
// FIXME: we should check the site exists using hasGlobalId here before asuming it does
$site = $this->siteLookup->getSite( $siteLink->getSiteId() );
if ( !$site ) {
	// Somehow we've got site that we don't know about - skip
	continue;
}
ArthurTaylor moved this task from Incoming to [DOT] By Project on the wmde-wikidata-tech board.Tue, Apr 2, 2:43 PM
Lydia_Pintscher removed a project: Wikidata Dev Team.Tue, Apr 9, 2:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL