Page MenuHomePhabricator

Write PHPUnit tests for excimer-ui-client (WikimediaDebug)
Open, Needs TriagePublic

Event Timeline

Change #925819 had a related patch set uploaded (by Krinkle; author: Krinkle):

[performance/excimer-ui-client@master] tests: Add PHPUnit coverage

https://gerrit.wikimedia.org/r/925819

The above patch is a draft I wrote in June 2023. It was unable to land at the time because WMF CI installs php-excimer from deb.sury.org for most PHP versions (except the production version). And, at the time, upstream still packaged php-excimer 1.0.4, whereas support for Speedscope (which WikimediaDebug and php-ui-client build on) was added in php-excimer 1.1.0.

I filed an upstream ticket at https://github.com/oerdnj/deb.sury.org/issues/1952, which was resolved in February 2024.

Change #1015597 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/config@master] jjb: Upgrade php-excimer to 1.2.1 in composer-test jobs

https://gerrit.wikimedia.org/r/1015597

Change #1015597 merged by jenkins-bot:

[integration/config@master] jjb: Upgrade php-excimer to 1.2.1 in composer-test jobs

https://gerrit.wikimedia.org/r/1015597

Change #1015634 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/config@master] jjb: Fix typo in composer-package-php81 job

https://gerrit.wikimedia.org/r/1015634

Change #1015634 merged by jenkins-bot:

[integration/config@master] jjb: Fix typo in composer-package-php81 job

https://gerrit.wikimedia.org/r/1015634

Hola @Krinkle, is any assistance needed from our end?

@Krinkle I'll ask someone to take a look then, thanks!

Change #925819 merged by jenkins-bot:

[performance/excimer-ui-client@master] tests: Add PHPUnit coverage

https://gerrit.wikimedia.org/r/925819