| SBisson | |
| Apr 3 2024, 1:12 PM |
| F54944600: T361703_popupContainer.webm | |
| Jun 4 2024, 9:48 PM |
First reported here: https://github.com/wikimedia/wikipedia-preview/issues/182
Although that report is light in details, I experienced this issue during recent development.
If the popupContainer init parameter is provided but invalid, the code fails with a low-level error.
We should validate it and fallback to the default value instead of erroring out.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T361703#9861934 |
@SBisson With an invalid init parameter in popupContainer, it falls back to the default and does not error out as seen in the video below. I will move this to design sign-off. Thanks for all your work!
Status: ✅PASS
Environment:Diff Local
OS: macOS Sonoma 14.5
Browser: Chrome 125
Skins.n/a
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:5173/demo/index.html
✅AC1: popupContainer- fallback to the default value instead of erroring out