Reproduce:
Actual: displays "You have no unsaved changes."
Expected: the page should say you did not enable edit recovery, and (1) for registered users, provide a link to https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-editing where edit recovery can be enabled; (2) for non-registered (or temporary) users, instruct them to create a (permanent) account.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Edit Recovery: Add error messages to special page | mediawiki/core | master | +27 -1 |
Change #1019737 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/core@master] Edit Recovery: Add error messages to special page
Are the following error messages suitable?
Please [[Special:UserLogin|log in]] to use this feature.
You can enable this feature in [[Special:Preferences#mw-prefsection-editing|your preferences]].
@JSengupta-WMF You might have an opinion here.
instruct them to create a (permanent) account.
I'm not sure about this (not that it's not a good idea); what is the usual messaging around temporary accounts? Are there existing messages we should be using here?
Note: Edit recovery feature supports recovering edits for anonymous and temporary users, if the feature is enabled by default (however it is currently disabled by default in Wikimedia wikis). cf T342738#9148104. So you need also to check whether edit recovery is enabled by default.
I think the approach overall is good. Rather than blocking the user, providing them option. We can combine it with
So you need also to check whether edit recovery is enabled by default.
Good point. Although, not whether it's enabled by default, but just to check for that before checking if they're anon. I've updated the patch.
Rather than blocking the user, providing them option. We can combine it with
Sounds good; done.
Oh, actually, the create account link should probably be conditional because account creation is not always open. Does that matter?
Change #1019737 merged by jenkins-bot:
[mediawiki/core@master] Edit Recovery: Add error messages to special page
I can confirm the messages from T361721#9712945 and T361721#9712945 on https://en.wikipedia.org.