Maniphest T361734

Update focus color to be the same everywhere
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	DTorsani-WMF
	Wed, Apr 3, 7:11 PM

Tags

Referenced Files

None

Subscribers

Description

Context

Currently, Codex uses the progressive color (#36c) for the focus color everywhere except on destructive buttons. In and effort to simplify and standardize more elements within Codex, we want to use the progressive color on all focus states.

We decided we want to keep these tokens in the system instead of deprecating them for now to see if any potential themes in the future decide to designate a different focus color for destructive elements and red links.

Acceptance Criteria

Change the option token of @color-destructive--focus,background-color-destructive--focus, border-color-destructive--focus, color-link-red--focus tokens to use progressive color blue600 instead.
Update interactive states image on Button docs page
Update interactive states image on TextInput docs page
Update value in Design tokens Figma to match code
Add change to Design tokens Figma changelog

Details

	Subject	Repo	Branch	Lines +/-
	Update Codex from 1.3.6 to 1.4.0	mediawiki/core	master	+190 -114
	tokens, docs: Change any red focus color to progressive blue	design/codex	main	+194 -195

Customize query in gerrit

Related Objects

Mentioned In: T346168: TextInput: update error-hover state

Event Timeline

DTorsani-WMF created this task.Wed, Apr 3, 7:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Apr 3, 7:11 PM

DTorsani-WMF updated the task description. (Show Details)Wed, Apr 3, 7:17 PM

DTorsani-WMF updated the task description. (Show Details)Mon, Apr 8, 1:45 PM

bmartinezcalvo updated the task description. (Show Details)Tue, Apr 9, 10:52 AM

bmartinezcalvo subscribed.Tue, Apr 9, 10:55 AM

bmartinezcalvo mentioned this in T346168: TextInput: update error-hover state.Tue, Apr 9, 1:43 PM

DTorsani-WMF claimed this task.Tue, Apr 9, 2:31 PM

DTorsani-WMF updated the task description. (Show Details)

DTorsani-WMF updated the task description. (Show Details)Tue, Apr 9, 5:11 PM

DTorsani-WMF updated the task description. (Show Details)Tue, Apr 9, 5:44 PM

DTorsani-WMF updated the task description. (Show Details)Tue, Apr 9, 6:56 PM

DTorsani-WMF updated the task description. (Show Details)Tue, Apr 9, 6:59 PM

Change #1018334 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] codex: Change any red focus color to blue

https://gerrit.wikimedia.org/r/1018334

gerritbot added a project: Patch-For-Review.Tue, Apr 9, 7:40 PM

Change #1018334 merged by jenkins-bot:

[design/codex@main] tokens, docs: Change any red focus color to progressive blue

https://gerrit.wikimedia.org/r/1018334

DTorsani-WMF closed this task as Resolved.Wed, Apr 10, 1:45 PM

Volker_E removed a project: Patch-For-Review.Wed, Apr 10, 2:31 PM

Volker_E updated the task description. (Show Details)

Volker_E edited projects, added Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)); removed Design-System-Team.

Volker_E updated the task description. (Show Details)Wed, Apr 10, 2:34 PM

Volker_E moved this task from Committed to Design Sign-Off on the Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)) board.

Volker_E moved this task from Design Sign-Off to Product Sign-Off on the Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)) board.

DTorsani-WMF updated the task description. (Show Details)Wed, Apr 10, 2:45 PM

DTorsani-WMF reopened this task as Open.Wed, Apr 10, 3:21 PM

DTorsani-WMF moved this task from Product Sign-Off to Pending Release on the Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)) board.

Volker_E set the point value for this task to 1.Tue, Apr 16, 12:46 AM

Change #1020918 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from 1.3.6 to 1.4.0

https://gerrit.wikimedia.org/r/1020918

gerritbot added a project: Patch-For-Review.Wed, Apr 17, 8:40 PM

Change #1020918 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from 1.3.6 to 1.4.0

https://gerrit.wikimedia.org/r/1020918

egardner closed this task as Resolved.Wed, Apr 17, 10:27 PM

Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:02 PM