Page MenuHomePhabricator

Can't delete suggestions
Closed, ResolvedPublic

Description

I no longer appear to be able to delete suggestions on the suggest page. Clicking Delete takes me to the confirmation page (e.g. https://wikipedialibrary.wmflabs.org/suggest/704/delete/), but clicking Confirm seems to just reload the page.

Event Timeline

@Scardenasmolinar Is there any chance this is related to the 4.2 upgrade?

This may be a caching issue. When I navigated to https://wikipedialibrary.wmflabs.org/suggest/704/delete/ it was already gone

Ah, I manually deleted that one (spam) via /admin, perhaps a bad example for me to have linked :)

I verified the behavior on staging though: I can delete a suggestion and it takes me right back to a cached version of it. If I reload, I get a 404.

I verified the behavior on staging though: I can delete a suggestion and it takes me right back to a cached version of it. If I reload, I get a 404.

Hm, I can't reproduce that. My steps:

  1. Log in to staging on my staff account, navigate to https://twlight-staging.wmflabs.org/suggest/
  2. The second-to-last suggestion is AllAfrica (premium). I click Delete
  3. I get the confirmation screen - "Are you sure you want to delete AllAfrica (premium)?" - I click Confirm
  4. The confirmation screen reloads
  5. Opening https://twlight-staging.wmflabs.org/suggest/ in a brand new incognito window still shows the AllAfrica suggestion is present on the page.

I verified the behavior on staging though: I can delete a suggestion and it takes me right back to a cached version of it. If I reload, I get a 404.

Hm, I can't reproduce that. My steps:

  1. Log in to staging on my staff account, navigate to https://twlight-staging.wmflabs.org/suggest/
  2. The second-to-last suggestion is AllAfrica (premium). I click Delete
  3. I get the confirmation screen - "Are you sure you want to delete AllAfrica (premium)?" - I click Confirm
  4. The confirmation screen reloads
  5. Opening https://twlight-staging.wmflabs.org/suggest/ in a brand new incognito window still shows the AllAfrica suggestion is present on the page.

I was testing incorrectly! https://twlight-staging.wmflabs.org/suggest/<pk> does not have a view associated with it.

RTL notes:

  • This probably is a Django 4.2 error, and likely related to T358122.
  • This problem likely also impacts the data deletion view.
  • We should check that users can still submit suggestions.
  • We should check that users can still submit suggestions.

They can.

Scardenasmolinar changed the task status from Open to In Progress.Thu, Apr 4, 2:55 PM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.