Maniphest T362007

[ES-M2]: Investigate why the ‘type’ is not shown for EntitySchema-valued statements in the Lua Debug Console
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Arian_Bozorg
	Sat, Apr 6, 3:58 PM

Description

Using the Lua Debug Console, loading an entity with an EntitySchema-valued statement works (e.g. mw.logObject(mw.wikibase.getEntity('P619'))), although the data value only has an id and not a type, which is unusual behaviour.

We must investigate why the type is not shown and whether that’s the correct behaviour.

Acceptance Criteria

Ensure there is no risk when using Lua functions for EntitySchemas when implementing the new patch from Product Platform

Notes
If the type can be added in less than one day of development we should move forward and implement it in this ticket

Related Objects
Search...

Status	Assigned	Task
Open	None	T91505 [Epic] Adding new datatypes to Wikidata (tracking)
Open	None	T214884 [ES-M2]: [EPIC] Linking EntitySchemas in statements
Resolved	• karapayneWMDE	T332139 [ES-M2]: Create a new EntitySchema data type
Open	None	T332157 [ES-M2]: Enable new EntitySchema data type on Wikidata
Open	None	T339920 [ES-M2]: Return EntitySchema as `wikibase-entityid` through the Action API
Open	None	T362000 [ES-M2]: [EPIC] Continue development of PoC EntitySchema patch
Resolved	None	T362007 [ES-M2]: Investigate why the ‘type’ is not shown for EntitySchema-valued statements in the Lua Debug Console

Event Timeline

Arian_Bozorg created this task.Sat, Apr 6, 3:58 PM

Lydia_Pintscher moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.Tue, Apr 9, 2:15 PM

Arian_Bozorg updated the task description. (Show Details)Wed, Apr 10, 11:27 AM

Arian_Bozorg moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Wed, Apr 10, 12:03 PM

Easy enough to fix:

diff --git a/src/Wikibase/Hooks/EntitySchemaValue.php b/src/Wikibase/Hooks/EntitySchemaValue.php
index ce125cc09e..14fa85bc05 100644
--- a/src/Wikibase/Hooks/EntitySchemaValue.php
+++ b/src/Wikibase/Hooks/EntitySchemaValue.php
@@ -39,7 +39,10 @@ public function getValue() {
 	}
 
 	public function getArrayValue(): array {
-		return [ 'id' => $this->id->getId() ];
+		return [
+			'id' => $this->id->getId(),
+			'type' => 'entityschema',
+		];
 	}
 
 	public function getSchemaId(): string {

I’ve squashed the above change into the Gerrit change that introduces the class; moving to peer review in case someone wants to take a look, but I don’t think it needs a lot more time spent on it :)

• Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Wed, Apr 17, 3:15 PM

Looks good - thank you!

ArthurTaylor closed this task as Resolved.Thu, Apr 18, 7:16 AM

ArthurTaylor moved this task from Ready for Peer Review to Done on the Wikidata Dev Team (Wikidata.org Slice) board.

[ES-M2]: Investigate why the ‘type’ is not shown for EntitySchema-valued statements in the Lua Debug ConsoleClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

[ES-M2]: Investigate why the ‘type’ is not shown for EntitySchema-valued statements in the Lua Debug Console
Closed, ResolvedPublic
Actions

Related Objects
Search...