Page MenuHomePhabricator

Redirected to file upload when trying to select another file in visual editor
Open, In Progress, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue:

  1. Enter the visual editor for an article edit (any article)
  2. Using the top toolbar, select Insert>Images and media
  3. Select any recently uploaded file or search for any (and then select one)
  4. Press the top-left "Back" (<) button in the file selection UI, and observe the issue

What happens?:

When pressing the "Back" button after having selected an image, the image or file selection UI redirects the user to the "Upload file" tab. The same happens when attempting to swap out an already-placed image.

What should have happened instead?:

The user should not be directed to the file upload, but back to the tab they were using (in this case, the "Recently uploaded" selection and search function).

Other information (browser name/version, screenshots, etc.):

Tested on nowiki and enwiki. Experiencing this in the browsers Chrome, Firefox, and Edge using Windows 10, whether logged in and not.

Event Timeline

I was unable to replicate this using your instructions. I was sent back to the Search tab instead of upload on enwiki.

I am experiencing this in the browsers Chrome, Firefox, and Edge using Windows 10, whether I'm logged in and not. What browser are you using?

Esanders subscribed.

Can also reproduce. I see the search tab briefly then I am redirected to the upload form.

zoe changed the task status from Open to In Progress.May 7 2024, 5:42 PM

I've also confirmed this. I just worked on another bug in the media viewer and found (by forgetting to bring my mediawiki instance back to the present!) that this is a relatively recent regression.

Change #1029622 had a related patch set uploaded (by Zoe; author: Zoe):

[mediawiki/extensions/VisualEditor@master] Fixes incorrect transition from searched image preview to upload panel

https://gerrit.wikimedia.org/r/1029622

Change #1029622 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fixes incorrect transition from searched image preview to upload panel

https://gerrit.wikimedia.org/r/1029622