Page MenuHomePhabricator

Edit recovery stores pages that have not changed (i.e. edit recovery entries can not be removed at all)
Open, MediumPublic

Description

Reproduce:

Another reproduce:

Another reproduce (2):

Another reproduce (3):

  • Enable edit recovery
  • Open edit tab of any existing page
  • Wait some seconds
  • Save the page without any change (and no revision will be created)
  • Open https://www.wikidata.org/wiki/Special:EditRecovery
  • Found the page you edited in Special:EditRecovery, which should not be

QA Results - Beta

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Bugreporter renamed this task from Edit recovery stores pages that have not changed to Edit recovery stores pages that have not changed (i.e. edit recovery entries can not be removed at all).Apr 9 2024, 12:02 PM
JWheeler-WMF subscribed.

@Bugreporter it sounds like opening the editor for any page will list the page in Special:EditRecovery, and it will index a page where there are discarded edits. This sounds like a bug, as Special:EditRecovery should only index pages where there is an unsaved edit.

This behaviour should be fixed now, after this change was merged — it deletes the stored data if it doesn't differ from the unchanged state of the form. There is still the case of this not working correctly for previewing, but this will be improved in T354494.

@Samwilson Edit recoveries are now removed from Special:EditRecovery based on the tests from the description which you can see from the videos below. I will move this to Done. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.43.0-alpha (66cdfc9)
OS: macOS Sonoma 14.4.1
Browser: Chrome 123
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://www.wikidata.org/w/index.php?title=Wikidata:Test1&action=edit
Special:EditRecovery

✅AC1: https://phabricator.wikimedia.org/T362150

✅AC2: https://phabricator.wikimedia.org/T362150

✅AC3: https://phabricator.wikimedia.org/T362150

✅AC4: https://phabricator.wikimedia.org/T362150