Edit recovery stores pages that have not changed (i.e. edit recovery entries can not be removed at all)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bugreporter
	Apr 9 2024, 11:57 AM

Description

Reproduce:

Enable edit recovery
Open edit tab of any (existing or non-existing) page, e.g. https://www.wikidata.org/w/index.php?title=Wikidata:Test1&action=edit&redlink=1
Wait some seconds
Open https://www.wikidata.org/wiki/Special:EditRecovery
You will see the page you edited appears in Special:EditRecovery, which should not be

Another reproduce:

Enable edit recovery
Open edit tab of any (existing or non-existing) page, e.g. https://www.wikidata.org/w/index.php?title=Wikidata:Test1&action=edit&redlink=1
Add or change some texts
Wait some seconds
Close the edit tab without save
Open https://www.wikidata.org/wiki/Special:EditRecovery
Found the page you edited in Special:EditRecovery
Click the edit link to edit it
Discard the recovered change
Close the edit tab
Open https://www.wikidata.org/wiki/Special:EditRecovery
That page is still listed in Special:EditRecovery

Another reproduce (2):

Enable edit recovery
Open edit tab of any (existing or non-existing) page, e.g. https://www.wikidata.org/w/index.php?title=Wikidata:Test1&action=edit&redlink=1
Add or change some texts
Use Ctrl-Z to revert the change
Wait some seconds
Close the edit tab (note no warning will be shown this time)
Open https://www.wikidata.org/wiki/Special:EditRecovery
Found the page you edited in Special:EditRecovery, which should not be

Another reproduce (3):

Enable edit recovery
Open edit tab of any existing page
Wait some seconds
Save the page without any change (and no revision will be created)
Open https://www.wikidata.org/wiki/Special:EditRecovery
Found the page you edited in Special:EditRecovery, which should not be

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T362150 here
2	✅	https://phabricator.wikimedia.org/T362150
3	✅	https://phabricator.wikimedia.org/T362150
4	✅	https://phabricator.wikimedia.org/T362150

Related Objects

Mentioned In: T355043: "Show preview" or "Show changes" twice can clear Edit Recovery data
Mentioned Here: rMW66cdfc9d4e18: Merge "Translate special page names into Polish"
T354494: Can’t discard changes after showing changes

Event Timeline

Bugreporter created this task.Apr 9 2024, 11:57 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptApr 9 2024, 11:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Bugreporter renamed this task from Edit recovery stores pages that have not changed to Edit recovery stores pages that have not changed (i.e. edit recovery entries can not be removed at all).Apr 9 2024, 12:02 PM

Bugreporter updated the task description. (Show Details)Apr 9 2024, 12:13 PM

@Bugreporter it sounds like opening the editor for any page will list the page in Special:EditRecovery, and it will index a page where there are discarded edits. This sounds like a bug, as Special:EditRecovery should only index pages where there is an unsaved edit.

This behaviour should be fixed now, after this change was merged — it deletes the stored data if it doesn't differ from the unchanged state of the form. There is still the case of this not working correctly for previewing, but this will be improved in T354494.

MusikAnimal subscribed.Apr 11 2024, 6:29 AM

TheresNoTime mentioned this in T355043: "Show preview" or "Show changes" twice can clear Edit Recovery data.Apr 11 2024, 9:42 AM

TheresNoTime subscribed.

Samwilson edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.Apr 12 2024, 1:41 AM

Samwilson moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.

JWheeler-WMF moved this task from Backlog to MVP Scope on the Edit Recovery board.Apr 15 2024, 2:42 PM

@Samwilson Edit recoveries are now removed from Special:EditRecovery based on the tests from the description which you can see from the videos below. I will move this to Done. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.43.0-alpha (66cdfc9)
OS: macOS Sonoma 14.4.1
Browser: Chrome 123
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://www.wikidata.org/w/index.php?title=Wikidata:Test1&action=edit
Special:EditRecovery

✅AC1: https://phabricator.wikimedia.org/T362150

✅AC2: https://phabricator.wikimedia.org/T362150

✅AC3: https://phabricator.wikimedia.org/T362150

✅AC4: https://phabricator.wikimedia.org/T362150

GMikesell-WMF updated the task description. (Show Details)Apr 15 2024, 6:57 PM

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

JWheeler-WMF closed this task as Resolved.May 22 2024, 2:13 PM

JWheeler-WMF claimed this task.

	F46819733: T362150_ER_StoresPages_4.webm
	Apr 15 2024, 6:56 PM

	F46819327: T362150_ER_StoresPages_3.webm
	Apr 15 2024, 6:56 PM

	F46819084: T362150_ER_StoresPages_2.webm
	Apr 15 2024, 6:56 PM

	F46820113: T362150_ER_StoresPages_1.webm
	Apr 15 2024, 6:56 PM

Edit recovery stores pages that have not changed (i.e. edit recovery entries can not be removed at all)Closed, ResolvedPublicActions

Description

QA Results - Beta

Related Objects

Event Timeline

Edit recovery stores pages that have not changed (i.e. edit recovery entries can not be removed at all)
Closed, ResolvedPublic
Actions