samtar opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/8

Draft: [WIP]: Implement "Project" section

samtar closed https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/8

Draft: [WIP]: Implement "Project" section

nb. using checkboxes instead of cards + checkboxes for drafting up this section

samtar opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/30

Draft: Implement "Project" section, again

@TheresNoTime it looks like this is in patch for review, can you update the column to be in review or in QA?

samtar opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/42

Project section, recreate MR 30

samtar closed https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/30

Draft: Implement "Project" section, again

If we can get !42 merged, I'll follow-up the outstanding things (the rebases will be easier once this baseline is merged, I hope)

samwilson merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/42

Project section, recreate MR 30

samtar opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/43

Follow-up: Add param to getData

samwilson merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/43

Follow-up: Add param to getData

The latest is now on Patch Demo.

@JWheeler-WMF @JSengupta-WMF I think we should rethink the top 4 projects. I suggest Wikipedia, Wikidata, Commons, Wikisource, as these historically are where most wishes come from (along with Wiktionary). MediaWiki.org does not have much for community-specific needs, and folks creating wishes for it may be referring to MediaWiki software in general, in which case they should probably use "All projects". Also note the existence of mediawiki.org as an option may invite wishes exclusively for 3rd party wikis, which would be pretty cool but I'm unsure if that's intentional.

I agree about the projects; I assumed the ones in the designs were examples/placeholders.

samtar opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/49

Follow-up: Add "it's something else" field

@MusikAnimal that's totally fine. I think the current top 4 projects are just indicative by Glauco. We should show the projects under which most of the wishes are received. If the above are top 4, feel free to change the order from design.

musikanimal updated https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/60

ProjectSection: adjust top 4 projects

samtar merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/60

ProjectSection: adjust top 4 projects

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/63

ProjectsSection: rework to use reactive data, Array prop type

samtar merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/63

ProjectsSection: rework to use reactive data, Array prop type

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/68

ProjectsSection: auto-check 'Select all', add indeterminate state

tstarling merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/68

ProjectsSection: auto-check 'Select all', add indeterminate state

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/80

ProjectSection: add 'Other project' field

musikanimal closed https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/49

Follow-up: Add "it's something else" field

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/83

ProjectsSection: replace mediawiki.org with Cloud Services

samwilson merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/83

ProjectsSection: replace mediawiki.org with Cloud Services

(I left this comment on the above MR, but should've made it here.)

I wonder if we want to change the other project keys to drop the leading group-? Not that people should be editing the template directly all that much of course, but after it's marked for translation they will be, and e.g. wiktionary rather than group-wiktionary seems more intuitive.

There also seems to be a bug if whitespace is added in the CSV string, e.g. if you manually set the field to wmcs, group-wiktionary,group-wikisource and then edit in the form, Wiktionary isn't selected and if you select it you end up with wmcs,group-wiktionary, group-wiktionary,group-wikisource.

samtar merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/80

ProjectSection: add 'Other project' field

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/84

Wish: add helpers to normalize csv <> array

In T362275#9905685, @Samwilson wrote:

I wonder if we want to change the other project keys to drop the leading group-? Not that people should be editing the template directly all that much of course, but after it's marked for translation they will be, and e.g. wiktionary rather than group-wiktionary seems more intuitive.

The multilingual wikis use i.e. name-wikifunctionswiki so the string interpolation wouldn't work. We can of course just add a switch statement in the template/module and do as you say. I'll look into it.

There also seems to be a bug if whitespace is added in the CSV string, e.g. if you manually set the field to wmcs, group-wiktionary,group-wikisource and then edit in the form, Wiktionary isn't selected and if you select it you end up with wmcs,group-wiktionary, group-wiktionary,group-wikisource.

Fixed with !84. Thanks for identifying!

samwilson merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/84

Wish: add helpers to normalize csv <> array

The multilingual wikis use i.e. name-wikifunctionswiki so the string interpolation wouldn't work. We can of course just add a switch statement in the template/module and do as you say. I'll look into it.

I'm not sure how much it matters, but if we want to change it after the system is launched it'll be more annoying.

Fixed with !84. Thanks for identifying!

Thanks for fixing it so quickly! I was going to look at it. :)

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/88

WishStore: fix references to obsolete fields, add other_project

tstarling merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/88

WishStore: fix references to obsolete fields, add other_project

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/93

ProjectSection: simplify project IDs

samwilson merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/93

ProjectSection: simplify project IDs

Am I seeing the correct behaviour here? If I manually add random other project names in |projects=, they don't get removed when editing and saving via the form. Should we be deleting them, as they don't appear in the form?

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/107

ProjectsSection: remove unknown projects when (de-)selecting

Am I seeing the correct behaviour here? If I manually add random other project names in |projects=, they don't get removed when editing and saving via the form. Should we be deleting them, as they don't appear in the form?

What a cool bug! Thanks for discovering this. The MR above should take care of it.

samwilson merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/107

ProjectsSection: remove unknown projects when (de-)selecting

@MusikAnimal Can you review AC2, thanks!

Test Result - Wishlist-test.toolforge

Status: ❌ FAIL AC2
Environment: Wishlist-test.toolforge
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):
✅AC1: Navigate in the project section

• Implement the "Project" section according to the designs
• Users should be able to click anywhere on a card and select or de-select a project
• Clicking "All projects" should expand the the accordion and select all projects
• Deselecting "All projects" should do the inverse
• Manually selecting each project should tick "All projects", as one would expect.

AC2: It's something else
❌should have 3+ characters in the text area

I was able to submit with 2 characters

Should I be able to see what I type in the project section?

I haven't touched validation states because I don't want to step on toes. That's covered by T363218.

Looks like that's the only issue so I'll just move this to Done.