Page MenuHomePhabricator

When a patroller marks an article as patrolled, do not give tray notification to article author for articles in draftspace
Closed, ResolvedPublicFeature

Description

Requested by @TechnoSquirrel69 on Discord

Feature summary (what you would like to be able to do and where):

  • When a patroller marks an article as patrolled, do not give tray notification to article author for articles NOT in mainspace (e.g. draftspace, userspace, etc.)

image.png (319×981 px, 32 KB)

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):

Benefits (why should this be implemented?):

Notes

  • the page curation toolbar doesn't even show up in draftspace. so the patroller must be using the [Mark this page as patrolled] link that shows up at the bottom right. therefore the code for this is probably in the onMarkPatrolledComplete hook
  • root cause is that PageTriageUtil::getNamespaces() also includes draftspace. draftspace is odd because it does need to add entries to the pagetriage SQL tables so it shows up in the NewPagesFeed, but we do not display a Page Curation toolbar there and we do not want editors to get patrol notifications there

Event Timeline

Change #1032125 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Do not notify authors when pages NOT in mainspace get patrolled

https://gerrit.wikimedia.org/r/1032125

Novem_Linguae renamed this task from When a patroller marks an article as patrolled, do not give tray notification to article author for articles NOT in mainspace to When a patroller marks an article as patrolled, do not give tray notification to article author for articles in draftspace.Jun 6 2024, 6:12 AM
Novem_Linguae updated the task description. (Show Details)

Change #1032125 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Do not notify authors when pages NOT in mainspace get patrolled

https://gerrit.wikimedia.org/r/1032125

Novem_Linguae assigned this task to Soda.