Page MenuHomePhabricator
Create Task
Maniphest T362553

time/bytes (when including sections) overlaps history rows
Open, MediumPublicBUG REPORT
Actions

Assigned To
None
Authored By
Jdlrobson
Mon, Apr 15, 4:18 PM
Tags
Referenced Files
F46996863: Screenshot 2024-04-16 at 8.31.09 AM.png
Tue, Apr 16, 3:31 PM
F46819049: Screenshot 2024-04-15 at 2.37.45 PM.png
Mon, Apr 15, 6:41 PM
F46805966: Screenshot 2024-04-15 at 1.21.22 PM.png
Mon, Apr 15, 5:22 PM
F46795574: Screenshot 2024-04-15 at 9.15.29 AM.png
Mon, Apr 15, 4:18 PM
Subscribers
Aklapper
Jdlrobson
Jdrewniak

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Overlaps

Screenshot 2024-04-15 at 9.15.29 AM.png (938×2 px, 175 KB)

The display doesn't seem to expect the display of seconds (presumably a preference)

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Does not occur on English:
https://en.m.wikipedia.org/w/index.php?title=Paris&action=history

Related Objects

Event Timeline

Jdlrobson created this task.Mon, Apr 15, 4:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Apr 15, 4:18 PM
Jdlrobson added a project: Web-Team-Backlog.Mon, Apr 15, 4:18 PM
Jdrewniak subscribed.Mon, Apr 15, 4:56 PM

This is largely the same issue as T362297 introduced in this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1015636.
that patch modifies the thumbnail styles to add a grey background and a fixed width. The watchlist table uses the thumbnail class for the +/- column.
Hopefully this is address in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1019178.

Jdlrobson added a comment.Mon, Apr 15, 4:58 PM

Are you sure? I thought we backported the fix for T362297 ? Is that not correct?

I thought this might be localization related as usually the seconds do not show in timestamps...

Jdrewniak added a comment.Mon, Apr 15, 5:22 PM

Oh your right, I guess that column has had a static 70px width before.

Screenshot 2024-04-15 at 1.21.22 PM.png (558×2 px, 361 KB)

Jdrewniak added a comment.EditedMon, Apr 15, 6:41 PM

Just digging into this a bit, some context that I had forgotten: the watchlist and history pages look similar, but they actually have totally different markup. The history page has html taken from core and made to look like the watchlist page, whereas the watchlist page has html tailored for mobile.
Regardless, it looks like the overlap is actually caused by the different time format used by ptwiki. If using that same format on enwiki, the overlap would appear there too:

Screenshot 2024-04-15 at 2.37.45 PM.png (1×1 px, 268 KB)

EDIT: reading the description more closely, I see the above has already been pointed out 😅

Jdlrobson added a project: Moderator-Tools-Team.Mon, Apr 15, 7:10 PM
ovasileva triaged this task as Medium priority.Tue, Apr 16, 7:12 AM
ovasileva moved this task from Incoming to Groomed on the Web-Team-Backlog board.
Jdlrobson renamed this task from time (when including sections) overlaps history rows to time/bytes (when including sections) overlaps history rows.Tue, Apr 16, 3:30 PM

Also seen on https://en.m.wikipedia.org/wiki/Spain?action=history

Screenshot 2024-04-16 at 8.31.09 AM.png (1×2 px, 193 KB)

Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Tue, Apr 23, 12:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL