Page MenuHomePhabricator
Create Task
Maniphest T362692

Expected logspam from ProofreadPage
Closed, ResolvedPublic
Actions

Description

I expect we'll get logspam from ProofreadPage on wikisource wikis caused by the deprecation of dynamic property access (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1004257).

This is patched in master at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1020249 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/1020250 -- both patches are necessary because ProofreadPage does an unset on the property, so without 1020250 the declared property will become dynamic again after the unset and start emitting deprecation warnings again.

I will prepare backport patches for 1.43-wmf.1 for these, but I may have intermittent connectivity over the next few days (presenting at MWUD 2024 conference) so I wanted to make sure there was a task and explanation here to empower SREs to handle the backports (and any similar log spam that may arise) in my absence.

Details

SubjectRepoBranchLines +/-
The dynamic Parser::$mTemplatePath property has been made actualmediawiki/extensions/LabeledSectionTransclusionREL1_42+1 -1
[Parser] Add deprecated Parser::$mTemplatePath propertymediawiki/coreREL1_42+2 -0
Workaround dynamic Parser::$proofreadRenderingPages propertymediawiki/extensions/ProofreadPageREL1_42+2 -4
Workaround dynamic Parser::$proofreadRenderingPages propertymediawiki/extensions/ProofreadPagemaster+2 -4
The dynamic Parser::$mTemplatePath property has been made actualmediawiki/extensions/LabeledSectionTransclusionmaster+1 -1
[Parser] Add deprecated Parser::$mTemplatePath propertymediawiki/coremaster+2 -0
[Parser] Temporarily disable deprecation warnings for dynamic propertiesmediawiki/corewmf/1.43.0-wmf.1+2 -1
[Parser] Temporarily disable deprecation warnings for dynamic propertiesmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasedancyT361395 1.43.0-wmf.1 deployment blockers
 ResolvedcscottT362692 Expected logspam from ProofreadPage

Event Timeline

cscott created this task.Tue, Apr 16, 4:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Apr 16, 4:05 PM
cscott added a parent task: T361395: 1.43.0-wmf.1 deployment blockers.Tue, Apr 16, 4:05 PM
cscott renamed this task from Logspam from Proofread page to Expected logspam from ProofreadPage.Tue, Apr 16, 4:09 PM
cscott updated the task description. (Show Details)
dancy subscribed.Tue, Apr 16, 4:15 PM

Please do apply the 1.43.0-wmf.1 backport ASAP so we don't have any issues w/ log spam.

gerritbot added a comment.Tue, Apr 16, 4:21 PM

Change #1020282 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [Parser] Add deprecated Parser::$mTemplatePath property

https://gerrit.wikimedia.org/r/1020282

gerritbot added a project: Patch-For-Review.Tue, Apr 16, 4:21 PM

Change #1020284 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/LabeledSectionTransclusion@master] The dynamic Parser::$mTemplatePath property has been made actual

https://gerrit.wikimedia.org/r/1020284

gerritbot added a comment.Tue, Apr 16, 4:22 PM

Change #1020250 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/ProofreadPage@master] Workaround dynamic Parser::$proofreadRenderingPages property

https://gerrit.wikimedia.org/r/1020250

ssastry subscribed.EditedTue, Apr 16, 4:40 PM

@cscott and I are chatting and we may just suppress the deprecation (and backport that one patch to Parser.php) instead of having to backport a series of patches. We'll let all these change right the next train and in the meantime, see if there are other instances that trigger this deprecation.

gerritbot added a comment.Tue, Apr 16, 5:10 PM

Change #1020293 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [Parser] Temporarily disable deprecation warnings for dynamic properties

https://gerrit.wikimedia.org/r/1020293

gerritbot added a comment.Tue, Apr 16, 5:27 PM

Change #1020231 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@wmf/1.43.0-wmf.1] [Parser] Temporarily disable deprecation warnings for dynamic properties

https://gerrit.wikimedia.org/r/1020231

cscott added a comment.Tue, Apr 16, 5:42 PM

Ok, here's the status:

  1. The root cause is that some extensions which use dynamic properties of $parser aren't included in (or aren't adequately tested by) the gated-extensions CI, so there's a risk of log spam about dynamic properties this week during the train.
  2. As mentioned above, I'm traveling to the MediaWiki Users and Developers Conference tonight-Friday this week, so I won't necessarily be available to deal with these in a timely manner.
  3. The "proper" fix to any logspam found involves (a) a new phab task to record the need to eventually remove the newly added property (these should be children of T343227), (b) adding the dynamic property as a real property of Parser, and (c) patching the extension itself to replace any unset($parser->dynamicProperty) with $parser->dynamicProperty = null since after the unset even a declared property will become "dynamic" again and start to trigger warnings. Also phan often has "undeclared property" suppressions that then start to fail once the property /actually exists/ and so to unbreak the extension's CI those need to be removed.
  4. One option is the backport the 4 patches to 1.43-wmf.1 and then either suppress any other logspam found during the train (it is harmless) or else backport additional pairs of patches as in item 3 above: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1020282 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/LabeledSectionTransclusion/+/1020284 for LST; and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1020249 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/1020250 for ProofreadPage.
  5. The other (preferred) option is to backport https://gerrit.wikimedia.org/r/1020231 to 1.43.0-wmf.1 to temporarily disable the deprecation warnings for 1.43.0-wmf.1. The ProofreadPage/LST patches will ride the train on 1.43.0-wmf.2 along with re-enabled deprecation warnings -- and if any further Bad Extensions are found, I will be back from the conference and available to patch and backport to fix them (or we can cherry-pick the "temporarily disable deprecation warnings" patch and rinse and repeat.)
dancy added a comment.Tue, Apr 16, 6:06 PM

I'm going with option 5.

gerritbot added a comment.Tue, Apr 16, 6:09 PM

Change #1020293 abandoned by C. Scott Ananian:

[mediawiki/core@master] [Parser] Temporarily disable deprecation warnings for dynamic properties

Reason:

cherry-picked, but we don't need to merge and immediately revert on master

https://gerrit.wikimedia.org/r/1020293

gerritbot added a comment.Tue, Apr 16, 6:25 PM

Change #1020231 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.1] [Parser] Temporarily disable deprecation warnings for dynamic properties

https://gerrit.wikimedia.org/r/1020231

Stashbot added a comment.Tue, Apr 16, 6:26 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-16T18:26:01Z] <dancy@deploy1002> Started scap: Backport for [[gerrit:1020231|[Parser] Temporarily disable deprecation warnings for dynamic properties (T362692)]]

Stashbot added a comment.Tue, Apr 16, 6:29 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-16T18:29:05Z] <dancy@deploy1002> cscott and dancy: Backport for [[gerrit:1020231|[Parser] Temporarily disable deprecation warnings for dynamic properties (T362692)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Tue, Apr 16, 6:48 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-16T18:48:57Z] <dancy@deploy1002> Finished scap: Backport for [[gerrit:1020231|[Parser] Temporarily disable deprecation warnings for dynamic properties (T362692)]] (duration: 22m 56s)

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Tue, Apr 16, 7:00 PM
cscott closed this task as Resolved.Tue, Apr 16, 7:36 PM
cscott claimed this task.

After the backport, tested https://test.wikipedia.org/wiki/User:Cscott/LST?useparsoid=0&action=purge and https://test.wikipedia.org/wiki/User:Cscott/LST?useparsoid=1&action=purge when 1.43-wmf.1 was on testwikis and couldn't trigger the deprecation warning, so calling this fixed.

The warning was disabled on 1.43-wmf.1 but not on master, so the ProofreadPage and LST patches will ride the 1.43-wmf.2 train along with the re-enabled deprecation warnings.

gerritbot added a comment.Wed, Apr 17, 2:54 AM

Change #1020282 merged by jenkins-bot:

[mediawiki/core@master] [Parser] Add deprecated Parser::$mTemplatePath property

https://gerrit.wikimedia.org/r/1020282

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.2; 2024-04-23); removed MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Wed, Apr 17, 3:00 AM
gerritbot added a comment.Wed, Apr 17, 3:44 AM

Change #1020284 merged by jenkins-bot:

[mediawiki/extensions/LabeledSectionTransclusion@master] The dynamic Parser::$mTemplatePath property has been made actual

https://gerrit.wikimedia.org/r/1020284

gerritbot added a comment.Wed, Apr 17, 5:45 AM

Change #1020250 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Workaround dynamic Parser::$proofreadRenderingPages property

https://gerrit.wikimedia.org/r/1020250

gerritbot added a comment.Fri, Apr 19, 4:31 PM

Change #1021798 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/ProofreadPage@REL1_42] Workaround dynamic Parser::$proofreadRenderingPages property

https://gerrit.wikimedia.org/r/1021798

gerritbot added a comment.Fri, Apr 19, 4:34 PM

Change #1021799 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_42] [Parser] Add deprecated Parser::$mTemplatePath property

https://gerrit.wikimedia.org/r/1021799

gerritbot added a comment.Fri, Apr 19, 4:34 PM

Change #1021800 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/LabeledSectionTransclusion@REL1_42] The dynamic Parser::$mTemplatePath property has been made actual

https://gerrit.wikimedia.org/r/1021800

gerritbot added a comment.Wed, Apr 24, 10:42 PM

Change #1021799 merged by jenkins-bot:

[mediawiki/core@REL1_42] [Parser] Add deprecated Parser::$mTemplatePath property

https://gerrit.wikimedia.org/r/1021799

gerritbot added a comment.Wed, Apr 24, 10:42 PM

Change #1021798 merged by Arlolra:

[mediawiki/extensions/ProofreadPage@REL1_42] Workaround dynamic Parser::$proofreadRenderingPages property

https://gerrit.wikimedia.org/r/1021798

ReleaseTaggerBot added a project: MW-1.42-notes.Wed, Apr 24, 11:00 PM
gerritbot added a comment.Thu, Apr 25, 2:23 PM

Change #1021800 merged by jenkins-bot:

[mediawiki/extensions/LabeledSectionTransclusion@REL1_42] The dynamic Parser::$mTemplatePath property has been made actual

https://gerrit.wikimedia.org/r/1021800

Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 5:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL