Page MenuHomePhabricator

Call to a member function getName() on bool
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • A job is added to the queue
  • The file is deleted (or moved)
  • The job is run
  • Run checks for file presence
  • File is missing so we go to setTranscodeError
  • setTranscodeError calls getFile()->getName()
  • getfile returns false and we have an error.

What should have happened instead?:
It should not have used getFile()->getName(). instead we can simply use this->title

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

from /srv/mediawiki/php-1.42.0-wmf.26/extensions/TimedMediaHandler/includes/WebVideoTranscode/WebVideoTranscodeJob.php(208)
#0 /srv/mediawiki/php-1.42.0-wmf.26/extensions/TimedMediaHandler/includes/WebVideoTranscode/WebVideoTranscodeJob.php(231): MediaWiki\TimedMediaHandler\WebVideoTranscode\WebVideoTranscodeJob->setTranscodeError(string, string)
#1 /srv/mediawiki/php-1.42.0-wmf.26/extensions/EventBus/includes/JobExecutor.php(80): MediaWiki\TimedMediaHandler\WebVideoTranscode\WebVideoTranscodeJob->run()
#2 /srv/mediawiki/rpc/RunSingleJob.php(60): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#3 {main}

Event Timeline

ovasileva added subscribers: thcipriani, ovasileva.

@thcipriani - this one is not maintained by the web team, but we're not sure what to more accurately tag it with either. Untagging for now