Spicerack support for dbctl
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	CDanis
	Apr 18 2024, 2:16 PM

Description

Spicerack has a library for conftool entities generically, which allows you to edit things like dbconfig-instance entities.

But dbctl has very non-trivial logic implemented in the CLI tool itself for vital tasks like generating and commiting the mwconfig block.

Ideally instead of those being directly in the CLI implementation, they'd be exposed as a library that was used by the CLI tool, and then could also be used from Spicerack.

Details

	Subject	Repo	Branch	Lines +/-
	dbctl: add new module to interact with dbctl	operations/software/spicerack	master	+141 -2
	confctl: add native support for RO in conftool	operations/software/spicerack	master	+31 -10

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
		Unknown Object (Task)
Resolved	Jhancock.wm	T342174 Q1:rack/setup/install db21[88-95]
Resolved	ABran-WMF	T343674 Productionize db21[88-95]
Resolved	LSobanski	T156461 [META ticket] Automation for our DBs tracking task
Open	ABran-WMF	T239814 Automate DB upgrades
Resolved	Volans	T362893 Spicerack support for dbctl
Resolved	ABran-WMF	T368881 Make sre.mysql.clone handling pooling/depooling
Open	ABran-WMF	T374191 upgrade clone cookbook
Declined	ABran-WMF	T376712 mysql_legacy: SQL query quote escape
Resolved	ABran-WMF	T376701 mysql_legacy data_directory getter
Resolved	ABran-WMF	T377129 mariadb: systemctl status accessor in mysql_legacy
Open	None	T369295 Cookbook to create a sanitarium host from scratch
Open	ABran-WMF	T374026 Allow operator to repool a set of nodes in parallel

Event Timeline

CDanis created this task.Apr 18 2024, 2:16 PM

Restricted Application added a project: SRE-tools. · View Herald TranscriptApr 18 2024, 2:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

CDanis triaged this task as Low priority.Apr 18 2024, 2:17 PM

Restricted Application added a project: Infrastructure-Foundations. · View Herald TranscriptApr 18 2024, 2:17 PM

CDanis mentioned this in T360029: Integrate dbctl IP changes as part of VLAN changes. .Apr 18 2024, 2:18 PM

ABran-WMF subscribed.May 22 2024, 12:45 PM

ABran-WMF added a subtask: T368881: Make sre.mysql.clone handling pooling/depooling.Jul 1 2024, 8:36 AM

ABran-WMF added a project: DBA.

ABran-WMF moved this task from Triage to Ready on the DBA board.

ABran-WMF mentioned this in T368881: Make sre.mysql.clone handling pooling/depooling.

ABran-WMF added a subscriber: Marostegui.

ABran-WMF raised the priority of this task from Low to Medium.Jul 1 2024, 12:55 PM

ABran-WMF added a subtask: T369295: Cookbook to create a sanitarium host from scratch.Jul 4 2024, 2:17 PM

ABran-WMF changed the status of subtask T369295: Cookbook to create a sanitarium host from scratch from Open to In Progress.

FYI I'm starting to work on this as part of my tenure in Data Persistence.

ABran-WMF awarded a token.Jul 11 2024, 3:56 PM

volans opened https://gitlab.wikimedia.org/repos/sre/conftool/-/merge_requests/9

dbconfig: move logic to the library

oblivian merged https://gitlab.wikimedia.org/repos/sre/conftool/-/merge_requests/9

dbconfig: move logic to the library

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2024, 1:31 PM

Change #1055882 had a related patch set uploaded (by Volans; author: Giuseppe Lavagetto):

[operations/software/spicerack@master] confctl: add native support for RO in conftool

https://gerrit.wikimedia.org/r/1055882

Change #1058586 had a related patch set uploaded (by Volans; author: Volans):

[operations/software/spicerack@master] dbctl: add new module to interact with dbctl

https://gerrit.wikimedia.org/r/1058586

Status update:
The conftool improvements (here and here) enabled to support dry-run in spicerack for conftool, that gets added here (to be merged) and finally the possibility of dbctl wrapper in spicerack here (to be merged).