Do not display tpt-mark-nochanges when marking page for translation for the first time
Open, LowPublicBUG REPORT
Actions

Assigned To

None

Authored By

	abi_
	Apr 25 2024, 5:28 AM

Description

Steps to replicate the issue (include links if applicable):

Create a page to mark for translation with the following content

<translate>
<!--T:hello-world-->
New translation unit!
</translate>

Start marking the page for translation

What happens?:
I see a notice stating:

No changes to review. Marking this page for translation will not edit the page nor any existing translation unit.

What should have happened instead?:
The notice should not be displayed since this is the first time the page is being marked for translation

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Reproducible on https://meta.wikimedia.org/w/index.php?title=Special:PageTranslation&target=User%3AAPatro+%28WMF%29%2FTestBug&do=mark

Other information (browser name/version, screenshots, etc.):
This appears to be a problem if the translation units are given unit names manually.

Related Objects

Mentioned Here: T50672: When marking for translations, if there are no differences just say so

Event Timeline

abi_ created this task.Apr 25 2024, 5:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2024, 5:28 AM

Reducing priority as the page can still be marked for translation.

Well, it’s true that marking the page for translation won’t edit the page (if you didn’t add the unit ID, marking for translation would edit the page to add the auto-generated ID).

On the other hand, the message doesn’t appear when there are really no changes (e.g. after reverting a vandal edit), and looking at the history, this has always been so since the feature was implemented for T50672: When marking for translations, if there are no differences just say so: if the page has a marked tag, the message doesn’t appear.

So I’d either:

Remove the feature. It’s totally broken and no one complained about this in the past decade, so it’s probably not that important.
Fix the feature to work when re-marking the page for translation. However, I’m not sure whether what you describe as a bug is really a bug and should be fixed.

Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.Apr 25 2024, 8:34 AM

abi_ updated the task description. (Show Details)Apr 25 2024, 8:34 AM

Do not display tpt-mark-nochanges when marking page for translation for the first timeOpen, LowPublicBUG REPORTActions

Description

Related Objects

Event Timeline

Do not display tpt-mark-nochanges when marking page for translation for the first time
Open, LowPublicBUG REPORT
Actions