Page MenuHomePhabricator

Do not display tpt-mark-nochanges when marking page for translation for the first time
Open, LowPublicBUG REPORT


Steps to replicate the issue (include links if applicable):

  • Create a page to mark for translation with the following content
New translation unit!
  • Start marking the page for translation

What happens?:
I see a notice stating:

No changes to review. Marking this page for translation will not edit the page nor any existing translation unit.

image.png (835×1 px, 58 KB)

What should have happened instead?:
The notice should not be displayed since this is the first time the page is being marked for translation

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Reproducible on

Other information (browser name/version, screenshots, etc.):
This appears to be a problem if the translation units are given unit names manually.

Event Timeline

abi_ triaged this task as Low priority.Apr 25 2024, 5:29 AM

Reducing priority as the page can still be marked for translation.

Well, it’s true that marking the page for translation won’t edit the page (if you didn’t add the unit ID, marking for translation would edit the page to add the auto-generated ID).

On the other hand, the message doesn’t appear when there are really no changes (e.g. after reverting a vandal edit), and looking at the history, this has always been so since the feature was implemented for T50672: When marking for translations, if there are no differences just say so: if the page has a marked tag, the message doesn’t appear.

So I’d either:

  • Remove the feature. It’s totally broken and no one complained about this in the past decade, so it’s probably not that important.
  • Fix the feature to work when re-marking the page for translation. However, I’m not sure whether what you describe as a bug is really a bug and should be fixed.