Page MenuHomePhabricator

UploadWizard homeButton mal formatted link
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Create an Upload Campaign with a homeButton link specified.
  • Go through the upload process and then click on the link on the last page.

What happens?:

The link goes to https://commons.wikimedia.org/w/SPECIFIEDPAGE which does not exists and just shows an error page.

What should have happened instead?:

The link should go to https://commons.wikimedia.org/wiki/SPECIFIEDPAGE instead.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Notes for QA - will need to create a campaign with this config

{
	"enabled": true,
	"title": "Some title",
	"display": {
		"homeButton": {
			"label": "Some label",
			"target": "<target>"
		}
	}
}

... and test with target set to:

  • the string 'useObjref'
  • an absolute url
  • a main-namespace page title
  • a non-main-namespace page title

Event Timeline

mfossati changed the task status from Open to In Progress.Apr 30 2024, 9:23 AM
mfossati claimed this task.

Change #1025725 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):

[mediawiki/extensions/UploadWizard@master] Upload Wizard Use step: handle home button's href

https://gerrit.wikimedia.org/r/1025725

Change #1025725 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Upload Wizard Use step: handle home button's href

https://gerrit.wikimedia.org/r/1025725

Etonkovidova subscribed.

Checked on commons beta, e.g. uploads via this example campaign. Closing as Resolved.