Page MenuHomePhabricator
Create Task
Maniphest T363741

Radio disabled+selected state should be visually distinct
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue:

According to these Codex docs, the interaction state for disabled+selected radio buttons should appear as pictured below (#10):

Screenshot 2024-04-29 at 2.11.31 PM.png (432×1 px, 68 KB)

What happens?:

In reality though, the disabled and selected+disabled states are not visually distinguishable:

Screenshot 2024-04-29 at 2.15.32 PM.png (344×616 px, 42 KB)

Software version :

Codex v1.4.0

Details

SubjectRepoBranchLines +/-
Update Codex from v1.6.1 to v1.7.0mediawiki/coremaster+604 -376
demos: Add Vue version of disabled Radio groupdesign/codexmain+14 -2
Radio: Add disabled+selected state stylesdesign/codexmain+36 -5
Customize query in gerrit

Event Timeline

Jdrewniak created this task.Apr 29 2024, 6:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2024, 6:19 PM
CCiufo-WMF triaged this task as High priority.Apr 29 2024, 8:09 PM
CCiufo-WMF set the point value for this task to 3.
CCiufo-WMF moved this task from Inbox to Up Next on the Design-System-Team board.
CCiufo-WMF subscribed.

Thanks for filing @Jdrewniak! We'll look into this next sprint.

gerritbot added a comment.May 5 2024, 11:03 AM

Change #1027553 had a related patch set uploaded (by Akiel; author: Akiel):

[design/codex@main] Radio: Add disabled+selected state styles

https://gerrit.wikimedia.org/r/1027553

gerritbot added a project: Patch-For-Review.May 5 2024, 11:03 AM
CCiufo-WMF lowered the priority of this task from High to Medium.May 13 2024, 6:27 PM
gerritbot added a comment.May 30 2024, 2:33 PM

Change #1037549 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] demos: Add Vue version of disabld Radio group

https://gerrit.wikimedia.org/r/1037549

gerritbot added a comment.May 30 2024, 3:28 PM

Change #1027553 merged by jenkins-bot:

[design/codex@main] Radio: Add disabled+selected state styles

https://gerrit.wikimedia.org/r/1027553

gerritbot added a comment.May 30 2024, 3:29 PM

Change #1037549 merged by jenkins-bot:

[design/codex@main] demos: Add Vue version of disabled Radio group

https://gerrit.wikimedia.org/r/1037549

Maintenance_bot removed a project: Patch-For-Review.May 30 2024, 3:32 PM
Volker_E edited projects, added Design-System-Team (DST-Sprint-24 (2024-05-28 to 2024-06-07)); removed Design-System-Team.May 30 2024, 8:10 PM
Volker_E moved this task from Committed to Pending Release on the Design-System-Team (DST-Sprint-24 (2024-05-28 to 2024-06-07)) board.
gerritbot added a comment.Tue, Jun 11, 8:54 PM

Change #1041776 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v1.6.1 to v1.7.0

https://gerrit.wikimedia.org/r/1041776

gerritbot added a project: Patch-For-Review.Tue, Jun 11, 8:54 PM
gerritbot added a comment.Tue, Jun 11, 10:06 PM

Change #1041776 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.6.1 to v1.7.0

https://gerrit.wikimedia.org/r/1041776

Catrope closed this task as Resolved.Tue, Jun 11, 10:09 PM
Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 11, 10:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits