Maniphest T364564

Pin the wasmedge-quickjs Dependency to a Specific Commit
Open, In Progress, HighPublic
Actions

Assigned To

Authored By

	cmassaro
	Thu, May 9, 4:49 PM

Tags

Referenced Files

None

Subscribers

Description

Description

In theory, if wasmedge-quickjs ever updated, it could break our tests. We should specify a commit in our git clone command to avoid this.

This adds a maintenance burden: we must now update this commit periodically, whenever/if ever wasmedge-quickjs gets updated.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

pinned commit
plan for updates to the commit

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

	Title	Reference	Author	Source Branch	Dest Branch
	Specify QuickJS version to prevent devastation from breaking changes	repos/abstract-wiki/wikifunctions/function-evaluator!220	ecarg	grace/T364564/pin-specific-quickjs-version	main

Customize query in GitLab

Event Timeline

cmassaro created this task.Thu, May 9, 4:49 PM

Jdforrester-WMF triaged this task as High priority.Wed, May 15, 4:33 PM

Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.

Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.

we don't specify the version we are using

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/220

Specify QuickJS version to prevent devastation from breaking changes

Jdforrester-WMF assigned this task to ecarg.Thu, May 30, 5:38 PM

Jdforrester-WMF moved this task from Backlog to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.

Jdforrester-WMF edited projects, added Abstract Wikipedia team (24Q4 (Apr–Jun)); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to In Progress on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/220

Specify QuickJS version to prevent devastation from breaking changes

Jdforrester-WMF moved this task from In Progress to Ready to deploy on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Thu, May 30, 7:02 PM

Maintenance_bot removed a project: Patch-For-Review.Thu, May 30, 7:32 PM