Maniphest T364815

Remove version from docker-compose.yml
Closed, DuplicatePublic
Actions

Assigned To

Authored By

	kostajh
	May 14 2024, 6:26 AM

Tags

Referenced Files

	F53159889: image.png
	May 14 2024, 7:46 AM

	F53159731: image.png
	May 14 2024, 7:46 AM

	F53159601: image.png
	May 14 2024, 7:46 AM

Subscribers

Description

Context

"WARN[0000] /home/novemlinguae/mediawiki/
docker-compose.yml: version is obsolete"

Fixes "WARN[0000] /home/novemlinguae/mediawiki/
docker-compose.yml: version is obsolete"

Proposal

Remove the version key in docker-compose.yml.

Consequences

Potentially older versions of Docker (pre 2022 / 4.9.1) could have issues without the version number present.

Details

	Subject	Repo	Branch	Lines +/-
	remove deprecated yaml key	mediawiki/services/push-notifications	master	+0 -3
	docs: remove deprecated `version` key from docker examples	mediawiki/core	master	+0 -3
	remove deprecated yaml key	wikidata/query/rdf	master	+0 -1
	docker-compose.yml: Remove obsolete version element	mediawiki/core	master	+0 -1

Customize query in gerrit

Related Objects

Mentioned In: rMSPN54f3fb3e3457: remove deprecated yaml key
Mentioned Here: T362669: docker-compose.yml `version` is now obsolete with Docker Desktop v4.29.0

Event Timeline

kostajh created this task.May 14 2024, 6:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2024, 6:26 AM

Change #1031041 had a related patch set uploaded (by Kosta Harlan; author: Novem Linguae):

[mediawiki/core@master] docker-compose.yml: delete version

https://gerrit.wikimedia.org/r/1031041

gerritbot added a project: Patch-For-Review.May 14 2024, 6:26 AM

Omitting version keys, or having combinations of version keys in some .yml files but not others, in two year old versions of Docker seems to work fine.

image.png (897×773 px, 69 KB)

image.png (631×1 px, 94 KB)

image.png (653×1 px, 110 KB)

+2'ed the patch, thanks @Novem_Linguae !

Change #1031041 merged by jenkins-bot:

[mediawiki/core@master] docker-compose.yml: Remove obsolete version element

https://gerrit.wikimedia.org/r/1031041

Had filed T362669: docker-compose.yml `version` is now obsolete with Docker Desktop v4.29.0 this a while ago. Possibly related.

Maintenance_bot removed a project: Patch-For-Review.May 14 2024, 8:30 AM

Novem_Linguae closed this task as a duplicate of T362669: docker-compose.yml `version` is now obsolete with Docker Desktop v4.29.0.May 14 2024, 8:31 AM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 14 2024, 9:00 AM

Change #1036350 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/core@master] docs: remove deprecated yaml key

https://gerrit.wikimedia.org/r/1036350

Change #1036366 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/services/push-notifications@master] docs: remove deprecated yaml key

https://gerrit.wikimedia.org/r/1036366

Change #1036367 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[wikidata/query/rdf@master] docs: remove deprecated yaml key

https://gerrit.wikimedia.org/r/1036367

Change #1036367 merged by jenkins-bot:

[wikidata/query/rdf@master] remove deprecated yaml key

https://gerrit.wikimedia.org/r/1036367

Change #1036350 merged by jenkins-bot:

[mediawiki/core@master] docs: remove deprecated `version` key from docker examples

https://gerrit.wikimedia.org/r/1036350

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.8; 2024-06-04); removed MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).Tue, May 28, 2:00 PM

Change #1036366 merged by jenkins-bot:

[mediawiki/services/push-notifications@master] remove deprecated yaml key

https://gerrit.wikimedia.org/r/1036366

Novem_Linguae mentioned this in rMSPN54f3fb3e3457: remove deprecated yaml key.Thu, Jun 20, 2:57 PM

Maintenance_bot removed a project: Patch-For-Review.Thu, Jun 20, 3:31 PM