Maniphest T365080

Update skin-theme-exclusion-notice to use the existing labels
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	sgrabarczuk
	May 15 2024, 10:30 PM

Tags

Referenced Files

	F53970561: screenshot 359.png
	May 20 2024, 4:45 PM

Subscribers

Description

What is now?:

MediaWiki:Skin-theme-exclusion-notice/en is now "This page is always in day mode."

This is inconsistent with the currently used labels (night->dark T361157, and also mode->color).

What should be instead instead?:

"This page is always in light mode." or even "This page always uses light color." or similar

Requirement

Update the skin-theme-exclusion-notice to use the text: "This page is always in light mode."

BDD

Feature: Update skin-theme-exclusion-notice Labels

  Scenario: Update skin-theme-exclusion-notice for consistency
    Given the user is viewing a page with the skin-theme-exclusion-notice
    When the skin-theme-exclusion-notice is displayed
    Then the notice should read "This page is always in light mode."

Test Steps

Test Case 1: Verify skin-theme-exclusion-notice Text

Open the Wikipedia page with the skin-theme-exclusion-notice.
Locate the skin-theme-exclusion-notice.
AC1: Confirm that the notice reads "This page is always in light mode."

QA Results - Beta

AC	Status	Details
1	✅	T365080#9813311

Related Objects

Mentioned Here: T361157: Change "Night" to "Dark" in Appearance settings

Event Timeline

sgrabarczuk created this task.May 15 2024, 10:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2024, 10:30 PM

sgrabarczuk added a project: Web-Team-Backlog-Archived.May 15 2024, 10:30 PM

ovasileva triaged this task as High priority.May 16 2024, 9:36 AM

ovasileva edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4); removed Web-Team-Backlog-Archived.

ovasileva edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 3); removed Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4).

ovasileva merged a task: T365110: [Bug] Exception message references "day" mode.

ovasileva subscribed.

Sorry only just saw this. I merged a patch that rephrased this: https://gerrit.wikimedia.org/r/1032423 but we may want to wordsmith it further.

Current text is "This page is always in light mode."

ovasileva set the point value for this task to 1.May 16 2024, 5:25 PM

Jdlrobson assigned this task to Edtadros.May 16 2024, 5:37 PM

Jdlrobson moved this task from Backlog to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 3) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify skin-theme-exclusion-notice Text

Open the Wikipedia page with the skin-theme-exclusion-notice.
Locate the skin-theme-exclusion-notice.
✅ AC1: Confirm that the notice reads "This page is always in light mode."

screenshot 359.png (985×1 px, 479 KB)

Edtadros updated the task description. (Show Details)May 20 2024, 4:46 PM

ovasileva closed this task as Resolved.May 21 2024, 3:55 PM

ovasileva claimed this task.