Page MenuHomePhabricator

500 error on Special:AllEvents when applying filters without a start date
Closed, ResolvedPublicBUG REPORT

Description

Given I am on Special:AllEvents
And I delete the From date
And click apply filters
I will receive this error:

[ZkY1vfJHfVA4CapOYUJE6wAAAAI] /wiki/Special:AllEvents?limit=50&wpEndDate=2024-05-23&wpMeetingType=&wpSearch=&wpStartDate= Error: Typed property MediaWiki\Extension\CampaignEvents\Pager\EventsListPager::$startOffset must not be accessed before initialization

Backtrace:

from /srv/mediawiki/php-master/extensions/CampaignEvents/src/Pager/EventsListPager.php(325)
#0 /srv/mediawiki/php-master/includes/pager/IndexPager.php(465): MediaWiki\Extension\CampaignEvents\Pager\EventsListPager->buildQueryInfo(string, integer, boolean)
#1 /srv/mediawiki/php-master/includes/pager/IndexPager.php(289): MediaWiki\Pager\IndexPager->reallyDoQuery(string, integer, boolean)
#2 /srv/mediawiki/php-master/includes/pager/IndexPager.php(846): MediaWiki\Pager\IndexPager->doQuery()
#3 /srv/mediawiki/php-master/extensions/CampaignEvents/src/Pager/EventsListPager.php(225): MediaWiki\Pager\IndexPager->isNavigationBarShown()
#4 /srv/mediawiki/php-master/extensions/CampaignEvents/src/Special/SpecialAllEvents.php(110): MediaWiki\Extension\CampaignEvents\Pager\EventsListPager->getNavigationBar()
#5 /srv/mediawiki/php-master/extensions/CampaignEvents/src/Special/SpecialAllEvents.php(40): MediaWiki\Extension\CampaignEvents\Special\SpecialAllEvents->showFormAndEvents()
#6 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(719): MediaWiki\Extension\CampaignEvents\Special\SpecialAllEvents->execute(NULL)
#7 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(1680): MediaWiki\SpecialPage\SpecialPage->run(NULL)
#8 /srv/mediawiki/php-master/includes/actions/ActionEntryPoint.php(502): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#9 /srv/mediawiki/php-master/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#10 /srv/mediawiki/php-master/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#11 /srv/mediawiki/php-master/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

Screen Recording 2024-05-16 at 11.35.02 AM.gif (1×3 px, 871 KB)

Acceptance Criteria:
There should not be a 500 error when applying filters when there is no start date

Event Timeline

Change #1032584 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] EventsListPager: fix crash when no start date specified, add end date check

https://gerrit.wikimedia.org/r/1032584

Change #1032584 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] EventsListPager: fix crash when no start date specified, add end date check

https://gerrit.wikimedia.org/r/1032584

Acceptance Criteria:
✅ There should not be a 500 error when applying filters when there is no start date

Screen Recording 2024-05-17 at 12.16.10 PM.gif (1×2 px, 581 KB)

This is working as expected now, marking as done / resolved.