| vaughnwalters | |
| Tue, Apr 30, 8:05 PM |
| F49333406: Screen Recording 2024-04-29 at 3.48.03 PM.gif | |
| Tue, Apr 30, 8:05 PM | |
| File Not Attached |
If an event starts Jan 1 2024 and goes through Dec 31 2024, but we set our filter to start at today's date (April 30, 2024) that event will currently not show up even though it is an active event.
| gif of current behavior | |
 | |
Acceptance criteria:
Instead of displaying events that start on the date of the filter, the filter should show events that are active on the date of the "From" filter. This way, users will not miss out on longer events that span multiple weeks/months.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Change sql query to show ongoing events on Special:AllEvents | mediawiki/extensions/CampaignEvents | master | +68 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T355666 [EPIC] Event List | |||
| In Progress | MHorsey-WMF | T353382 Create a basic list of all events with Event Registration | |||
| In Progress | MHorsey-WMF | T363865 Update start date filtering options on Special:AllEvents |
Discussed today. Decisions: we will do this now, before widely sharing the event list page. We will consider adding an inline notice to ongoing events in the UI, and possibly a way for users to filter them out. That will be done in another task and is not considered a blocker. However, we still want to do it ASAP.
Change #1029156 had a related patch set uploaded (by Mhorsey; author: Mhorsey):
[mediawiki/extensions/CampaignEvents@master] Change sql query to show ongoing events on Special:AllEvents
Change #1029156 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Change sql query to show ongoing events on Special:AllEvents
@vaughnwalters Just a quick note from working on T365181: I would recommend testing pagination thoroughly (number of pages, first/prev/next/last page, no duplicated or skipped results, ...). I've done some testing for that patch, but there's a decent change I may have missed something because the whole thing is quite tricky.
If I search from May 17 2024 , then dates that start after that date display in the list. For example, test events starting in 2099 April 12 will display in the list and they should be filtered out.
Also, a couple of follow up tickets related to findings on this ticket
T365181: 500 error on Special:AllEvents when applying filters without a start date
T365271: Special:AllEvents user should not be able to select a To date that is before the From date
That's because having May 17th as start date (and no end date) is interpreted as "give me every event that is open on any day from May 17th to eternity". In particular, any event whose start date is May 17 or later fulfills this criterion and will be in the list. Which gives me just another opportunity to state that our current implementation with two date fields for selecting a range has a huge potential of being confusing.
Hmmm i see. Does this AC need changed then the filter should show events that are active on the date of the "From" filter? It seems to me that If I have a from date X then it should display all dates from before that date that also go through and include that date, but not all dates that start after that date. But yes agree that even if this is the expected behavior, this is definitely confusing.
Thinking about this more - I see what you mean and see how this is working as expected. It is def confusing to me though.
Yeah. And similarly when you have an end date but no start date. When I was fixing T365181 I spent some time trying to figure out where the bug was, just to eventually realize that there was no bug and it was the expected behaviour.