Page MenuHomePhabricator
Create Task
Maniphest T365548

WikiLambda metrics: add "change" events for function editing
Closed, ResolvedPublic
Actions

Description

Description

Change events are generated when editing implementations or testers, using the default view (from the work on T350497), but they are still needed for editing of functions. (The existing change events are generated when setDirty is called, but turns out that's not called during function editing.)

Desired behavior/Acceptance criteria

  • A change event should be generated for the first change that's made during editing of a function.

Completion checklist

Details

SubjectRepoBranchLines +/-
AboutEditMetadataDialog: always generate "change" event when saving changesmediawiki/extensions/WikiLambdamaster+1 -1
WikiLambda metrics: add "change" events for function editingmediawiki/extensions/WikiLambdamaster+19 -3
Customize query in gerrit

Related Objects

Event Timeline

DMartin-WMF created this task.May 22 2024, 4:44 AM
Jdforrester-WMF triaged this task as Medium priority.May 22 2024, 4:38 PM
Jdforrester-WMF moved this task from To triage to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (24Q4 (Apr–Jun)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready, Bugs on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.May 22 2024, 4:40 PM
gerritbot added a comment.May 28 2024, 1:53 AM

Change #1036331 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] WikiLambda metrics: add "change" events for function editing

https://gerrit.wikimedia.org/r/1036331

gerritbot added a project: Patch-For-Review.May 28 2024, 1:53 AM
DMartin-WMF claimed this task.May 28 2024, 8:04 PM
DMartin-WMF added a project: Abstract Wikipedia Fix-It tasks.
MNeisler mentioned this in T358873: QA Wikilambda instrumentation port to new core interactions metrics platform version.May 29 2024, 2:47 AM
gerritbot added a comment.May 29 2024, 6:35 AM

Change #1036331 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] WikiLambda metrics: add "change" events for function editing

https://gerrit.wikimedia.org/r/1036331

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).May 29 2024, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 29 2024, 7:30 AM
gerritbot added a comment.May 30 2024, 5:28 AM

Change #1037214 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] AboutEditMetadataDialog: always generate "change" event when saving changes

https://gerrit.wikimedia.org/r/1037214

gerritbot added a project: Patch-For-Review.May 30 2024, 5:28 AM
gerritbot added a comment.May 30 2024, 1:50 PM

Change #1037214 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] AboutEditMetadataDialog: always generate "change" event when saving changes

https://gerrit.wikimedia.org/r/1037214

Maintenance_bot removed a project: Patch-For-Review.May 30 2024, 2:32 PM
DMartin-WMF moved this task from Ready, Bugs to Ready to deploy on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.May 31 2024, 5:11 AM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Thu, Jun 6, 3:09 PM
Jdforrester-WMF closed this task as Resolved.Thu, Jun 13, 6:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits