Drop flaggedpage_pending from production
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ladsgroup
	May 22 2024, 9:17 AM

Description

With this patch merged, we can drop flaggedpage_pending from wikis that have flaggedrevs installed (https://noc.wikimedia.org/conf/highlight.php?file=dblists/flaggedrevs.dblist). This table is tiny but gets a lot of writes.

Do not drop it yet, until the patch get deployed and stable: Week of 3rd of June.

Progress

Details

	Subject	Repo	Branch	Lines +/-
	table_jobs.yaml: Remove flaggedpage_pending and flaggedtemplates	operations/puppet	production	+0 -8
	filtered_tables.txt: Remove flaggedpage_pending flaggedtemplates	operations/puppet	production	+0 -6

Customize query in gerrit

Related Objects

Mentioned In: T368050: [wikireplicas] Automated tests for views

Event Timeline

Ladsgroup created this task.May 22 2024, 9:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 22 2024, 9:17 AM

I've sent a calendar invite to revisit this the 3rd of June

ABran-WMF subscribed.May 22 2024, 12:00 PM

@Ladsgroup is this good to go?

I haven't seen any complaints or bug reports regarding this change. It's good to go.

It hasn't been written into in dewiki for a couple of days now:

root@db1183:/srv/sqldata# ls -l */flaggedpage_pending.ibd
-rw-rw---- 1 mysql mysql 6291456 May 30 20:17 dewiki/flaggedpage_pending.ibd

Let's give it two more days just in case.

Marostegui claimed this task.Jun 4 2024, 6:13 AM

Mentioned in SAL (#wikimedia-operations) [2024-06-04T06:14:48Z] <marostegui> Rename table flaggedpage_pending on db1185 (s5 eqiad dbmaint) - T365568

Done this for now:

cumin2024@db1185.eqiad.wmnet[dewiki]> rename table flaggedpage_pending to T365568_flaggedpage_pending;
Query OK, 0 rows affected (0.003 sec)

cumin2024@db1185.eqiad.wmnet[dewiki]>

KCVelaga_WMF subscribed.Jun 5 2024, 4:06 PM

In T365568#9857942, @Marostegui wrote:

Done this for now:

cumin2024@db1185.eqiad.wmnet[dewiki]> rename table flaggedpage_pending to T365568_flaggedpage_pending;
Query OK, 0 rows affected (0.003 sec)

cumin2024@db1185.eqiad.wmnet[dewiki]>

So far so good. So I will start dropping it on Monday.

Mentioned in SAL (#wikimedia-operations) [2024-06-10T04:44:30Z] <marostegui> Rename flaggedpage_pending in s5 T365568

I have renamed the table entirely on s5 dewiki

Mentioned in SAL (#wikimedia-operations) [2024-06-10T15:40:51Z] <marostegui> Drop flaggedpage_pending from s6 T365568

Marostegui updated the task description. (Show Details)Mon, Jun 10, 3:41 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-10T15:41:40Z] <marostegui> Drop flaggedpage_pending from s7 T365568

Marostegui updated the task description. (Show Details)Mon, Jun 10, 3:42 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-10T15:43:35Z] <marostegui> Drop flaggedpage_pending from s2 T365568

Marostegui updated the task description. (Show Details)Mon, Jun 10, 3:45 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-10T15:46:24Z] <marostegui> Drop flaggedpage_pending from s5 T365568

Mentioned in SAL (#wikimedia-operations) [2024-06-10T15:47:11Z] <marostegui> Drop flaggedpage_pending from s3 T365568

Dropping in s3 with sleep in between the drops. It will take around 25 minutes.

Marostegui updated the task description. (Show Details)Mon, Jun 10, 3:47 PM

Marostegui updated the task description. (Show Details)Mon, Jun 10, 4:19 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-10T16:20:48Z] <marostegui> Drop flaggedpage_pending from s1 T365568

This is done

Maintenance_bot moved this task from In progress to Done on the DBA board.Mon, Jun 10, 4:29 PM

Marostegui mentioned this in T368050: [wikireplicas] Automated tests for views.Tue, Jul 2, 5:45 AM

Change #1051244 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/puppet@production] filtered_tables.txt: Remove flaggedpage_pending flaggedtemplates

https://gerrit.wikimedia.org/r/1051244

Change #1051244 merged by Marostegui:

[operations/puppet@production] filtered_tables.txt: Remove flaggedpage_pending flaggedtemplates

https://gerrit.wikimedia.org/r/1051244

Change #1051245 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/puppet@production] table_jobs.yaml: Remove flaggedpage_pending and flaggedtemplates

https://gerrit.wikimedia.org/r/1051245

Change #1051245 merged by Marostegui: