Address FIXMEs in Phabricator-translations
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Pppery
	May 24 2024, 5:44 PM

Description

projects/arcanist/core/qqq.json:        "3119f17b3b50c21d": "'''FIXME''': see [[Thread:Support/About Phabricator:arcanist-core-3119f17b3b50c21d/en]]\n\nOrdinal suffix (used after ''n''02, ''n''22, ''n''32, ..., ''n''92, but not after ''n''12, using rules only valid in English).\n\nRelated messages, used in [https://github.com/phacility/arcanist/blob/master/src/internationalization/__tests__/PhutilPhtTestCase.php PhutilPhtTestCase.php]:\n* line 57: {{msg-phab|arcanist-core-9b02d9974c14e623}}\n* line 58: {{msg-phab|arcanist-core-3119f17b3b50c21d}}\n* line 59: {{msg-phab|arcanist-core-9f6194d012e32351}}\n* line 60: {{msg-phab|arcanist-core-fa6af6e97d010a98}}\n\nUsed in:\n\n[https://phabricator.wikimedia.org/source/arcanist/browse/wmf%252Fstable/src//internationalization/__tests__/PhutilPhtTestCase.php$58 PhutilPhtTestCase.php:58]",
projects/arcanist/core/qqq.json:        "9b02d9974c14e623": "'''FIXME''': see [[Thread:Support/About Phabricator:arcanist-core-3119f17b3b50c21d/en]]\n\nOrdinal suffix (used after ''n''01, ''n''21, ''n''31, ..., ''n''91, but not after ''n''11, using rules only valid in English).\n\nRelated messages, used in [https://github.com/phacility/arcanist/blob/master/src/internationalization/__tests__/PhutilPhtTestCase.php PhutilPhtTestCase.php]:\n* line 57: {{msg-phab|arcanist-core-9b02d9974c14e623}}\n* line 58: {{msg-phab|arcanist-core-3119f17b3b50c21d}}\n* line 59: {{msg-phab|arcanist-core-9f6194d012e32351}}\n* line 60: {{msg-phab|arcanist-core-fa6af6e97d010a98}}\n\nUsed in:\n\n[https://phabricator.wikimedia.org/source/arcanist/browse/wmf%252Fstable/src//internationalization/__tests__/PhutilPhtTestCase.php$57 PhutilPhtTestCase.php:57]",
projects/arcanist/core/qqq.json:        "9f6194d012e32351": "'''FIXME''': see [[Thread:Support/About Phabricator:arcanist-core-3119f17b3b50c21d/en]]\n\nOrdinal suffix (used after ''n''03, ''n''23, ''n''33, ..., ''n''93, but not after ''n''13, using rules only valid in English).\n\nRelated messages, used in [https://github.com/phacility/arcanist/blob/master/src/internationalization/__tests__/PhutilPhtTestCase.php PhutilPhtTestCase.php]:\n* line 57: {{msg-phab|arcanist-core-9b02d9974c14e623}}\n* line 58: {{msg-phab|arcanist-core-3119f17b3b50c21d}}\n* line 59: {{msg-phab|arcanist-core-9f6194d012e32351}}\n* line 60: {{msg-phab|arcanist-core-fa6af6e97d010a98}}\n\nUsed in:\n\n[https://phabricator.wikimedia.org/source/arcanist/browse/wmf%252Fstable/src//internationalization/__tests__/PhutilPhtTestCase.php$59 PhutilPhtTestCase.php:59]",
projects/arcanist/core/qqq.json:        "fa6af6e97d010a98": "'''FIXME''': see [[Thread:Support/About Phabricator:arcanist-core-3119f17b3b50c21d/en]]\n\nOrdinal suffix (used after ''n''00, ''n''04 to ''n''20, ''n''24 to ''n''30, ''n''34 to ''n''40, ..., ''n''94 to ''n''99, but not after ''n''01 to ''n''03, ''n''21 to ''n''23, ''n''31 to ''n''33, ..., ''n''91 to ''n''93, using rules only valid in English).\n\nRelated messages, used in [https://github.com/phacility/arcanist/blob/master/src/internationalization/__tests__/PhutilTestCase.php PhutilPhtTestCase.php]:\n* line 57: {{msg-phab|arcanist-core-9b02d9974c14e623}}\n* line 58: {{msg-phab|arcanist-core-3119f17b3b50c21d}}\n* line 59: {{msg-phab|arcanist-core-9f6194d012e32351}}\n* line 60: {{msg-phab|arcanist-core-fa6af6e97d010a98}}\n\nUsed in:\n\n[https://phabricator.wikimedia.org/source/arcanist/browse/wmf%252Fstable/src//internationalization/__tests__/PhutilPhtTestCase.php$60 PhutilPhtTestCase.php:60]",

Some of this is already covered by T363364 and declined T312047 but either the FIXMEs should be deleted if they're deemed not an issue or they should be resolved.

Details

	Subject	Repo	Branch	Lines +/-
	Update source strings for 2024.19	phabricator/translations	wmf/stable	+11 K -14 K
	Remove FIXME comment for waxing and waning moon phases	phabricator/translations	wmf/stable	+6 -6

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T365853 Address FIXMEs in Phabricator-translations
		Resolved		brennen	T368453 Update to Phorge upstream 2024.19 release

Event Timeline

Pppery created this task.May 24 2024, 5:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2024, 5:44 PM

I've also prowled the archives of translatewiki.net for a bunch of old issues and reported them as https://we.phorge.it/T15841, https://we.phorge.it/T15840, https://we.phorge.it/T15839

Change #1037026 had a related patch set uploaded (by Aklapper; author: Aklapper):

[phabricator/translations@wmf/stable] Remove FIXME comment for waxing and waning moon phases

https://gerrit.wikimedia.org/r/1037026

gerritbot added a project: Patch-For-Review.May 29 2024, 8:58 AM

Change #1037026 abandoned by Aklapper:

[phabricator/translations@wmf/stable] Remove FIXME comment for waxing and waning moon phases

Reason:

Thanks!

https://gerrit.wikimedia.org/r/1037026

Maintenance_bot removed a project: Patch-For-Review.May 31 2024, 10:30 PM

Pppery updated the task description. (Show Details)Jun 4 2024, 5:27 PM

This will fix itself once we pull https://we.phorge.it/rARCf7fcf31c7e23475e345cb3cd4abf0474ba6fd9cf from upstream merged on 2024-06-07 which removes the remaining strings which have a FIXME

Aklapper moved this task from Backlog to Solved upstream on the Phabricator (Upstream) board.Jun 16 2024, 10:02 AM

Aklapper moved this task from Backlog to Patch merged upstream on the Upstream board.

Or https://we.phorge.it/rP29cbb0a6580fa2a94e8fae13fd4edef78efdeab0 which is older

Aklapper added a subtask: T368453: Update to Phorge upstream 2024.19 release.Jun 25 2024, 7:51 PM