Upstream HOME=/tmp from fresh-node to WMF CI images
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	May 24 2024, 7:03 PM

Description

I suggest upstreaming this to reduce differences and so as to avoid things breaking in CI when there's an easy fix that we already apply in various places including:

We currently set -e 'HOME=/tmp' in fresh-node18, node20, node22, etc.
We set HOME=/tmp in the firefox wrapper in node-test-browser images for WMF CI.
We set (as of today) HOME=/tmp in Quibble images to fix firefox-esr for QUnit tests (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/947898).

Details

Subject	Repo	Branch	Lines +/-
jjb: switch Quibble jobs to use HOME=/tmp (2)	integration/config	master	+45 -45
jjb: switch Quibble jobs to use HOME=/tmp	integration/config	master	+24 -24
fresh-node: Update to latest image and remove redundant HOME override	fresh	master	+15 -16
dockerfiles: [quibble] Set HOME=/tmp so Firefox etc. can work	integration/config	master	+115 -0
dockerfiles: set HOME=/tmp in node18-test,node20-test,node22-test	integration/config	master	+88 -39

Customize query in gerrit

Related Objects

Mentioned In: T370427: [QB] Build fails on EACCESS issues
P63119 (An Untitled Masterwork)
Mentioned Here: rCICF6c3c6fc864ab: docker: fix firefox in quibble-stretch-bundle
T203178: Migrate Selenium tests based on the ruby library mediawiki_selenium

Event Timeline

Krinkle created this task.May 24 2024, 7:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2024, 7:03 PM

Change #1035812 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/config@master] dockerfiles: set HOME=/tmp in node18-test,node20-test,node22-test

https://gerrit.wikimedia.org/r/1035812

gerritbot added a project: Patch-For-Review.May 24 2024, 7:07 PM

Change #1035810 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] dockerfiles: [quibble] Set HOME=/tmp so Firefox etc. can work

https://gerrit.wikimedia.org/r/1035810

Krinkle claimed this task.May 24 2024, 7:21 PM

Krinkle triaged this task as Low priority.

Krinkle moved this task from Inbox to Enhancement on the Fresh board.

Krinkle mentioned this in P63119 (An Untitled Masterwork).May 24 2024, 7:43 PM

Change #1035812 merged by jenkins-bot:

[integration/config@master] dockerfiles: set HOME=/tmp in node18-test,node20-test,node22-test

https://gerrit.wikimedia.org/r/1035812

Change #1035826 had a related patch set uploaded (by Krinkle; author: Krinkle):

[fresh@master] fresh-node: Update to latest image and remove redundant HOME override

https://gerrit.wikimedia.org/r/1035826

See 6c3c6fc864ab1b2fed3bafe7aa983009e6544367 which I did when upgrading from Jessie (T203178). It introduces a firefox shell script wrapper in /usr/local/bin/firefox and set HOME there. That has the advantage of not setting HOME which does have side effects.