Page MenuHomePhabricator
Create Task
Maniphest T366181

🚫 [Generalised error] invalid-value in request body
Closed, ResolvedPublic13 Estimated Story Points
Actions

Description

Acceptance criteria:

  • Current errors it will replace:
    • invalid-title-field
    • invalid-sitelink-badges-format
    • invalid-input-sitelink-badge
    • invalid-patch
    • invalid-patch-field-type
    • invalid-label
    • invalid-description
    • invalid-alias
    • invalid-statement-group-type
    • invalid-statement-type
    • invalid-edit-tag
    • item-data-invalid-field
    • statement-data-invalid-field
    • invalid-patch-operation
    • title-field-empty
    • label-empty
    • description-empty
    • alias-list-empty
    • alias-empty
    • item-not-a-badge
    • invalid-sitelink-type
    • invalid-alias-list
  • New error case it should also cover: Incorrect sitelink type
  • HTTP status code: 400
  • Error code: invalid-value
  • Error message: Invalid value at '{json-pointer}'
  • Context: "path": "{json-pointer}"

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedIfrahkhanyaree_WMDET366181 🚫 [Generalised error] invalid-value in request body
 ResolvedJakob_WMDET369028 🚫 Replace `invalid-edit-tag` errors with generic `invalid-value` error
 Resolved• Muhammad_Yasser_Jazirahly_WMDET369029 🚫 Replace `invalid-title-field` errors with generic `invalid-value` error
 Resolved• Muhammad_Yasser_Jazirahly_WMDET369030 🚫 Replace `invalid-sitelink-badges-format` errors with generic `invalid-value` error
 ResolvedJakob_WMDET369031 🚫 Replace `invalid-patch` errors with generic `invalid-value` error
 Resolved• Muhammad_Yasser_Jazirahly_WMDET369032 🚫 Replace `invalid-patch-field-type` errors with generic `invalid-value` error
 ResolvedDima_Koushha_WMDET369034 🚫 Replace `invalid-label` errors with generic `invalid-value` error
 ResolvedDima_Koushha_WMDET369035 🚫 Replace `invalid-description` errors with generic `invalid-value` error
 ResolvedJakob_WMDET369036 🚫 Replace `invalid-alias` errors with generic `invalid-value` error
 Resolved• Muhammad_Yasser_Jazirahly_WMDET369037 🚫 Replace `invalid-statement-group-type` errors with generic `invalid-value` error
 Resolved• Muhammad_Yasser_Jazirahly_WMDET369038 🚫 Replace `invalid-statement-type` errors with generic `invalid-value` error
 ResolvedDima_Koushha_WMDET369039 🚫 Replace `item-data-invalid-field` errors with generic `invalid-value` error
 ResolvedSilvan_WMDET369040 🚫 Replace `statement-data-invalid-field` errors with generic `invalid-value` error
 InvalidJakob_WMDET369051 🚫 Replace `invalid-language-code` errors with generic `invalid-value` error
 Resolved• Muhammad_Yasser_Jazirahly_WMDET369062 🚫 Replace `invalid-patch-operation` errors with generic `invalid-value` error
 Resolved• Muhammad_Yasser_Jazirahly_WMDET369063 🚫 Replace `invalid-site-id` errors with generic `invalid-value` error
 Resolved• Muhammad_Yasser_Jazirahly_WMDET369066 🚫 Replace `title-field-empty` errors with generic `invalid-value` error
 ResolvedJakob_WMDET369067 🚫 Replace `label-empty` errors with generic `invalid-value` error
 ResolvedDima_Koushha_WMDET369068 🚫 Replace `description-empty` errors with generic `invalid-value` error
 ResolvedSilvan_WMDET369070 🚫 Replace `alias-list-empty` errors with generic `invalid-value` error
 ResolvedSilvan_WMDET369071 🚫 Replace `alias-empty` errors with generic `invalid-value` error
 ResolvedDima_Koushha_WMDET369074 🚫 Replace `invalid-input-sitelink-badge` errors with generic `invalid-value` error
 ResolvedOllie.Shotton_WMDET371494 🚫 Replace `item-not-a-badge` errors with generic `invalid-value` error
 ResolvedOllie.Shotton_WMDET372136 🚫 Replace `invalid-sitelink-type` errors with generic `invalid-value` error
 ResolvedJakob_WMDET372138 🚫 Replace `invalid-alias-list` errors with generic `invalid-value` error

Event Timeline

Ifrahkhanyaree_WMDE created this task.May 29 2024, 2:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2024, 2:03 PM
Ifrahkhanyaree_WMDE updated the task description. (Show Details)May 30 2024, 7:59 AM
Ifrahkhanyaree_WMDE updated the task description. (Show Details)
Ifrahkhanyaree_WMDE updated the task description. (Show Details)Jun 5 2024, 11:25 AM
Ifrahkhanyaree_WMDE moved this task from Backlog to Polished on the Wikibase Product Platform Team WPP board.
WMDE-leszek updated the task description. (Show Details)Jun 6 2024, 10:54 AM
WMDE-leszek updated the task description. (Show Details)Jun 6 2024, 10:56 AM
Ollie.Shotton_WMDE updated the task description. (Show Details)Jun 6 2024, 11:01 AM
Ifrahkhanyaree_WMDE updated the task description. (Show Details)Jun 11 2024, 10:23 AM
Ifrahkhanyaree_WMDE set the point value for this task to 13.Jun 11 2024, 10:28 AM
Ifrahkhanyaree_WMDE moved this task from Polished to Ready for planning on the Wikibase Product Platform Team WPP board.Jun 25 2024, 9:45 AM
Ollie.Shotton_WMDE mentioned this in T368398: [MAIN] REST API v1 CHECKLIST.Jun 26 2024, 5:13 PM
Ollie.Shotton_WMDE moved this task from Ready for planning to Sprint 23 on the Wikibase Product Platform Team WPP board.Jul 2 2024, 12:16 PM
Ollie.Shotton_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 23); removed Wikibase Product Platform Team WPP.
Ollie.Shotton_WMDE renamed this task from [Generalised error] Invalid-value to 🚫 [Generalised error] Invalid-value.Jul 2 2024, 12:18 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)
Ollie.Shotton_WMDE updated the task description. (Show Details)Jul 2 2024, 12:36 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)Jul 2 2024, 12:42 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)
Ollie.Shotton_WMDE renamed this task from 🚫 [Generalised error] Invalid-value to 🚫 [Generalised error] invalid-value.Jul 2 2024, 2:51 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)
Ollie.Shotton_WMDE updated the task description. (Show Details)Jul 2 2024, 3:14 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)Jul 2 2024, 3:30 PM
Jakob_WMDE closed subtask T369051: 🚫 Replace `invalid-language-code` errors with generic `invalid-value` error as Invalid.Jul 8 2024, 1:46 PM
Jakob_WMDE mentioned this in T369511: 🔑 [Generalized error] invalid-key in request body.Jul 8 2024, 1:49 PM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Sprint 23 to Sprint 24 on the Wikibase Product Platform Team WPP board.Jul 9 2024, 9:50 AM
• Muhammad_Yasser_Jazirahly_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 24); removed Wikibase Product Platform Team WPP (Sprint 23).
Ollie.Shotton_WMDE closed subtask T369074: 🚫 Replace `invalid-input-sitelink-badge` errors with generic `invalid-value` error as Resolved.Jul 9 2024, 9:53 AM
Ollie.Shotton_WMDE closed subtask T369071: 🚫 Replace `alias-empty` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369070: 🚫 Replace `alias-list-empty` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369068: 🚫 Replace `description-empty` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369067: 🚫 Replace `label-empty` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369066: 🚫 Replace `title-field-empty` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369063: 🚫 Replace `invalid-site-id` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369062: 🚫 Replace `invalid-patch-operation` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369040: 🚫 Replace `statement-data-invalid-field` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369037: 🚫 Replace `invalid-statement-group-type` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369038: 🚫 Replace `invalid-statement-type` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369036: 🚫 Replace `invalid-alias` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369032: 🚫 Replace `invalid-patch-field-type` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369029: 🚫 Replace `invalid-title-field` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE closed subtask T369028: 🚫 Replace `invalid-edit-tag` errors with generic `invalid-value` error as Resolved.
• Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Done on the Wikibase Product Platform Team WPP (Sprint 24) board.Jul 10 2024, 8:45 AM
Ollie.Shotton_WMDE moved this task from Done to Doing on the Wikibase Product Platform Team WPP (Sprint 24) board.Jul 15 2024, 2:41 PM
Ollie.Shotton_WMDE added subscribers: • Muhammad_Yasser_Jazirahly_WMDE, Ollie.Shotton_WMDE.

@Muhammad_Yasser_Jazirahly_WMDE found an issue, moving back to doing.

Ollie.Shotton_WMDE moved this task from Backlog to Happening now on the Wikibase REST API (WPP) board.Jul 15 2024, 2:42 PM
Ollie.Shotton_WMDE claimed this task.Jul 15 2024, 2:59 PM
Ollie.Shotton_WMDE removed Ollie.Shotton_WMDE as the assignee of this task.Jul 17 2024, 9:02 AM
Ifrahkhanyaree_WMDE added a parent task: T368398: [MAIN] REST API v1 CHECKLIST.Jul 17 2024, 9:56 AM
Ifrahkhanyaree_WMDE removed a parent task: T368398: [MAIN] REST API v1 CHECKLIST.Jul 18 2024, 9:53 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 25); removed Wikibase Product Platform Team WPP (Sprint 24).Jul 23 2024, 9:57 AM
Ifrahkhanyaree_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 25) board.
Ifrahkhanyaree_WMDE closed subtask T369039: 🚫 Replace `item-data-invalid-field` errors with generic `invalid-value` error as Resolved.Jul 23 2024, 9:58 AM
Ifrahkhanyaree_WMDE closed subtask T369035: 🚫 Replace `invalid-description` errors with generic `invalid-value` error as Resolved.
Ifrahkhanyaree_WMDE closed subtask T369034: 🚫 Replace `invalid-label` errors with generic `invalid-value` error as Resolved.
Ifrahkhanyaree_WMDE closed subtask T369031: 🚫 Replace `invalid-patch` errors with generic `invalid-value` error as Resolved.
Ifrahkhanyaree_WMDE closed subtask T369030: 🚫 Replace `invalid-sitelink-badges-format` errors with generic `invalid-value` error as Resolved.
Ollie.Shotton_WMDE renamed this task from 🚫 [Generalised error] invalid-value to 🚫 [Generalised error] invalid-value in request body.Jul 24 2024, 10:23 AM
Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 25) board.Jul 25 2024, 9:01 AM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 25) board.Jul 28 2024, 4:42 AM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Done to Product Verification on the Wikibase Product Platform Team WPP (Sprint 25) board.
Ifrahkhanyaree_WMDE added a comment.EditedJul 29 2024, 2:20 PM

we should remove invalid-language-code and invalid-site-id from the description right?

• Muhammad_Yasser_Jazirahly_WMDE added a comment.Jul 29 2024, 2:28 PM

Yes, good catch. They both moved to https://phabricator.wikimedia.org/T369511

Ifrahkhanyaree_WMDE moved this task from Product Verification to Done on the Wikibase Product Platform Team WPP (Sprint 25) board.Jul 29 2024, 2:41 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)Jul 29 2024, 3:10 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)Jul 31 2024, 12:42 PM
Ollie.Shotton_WMDE moved this task from Done to To Do on the Wikibase Product Platform Team WPP (Sprint 25) board.

We missed the item-not-a-badge case 🙈

Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 26); removed Wikibase Product Platform Team WPP (Sprint 25).Aug 6 2024, 10:20 AM
Silvan_WMDE moved this task from To Do to Product Verification on the Wikibase Product Platform Team WPP (Sprint 26) board.Aug 7 2024, 9:09 AM
Ollie.Shotton_WMDE moved this task from Product Verification to To Do on the Wikibase Product Platform Team WPP (Sprint 26) board.Aug 9 2024, 9:47 AM
Ollie.Shotton_WMDE updated the task description. (Show Details)Aug 9 2024, 11:26 AM
Jakob_WMDE moved this task from To Do to Product Verification on the Wikibase Product Platform Team WPP (Sprint 26) board.Aug 14 2024, 9:02 AM
Ifrahkhanyaree_WMDE added a comment.Aug 15 2024, 8:13 AM

Checked a bunch of them on 2-3 endpoints and they worked perfectly so I'd call this done

Ifrahkhanyaree_WMDE moved this task from Product Verification to Done on the Wikibase Product Platform Team WPP (Sprint 26) board.Aug 15 2024, 8:13 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Aug 20 2024, 10:01 AM
Ifrahkhanyaree_WMDE claimed this task.
Ifrahkhanyaree_WMDE closed subtask T372138: 🚫 Replace `invalid-alias-list` errors with generic `invalid-value` error as Resolved.
Ifrahkhanyaree_WMDE closed subtask T372136: 🚫 Replace `invalid-sitelink-type` errors with generic `invalid-value` error as Resolved.
Ifrahkhanyaree_WMDE closed subtask T371494: 🚫 Replace `item-not-a-badge` errors with generic `invalid-value` error as Resolved.
Ifrahkhanyaree_WMDE moved this task from Happening now to Done on the Wikibase REST API (WPP) board.Aug 22 2024, 11:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits