Maniphest T366335

Banners without backgrounds are not visible in dark mode
Closed, DeclinedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	Jdlrobson
	May 31 2024, 3:21 AM

Tags

Referenced Files

None

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Visit https://test.wikipedia.org/wiki/Great%20Molasses%20Flood?vectornightmode=1

What happens?:

Banner text "This is a test of release of MediaWiki 1.43.0-wmf.7 (b6ef248). Please report issues you encounter." is not readable

What should have happened instead?:

It should be readable.
Add rule #siteNotice.notheme { background: white; } to ensure all banners have a white background.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Related Objects

Mentioned In: T366378: [Config change] Enable night theme on preferences pages
T363780: [QA] Exploratory testing: Vector 2022 night theme
Mentioned Here: rMWb6ef248634f6: ResourceLoader: Update wikimedia/less.php from 4.2.1 to 4.4.1

Event Timeline

Jdlrobson created this task.May 31 2024, 3:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2024, 3:21 AM

Low priority as this can be easily fixed on wiki.

Jdlrobson mentioned this in T363780: [QA] Exploratory testing: Vector 2022 night theme.May 31 2024, 3:52 AM

Johannnes89 subscribed.May 31 2024, 7:27 AM

Jdlrobson moved this task from Backlog to Night mode (desktop) on the FY2023-24-WE 2.1 Typography and palette customizations board.May 31 2024, 4:48 PM

• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:39 AM

JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:44 AM

Jdlrobson added a subscriber: bwang.Jun 6 2024, 8:35 PM

Jdlrobson mentioned this in T366378: [Config change] Enable night theme on preferences pages.Jun 26 2024, 5:57 PM

Jdlrobson added projects: dark-mode, patch-welcome.Jun 28 2024, 2:55 AM

Jdlrobson moved this task from Backlog to Web (MediaWiki) on the dark-mode board.Jun 28 2024, 3:03 AM

Jdlrobson edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 2); removed Web-Team-Backlog, FY2023-24-WE 2.1 Typography and palette customizations.Jul 1 2024, 7:45 PM

I recommend these are fixed on wiki. It doesn't make sense to do a global fix that could break existing banners.

Here is how I fixed the example issue: https://test.wikipedia.org/w/index.php?title=MediaWiki:Sitenotice&diff=prev&oldid=602343