CommonsMetadata DataCollector::verifyAttributionMetadata should use ParserOutput::getRawText()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	May 31 2024, 10:10 PM

Project Tags

Referenced Files

None

Subscribers

Description

The DataCollector::verifyAttributionMetadata method should use ::getRawText(), not ::getText(), when examining parser output, since it is invoked before the parser output is stored in the case and ::getText() mutates the ParserOutput in place.

If it really needs the post-processing of ::getText(), it should invoke the OutputPipeline in a way which clones the ParserOutput.

See T365036: JSON serialization failures on media files and T365433: Cannot save VisualEditor content in File namespace.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Replace uses of deprecated ParserOutput::getText()	mediawiki/extensions/CommonsMetadata	master	+3 -2

Customize query in gerrit

Related Objects

Mentioned In: T365433: Cannot save VisualEditor content in File namespace
Mentioned Here: T365036: JSON serialization failures on media files
T365433: Cannot save VisualEditor content in File namespace

Event Timeline

cscott created this task.May 31 2024, 10:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2024, 10:10 PM

cscott mentioned this in T365433: Cannot save VisualEditor content in File namespace.May 31 2024, 10:10 PM

• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:39 AM

JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:44 AM

ihurbain awarded a token.Jun 3 2024, 7:33 AM

MSantos edited projects, added: Content-Transform-Team-WIP; removed: Parsoid.Jun 6 2024, 2:20 PM

MSantos added a project: Parsoid-Read-Views.Jun 10 2024, 3:03 PM

Restricted Application added a project: Parsoid. · View Herald TranscriptJun 10 2024, 3:03 PM

cscott claimed this task.Jun 10 2024, 3:10 PM

MSantos removed a project: Parsoid.Jun 20 2024, 2:26 PM

MSantos moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.

MSantos edited projects, added: Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed: Parsoid-Read-Views.

MSantos added a project: OKR-Work.Jul 29 2024, 2:49 PM

MSantos added a parent task: T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis.Aug 1 2024, 9:25 PM

Tgr renamed this task from CommonsMetadata DataCollector::verifyAttributeMetadata should use ParserOutput::getRawText() to CommonsMetadata DataCollector::verifyAttributionMetadata should use ParserOutput::getRawText().Aug 4 2024, 3:25 PM

Tgr updated the task description. (Show Details)

Just using getRawText() should be fine.

ihurbain removed a parent task: T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis.Oct 24 2024, 2:21 PM

Change #1091275 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/CommonsMetadata@master] Replace uses of deprecated ParserOutput::getText()

https://gerrit.wikimedia.org/r/1091275

gerritbot added a project: Patch-For-Review.Nov 14 2024, 4:13 PM

Change #1091275 merged by jenkins-bot: