Page MenuHomePhabricator

[M] Insert "custom license" field for own works in UploadWizard
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):
There should be a custom license field for the new "own work" option in UploadWizard, as it already exists for the "not own work" option.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
All the cases in which the uploader do not want to stick with CC BY-SA, CC BY or CC0 as a license for their media.

Benefits (why should this be implemented?):
Because Commons guidelines allow for other free licenses to be used, if the uploader wants.

Link to UI

Acceptance Criteria

  • Add a custom license option in own work - q2 where users choose a free license as shown in this UI
  • When the custom license option is selected reveal an input box as shown in this UI
    • Show the help text under the input box as shown in the UI
  • The functionality/behaviour of preview button and copyright tag link will be the same as the current custom license option in not-own work flow.
  • The current character limit and associated error message for custom license field in not-own work flow to be maintained here as well.
  • If the user has selected the custom license option and proceeds to next step without any input in the text box, show an error message under q2 with the copy "Input is required". (Note that in cases when no selection is made in q2, the error message is different - "Answer to this question is required" and should not be confused with the specific error message for this case.)

Event Timeline

Sannita updated the task description. (Show Details)
MarkTraceur renamed this task from Insert "custom license" field for own works in UploadWizard to [M] Insert "custom license" field for own works in UploadWizard.Sep 3 2024, 4:16 PM
mfossati changed the task status from Open to In Progress.Oct 16 2024, 4:03 PM
mfossati claimed this task.

Note that in cases when no selection is made in q2, the error message is different - "Answer to this question is required"

FYI it's currently Selection is required. both in q2 and q3.

Change #1091617 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):

[mediawiki/extensions/UploadWizard@master] Release rights: add custom license in own work

https://gerrit.wikimedia.org/r/1091617

Change #1097965 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Release rights: add custom license in own work

https://gerrit.wikimedia.org/r/1097965

Change #1091617 abandoned by Marco Fossati:

[mediawiki/extensions/UploadWizard@master] Release rights: add custom license in own work

Reason:

Abandoned in favor of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/1097965

https://gerrit.wikimedia.org/r/1091617

Change #1097965 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Release rights: add custom license in own work

https://gerrit.wikimedia.org/r/1097965

Etonkovidova subscribed.

To review
(1) "in wikitext format" - should it be present?

figma designcommons beta
Screen Shot 2024-11-28 at 10.59.24 AM.png (1×1 px, 218 KB)
Screen Shot 2024-11-28 at 11.08.42 AM.png (968×882 px, 154 KB)

(2) "in wikitext format" is not present in figma design - selected option, so there is not discepancy between figma design and the implementation
(3) The example of the template in figma ({{CC-by-2.0}}) is a link, but it's not a link in the implementation (also mentioned in this comment -T371050#10365113

@Etonkovidova
(1) and (2) "in wikitext format" was removed from new design because there is now a better explanation under the input field on what to enter
(3) Similar to what I shared on this ticket, we can leave out link and underline in this ticket too. Not sure if this can be improved for next week or we can also do it later before closing this ticket. @matthiasmullie

I just submitted & merged a little patch to remove the underline (both here and T371050)

I just submitted & merged a little patch to remove the underline (both here and T371050)

Checked in commons beta - the fix is in place:

Screen Shot 2024-12-02 at 11.44.42 AM.png (511×990 px, 79 KB)
Screen Shot 2024-12-02 at 11.46.23 AM.png (644×992 px, 113 KB)