Page MenuHomePhabricator

QuickSurveys do not work in dark mode
Closed, ResolvedPublic0 Estimated Story Points

Description

Background

QuickSurveys have a non-standard background color that clashes with dark mode (which can be activated by putting ?vectornightmode=1 at the end of any URL)

Screenshot 2024-06-04 at 10.35.16 AM.png (343×323 px, 20 KB)

User story

As someone who wants to run a quick survey, I need to be able to target users using dark mode.

Requirement

  • Surveys should be readable in dark mode.
  • The background show use the design token @background-color-neutral

BDD

Feature: Readable QuickSurveys in Dark Mode

  Scenario: Ensure QuickSurveys are readable in dark mode
    Given the QuickSurveys feature is enabled
    When the user views a survey in dark mode
    Then the survey should use the `@background-color-neutral` design token for the background color
    And the survey should be readable and accessible

Test Steps

Test Case 1: Verify QuickSurveys in Dark Mode

  1. Enable dark mode.
  2. Navigate to this beta test page.
  3. In the Developer console, run:
mw.loader.using( 'ext.quicksurveys.init' )
    .then( () => {
        mw.extQuickSurveys.showSurvey( 'AutoModerator Patroller Workstream Survey' );
    } );
  1. AC1: Confirm that the survey uses the @background-color-neutral design token for the background color.
  2. AC2: Confirm that the survey is readable and accessible in dark mode.

QA Results - Beta

ACStatusDetails
1T366626#9877404
2T366626#9877404

QA Results - Prod

ACStatusDetails
1No prod testing needed.
2No prod testing needed.

Design

  • Add mockups and design requirements

Communication criteria - does this need an announcement or discussion?

N/A

Rollback plan

N/A

This task was created by Version 1.0.0 of the Web team task template using phabulous

Event Timeline

Jdlrobson renamed this task from Web Task Creation Form to QuickSurveys do not work in dark mode.Jun 4 2024, 5:36 PM
Jdlrobson triaged this task as Medium priority.Jun 4 2024, 9:22 PM
Jdlrobson raised the priority of this task from Medium to Needs Triage.Jun 4 2024, 9:29 PM
Jdlrobson triaged this task as Medium priority.Jun 5 2024, 7:04 PM
Jdlrobson updated the task description. (Show Details)
Amdrel changed the task status from Open to In Progress.Jun 6 2024, 4:22 PM
Amdrel claimed this task.

Change #1039800 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/QuickSurveys@community-safety] Replace hardcoded background to fix dark mode

https://gerrit.wikimedia.org/r/1039800

Change #1039800 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@community-safety] Replace hardcoded background to fix dark mode

https://gerrit.wikimedia.org/r/1039800

Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 0.
Jdlrobson added a subscriber: Amdrel.

Change #1039836 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/QuickSurveys@master] Merge remote-tracking branch 'origin/community-safety'

https://gerrit.wikimedia.org/r/1039836

Change #1039836 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Merge remote-tracking branch 'origin/community-safety'

https://gerrit.wikimedia.org/r/1039836

Edtadros removed Edtadros as the assignee of this task.EditedMon, Jun 10, 8:34 PM
Edtadros added a project: Verified.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: cabetawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify QuickSurveys in Dark Mode

  1. Enable dark mode.
  2. Navigate to this beta test page.
  3. In the Developer console, run:
mw.loader.using('ext.quicksurveys.init').then(() => {
    mw.extQuickSurveys.showSurvey('AutoModerator Patroller Workstream Survey');
});
  1. AC1: Confirm that the survey uses the @background-color-neutral design token for the background color.

See below

  1. AC2: Confirm that the survey is readable and accessible in dark mode.

screenshot 710.png (983×1 px, 258 KB)

NOTE: This does not need to be tested in production.