[QA only] Talk button in sticky header is unnecessarily inverted
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Wed, Jun 5, 3:22 AM

Description

Steps to replicate the issue (include links if applicable):

Login
Visit https://en.wikipedia.org/wiki/Talk:Dani_Carvajal
Scroll down to reveal sticky header

What happens?:
Add topic icon is yellow

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

AC	Status	Details
1	✅	T366662#9924049

Details

	Subject	Repo	Branch	Lines +/-
	POC: Use mask-image for all Vector icons	mediawiki/skins/Vector	master	+15 -44

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Wed, Jun 5, 3:22 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Jun 5, 3:22 AM

Change #1038910 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] POC: Use mask-image for all Vector icons

https://gerrit.wikimedia.org/r/1038910

gerritbot added a project: Patch-For-Review.Wed, Jun 5, 3:23 AM

Jdlrobson triaged this task as Medium priority.Wed, Jun 5, 3:49 PM

Jdlrobson moved this task from Backlog to Night mode (desktop) on the FY2023-24-WE 2.1 Typography and palette customizations board.

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog board.Fri, Jun 7, 4:24 PM

Change #1038910 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] POC: Use mask-image for all Vector icons

Reason:

To be discussed with DST on Tuesday June 18th

https://gerrit.wikimedia.org/r/1038910

Appears to have been fixed in previous sprint. Adding to QA (see https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Structured_Discussions)

Jdlrobson renamed this task from Talk button in sticky header is unnecessarily inverted to [QA only] Talk button in sticky header is unnecessarily inverted.Mon, Jun 17, 11:26 PM

Jdlrobson assigned this task to GMikesell-WMF.

Jdlrobson set the point value for this task to 0.

Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

Maintenance_bot removed a project: Patch-For-Review.Mon, Jun 17, 11:31 PM

@Jdlrobson The issue in the actual task passes but can you review the test.wiki as seen in the gif below, thanks!

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

✅Beta	❓Test.wiki
	Different issue but you can't select Visual Editing just Source editing, along with the words are dark

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.Tue, Jun 25, 10:01 PM

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

GMikesell-WMF subscribed.

Different issue but you can't select Visual Editing just Source editing, along with the words are dark

@GMikesell-WMF this is out of scope for this ticket. (FWIW I think this is a feature)

Jdrewniak assigned this task to ovasileva.Thu, Jun 27, 4:48 PM

ovasileva closed this task as Resolved.Fri, Jun 28, 2:46 PM

	F54948106: Screenshot 2024-06-04 at 8.22.09 PM.png
	Wed, Jun 5, 3:22 AM

[QA only] Talk button in sticky header is unnecessarily invertedClosed, ResolvedPublic0 Estimated Story PointsBUG REPORTActions