Page MenuHomePhabricator

Add 'status' parameter
Closed, ResolvedPublic

Description

Background
Users who submit a wish may want to workshop it with others before it is "final." Though wishes can be editable at any time, wish creators may want to leave a wish in a draft state.

User story
Given that I've written a wish but don't feel comfortable about how it's written, when I go to submit, then I should see a "save as draft" button, and if I click it, then the wish should be published with a status of "draft," and the "draft" status should be shown on the wish index page and the wish itself.

Requirements

  • Add the |status= parameter to the Proposal template.

Derived Requirement

Add a 'status' parameter to the Proposal template to allow users to save a wish in a draft state and display the draft status on the wish index page and the wish itself.

BDD

Feature: Save Wish as Draft

Scenario: User saves a wish as a draft

Given a user has written a wish
When the user clicks the "save as draft" button
Then the wish should be published with a status of "draft"
And the draft status should be shown on the wish index page and the wish itself

Test Steps

Test Case 1: Save a wish as a draft

Write a wish on the proposal form.

  1. Click the "save as draft" button.
  2. AC1: Confirm the wish is published with a status of "draft."
  3. AC2: Confirm the draft status is shown on the wish index page and the wish itself.

QA Results - Wishlist-test.toolforge

ACStatusDetails
1T366689#9910966

Design file: https://www.figma.com/file/JcTMFwbEJPpCKBiZ16Jkel/Future-of-the-Wishlist?type=design&node-id=1368%3A14631&mode=design&t=rER9ipRKRiDWpZil-1

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

the |status= parameter has been added to Template:Community_Requests/Wish

@TheresNoTime Am I supposed to see a "save as draft" button on the form because I don't see it as seen in the screenshot and test link provided below? Am I not in the right spot or the right link? Based on the info from the background, user story, and requirement, I was able to fill out the rest of the description but I'm not seeing any of that from the patchdemo link.

Test Result - Patch demo

Status: ❓Need More Info
Environment: Patch demo
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test link: https://patchdemo.wmflabs.org/wikis/780dec507c/wiki/Community_Requests/Intake

2024-06-18_15-02-08.png (1×2 px, 229 KB)

Hey @GMikesell-WMF, the "save as draft" button is not being implemented at the moment (sorry, those screenshots are out of date) — if you view the wikitext of the created wish page you should see a |status = param. If so, this task is working as expected.

@TheresNoTime Status does appear as seen in the screenshots. I will move this to Done. Thanks for all your work!

Test Result - Wishlist-test.toolforge

Status: ✅ PASS
Environment: Wishlist-test.toolforge
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test link: https://wishlist-test.toolforge.org/wiki/Community_Wishlist

2024-06-20_10-08-34.png (1×2 px, 316 KB)

2024-06-20_10-08-18.png (863×2 px, 166 KB)