Page MenuHomePhabricator
Create Task
Maniphest T366809

Category pagination broken on Commons
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The URL generated by the "(next page)" link is correct and contains the 201st file in &filefrom=, but the page still shows the first 200 files.

The from= URL parameter is also broken, as shown by https://commons.wikimedia.org/w/index.php?title=Category:Images_from_Wiki_Loves_Earth_2024&from=P showing files starting with the letter H.

What should have happened instead?:
Clicking "(next page)" should show the next 200 files.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Likely related to T362494: Enable numerical category sorting on Commons based on timing.

Details

SubjectRepoBranchLines +/-
Add a note that you cannot change wgCategoryCollation easilyoperations/mediawiki-configmaster+2 -0
Revert "commonswiki: Enable numeric wgCategoryCollation"operations/mediawiki-configmaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

AntiCompositeNumber created this task.Thu, Jun 6, 2:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Jun 6, 2:58 PM
TheresNoTime subscribed.Thu, Jun 6, 2:59 PM
ClydeFranklin subscribed.Thu, Jun 6, 3:02 PM
gerritbot added a comment.Thu, Jun 6, 3:04 PM

Change #1039746 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/mediawiki-config@master] Revert "commonswiki: Enable numeric wgCategoryCollation"

https://gerrit.wikimedia.org/r/1039746

gerritbot added a project: Patch-For-Review.Thu, Jun 6, 3:04 PM
gerritbot added a comment.Thu, Jun 6, 3:08 PM

Change #1039746 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "commonswiki: Enable numeric wgCategoryCollation"

https://gerrit.wikimedia.org/r/1039746

Stashbot added a comment.Thu, Jun 6, 3:09 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-06T15:09:03Z] <jforrester@deploy1002> Started scap: Backport for [[gerrit:1039746|Revert "commonswiki: Enable numeric wgCategoryCollation" (T366809)]]

Stashbot added a comment.Thu, Jun 6, 3:11 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-06T15:11:34Z] <jforrester@deploy1002> jforrester: Backport for [[gerrit:1039746|Revert "commonswiki: Enable numeric wgCategoryCollation" (T366809)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

gerritbot added a comment.Thu, Jun 6, 3:14 PM

Change #1039767 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/mediawiki-config@master] Add a note that you cannot change wgCategoryCollation easily

https://gerrit.wikimedia.org/r/1039767

Stashbot added a comment.Thu, Jun 6, 3:23 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-06T15:23:02Z] <jforrester@deploy1002> Finished scap: Backport for [[gerrit:1039746|Revert "commonswiki: Enable numeric wgCategoryCollation" (T366809)]] (duration: 13m 58s)

AntiCompositeNumber added a comment.Thu, Jun 6, 4:12 PM

Pagination appears to be working correctly now.

[15:01:42] <TheresNoTime>	 Minor worry that my deploy of T362494 has caused T366809 (cc anzx)
[15:01:43] <stashbot>	 T362494: Enable numerical category sorting on Commons - https://phabricator.wikimedia.org/T362494
[15:01:43] <stashbot>	 T366809: Category pagination broken on Commons  - https://phabricator.wikimedia.org/T366809
[15:02:30] <James_F>	 Hmm, could do.
[15:02:52] <James_F>	 In general, category changes are very expensive, and exceptionally-so for Commons.
[15:03:22] <James_F>	 Maybe revert?
[15:03:45] <TheresNoTime>	 only ever ran `mwscript updateCollation.php --wiki commonswiki --dry-run` though (and even then, for maybe a minute before the comment to not run that)
[15:04:01] <James_F>	 Yeah, but ever edit/re-parse will use the new code.
[15:04:08] <James_F>	 Whereas the 100M other pages will be on the old collation.
[15:04:09] <TheresNoTime>	 oh yes
[15:04:16] <James_F>	 Hence the "fun". :-(
[15:04:32] <James_F>	 Commons really shouldn't be MW-based, as nothing we have copes at its scale.
[15:04:51] <wikibugs>	 (03PS1) 10Jforrester: Revert "commonswiki: Enable numeric wgCategoryCollation" [mediawiki-config] - 10https://gerrit.wikimedia.org/r/1039746 (https://phabricator.wikimedia.org/T366809)
[15:05:01] <taavi>	 i fear that even after reverting there will be a bunch of pages that were saved with the current value and then would be broken
[15:05:17] <James_F>	 Sure, but a few tens of thousands vs. millions.
[15:05:23] <taavi>	 yep
[15:05:24] <James_F>	 Greatest good for the greatest number.
[15:05:53] <James_F>	 And categories are a hack that aren't guaranteed to be working, as ever. (Though they're amazingly much better since Tim and others improved them over the past few years.)
[15:06:11] <James_F>	 TheresNoTime: Want me to push out the revert?
[15:06:17] <wikibugs>	 (03CR) 10Majavah: [C:03+1] Revert "commonswiki: Enable numeric wgCategoryCollation" [mediawiki-config] - 10https://gerrit.wikimedia.org/r/1039746 (https://phabricator.wikimedia.org/T366809) (owner: 10Jforrester)
[15:06:35] <TheresNoTime>	 James_F: i.e deploy that patch ^ ?
[15:06:39] <James_F>	 Yeah.
[15:06:58] <TheresNoTime>	 James_F: yes please, better safe than sorry I suppose
Jdforrester-WMF closed this task as Resolved.Thu, Jun 6, 4:47 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF subscribed.

There may be some pages that are wrong, but this should sort itself out as they're re-parsed.

gerritbot added a comment.Mon, Jun 17, 8:01 PM

Change #1039767 merged by jenkins-bot:

[operations/mediawiki-config@master] Add a note that you cannot change wgCategoryCollation easily

https://gerrit.wikimedia.org/r/1039767

Stashbot mentioned this in T362494: Enable numerical category sorting on Commons.Mon, Jun 17, 8:01 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-17T20:01:57Z] <jforrester@deploy1002> Started scap: Backport for [[gerrit:1041659|[wikifunctionswiki] Remove right to promote/demote sysops and bureaucrats from staff (T365627)]], [[gerrit:1039767|Add a note that you cannot change wgCategoryCollation easily (T362494 T366809)]]

Stashbot mentioned this in T365627: Remove rights to promote and demote bureaucrats and admins from Wikifunctions staff.Mon, Jun 17, 8:02 PM
Stashbot added a comment.Mon, Jun 17, 8:07 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-17T20:06:59Z] <jforrester@deploy1002> jforrester: Backport for [[gerrit:1041659|[wikifunctionswiki] Remove right to promote/demote sysops and bureaucrats from staff (T365627)]], [[gerrit:1039767|Add a note that you cannot change wgCategoryCollation easily (T362494 T366809)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Mon, Jun 17, 8:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL