Page MenuHomePhabricator

Table: Heading design improvements
Open, Needs TriagePublic

Assigned To
None
Authored By
Sarai-WMDE
Thu, Jun 6, 5:49 PM
Referenced Files
F55291979: Screenshot 2024-06-13 at 20.17.11.png
Thu, Jun 13, 6:27 PM
F54973876: Screenshot 2024-06-06 at 19.36.07.png
Thu, Jun 6, 5:49 PM
F54973530: bottom-al.gif
Thu, Jun 6, 5:49 PM
F54973366: 3.png
Thu, Jun 6, 5:49 PM

Description

Background

There are a series of visual fixes that would improve the appearance of Codex Table's headings. This task collects design issues and, if known, the potential solutions we could apply to address these.

Issues
FixDescriptionScreenshots/Specs
1. Headings should be aligned at the bottom (instead of at the center). This is to avoid creating unnecessary white space and visually support their connection with their respective columns, even if their text wraps.To achieve this, we could apply vertical-align: bottom to <th>s, in combination with align-items: flex-end to buttons. Unfortunately, we'll need to take special measures to ensure that the text and the icons within the bottom-aligned heading cells remain centered before the text wraps (e.g., applying a bottom padding of 2px to sort icons does the trick, but this doesn't sound ideal).
3.png (800×2 px, 112 KB)
2. Make sure that heading icons don't shrink when they lack spaceAt the moment, icons become smaller when space within the heading is compromised (e.g., in case the heading text uses a bigger font size). Looks like adding flex-shrink: 0 to the icons would fix this issue.
bottom-al.gif (358×848 px, 120 KB)
3. Make sure that heading buttons take all the available height of <th>s when content wrapsWe attempted to fix this in the past (see T364932). The problem is very visually prominent, specially in tables without headers (see screenshot). If this is not feasible technically, we could evaluate other design approaches (different ways to represent states) that could help minimize the issue
Screenshot 2024-06-06 at 19.36.07.png (644×1 px, 90 KB)
4. Place sort icons next to heading textIn the current design, the heading text and sort icon are justified using space-between. Unfortunately, in this layout, the relationship between headings and their corresponding sort icons is sometimes not immediately apparent. The issue accentuates when vertical borders are missing and/or headings with opposite alignment follow each other.
Screenshot 2024-06-13 at 20.17.11.png (600×1 px, 60 KB)
Acceptance criteria
  • We define and apply fixes to improve the design of Table headings