Page MenuHomePhabricator

When one transclusion generates multiple table cells, VE counts it as a single table cell, and adds slugs for "missing" cells
Open, Needs TriagePublic

Description

Following the Parsoid fix in T363170 (and T166183), when a single transclusion generates multiple table cells, they are now correctly treated as belonging to one transclusion; however, the transclusion is counted as a single table cell, which causes VE to think that the table row is incomplete, and add slugs for "missing" cells at the end of the row.

For example:

Event Timeline

Change #1039600 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Allow TableCellableNode to span multiple DOM elements

https://gerrit.wikimedia.org/r/1039600

Change #1039601 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Allow MWTransclusionTableCellNode to span multiple DOM elements

https://gerrit.wikimedia.org/r/1039601

Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/db9f7689ea/w

Change #1041128 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Handle multi-cell alien table cells

https://gerrit.wikimedia.org/r/1041128

Change #1041128 abandoned by Esanders:

[VisualEditor/VisualEditor@master] Handle multi-cell alien table cells

Reason:

See If317f991a4782bbc980d3923178799e1c67ebaa8

https://gerrit.wikimedia.org/r/1041128

Change #1039600 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Allow TableCellableNode to span multiple DOM elements

https://gerrit.wikimedia.org/r/1039600

Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/db9f7689ea/w/

Change #1047532 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (622a5ec51)

https://gerrit.wikimedia.org/r/1047532

Change #1039601 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (65e536c1c)

https://gerrit.wikimedia.org/r/1039601

Change #1047532 abandoned by Esanders:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (622a5ec51)

Reason:

https://gerrit.wikimedia.org/r/1047532