Page MenuHomePhabricator

PHP Deprecated: Use of QuickSurveys survey with link parameter was deprecated in MediaWiki 1.43. [Called from QuickSurveys\SurveyFactory::factoryExternal]
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of QuickSurveys survey with link parameter was deprecated in MediaWiki 1.43. [Called from QuickSurveys\SurveyFactory::factoryExternal]
exception.trace
from /srv/mediawiki/php-master/extensions/QuickSurveys/includes/SurveyFactory.php(423)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-master/includes/debug/MWDebug.php(385): trigger_error(string, integer)
#2 /srv/mediawiki/php-master/includes/debug/MWDebug.php(356): MediaWiki\Debug\MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-master/includes/debug/MWDebug.php(237): MediaWiki\Debug\MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-master/includes/GlobalFunctions.php(775): MediaWiki\Debug\MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-master/extensions/QuickSurveys/includes/ExternalSurvey.php(84): wfDeprecated(string, string)
#6 /srv/mediawiki/php-master/extensions/QuickSurveys/includes/SurveyFactory.php(423): QuickSurveys\ExternalSurvey->__construct(string, integer, array, string, NULL, NULL, QuickSurveys\SurveyAudience, array, string, string, NULL, string, NULL, NULL, NULL)
#7 /srv/mediawiki/php-master/extensions/QuickSurveys/includes/SurveyFactory.php(135): QuickSurveys\SurveyFactory->factoryExternal(array)
#8 /srv/mediawiki/php-master/extensions/QuickSurveys/includes/SurveyFactory.php(48): QuickSurveys\SurveyFactory->newSurvey(array)
#9 /srv/mediawiki/php-master/extensions/QuickSurveys/includes/ServiceWiring.php(30): QuickSurveys\SurveyFactory->parseSurveyConfig(array)
#10 /srv/mediawiki/php-master/vendor/wikimedia/services/src/ServiceContainer.php(447): Wikimedia\Services\ServiceContainer::{closure}(MediaWiki\MediaWikiServices)
#11 /srv/mediawiki/php-master/vendor/wikimedia/services/src/ServiceContainer.php(411): Wikimedia\Services\ServiceContainer->createService(string)
#12 /srv/mediawiki/php-master/includes/MediaWikiServices.php(354): Wikimedia\Services\ServiceContainer->getService(string)
#13 /srv/mediawiki/php-master/extensions/QuickSurveys/includes/Hooks.php(54): MediaWiki\MediaWikiServices->getService(string)
#14 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(159): QuickSurveys\Hooks->onBeforePageDisplay(MediaWiki\Output\OutputPage, MediaWiki\Minerva\Skins\SkinMinerva)
#15 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(945): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#16 /srv/mediawiki/php-master/includes/Output/OutputPage.php(3010): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(MediaWiki\Output\OutputPage, MediaWiki\Minerva\Skins\SkinMinerva)
#17 /srv/mediawiki/php-master/includes/actions/ActionEntryPoint.php(162): MediaWiki\Output\OutputPage->output(boolean)
#18 /srv/mediawiki/php-master/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#19 /srv/mediawiki/php-master/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#20 /srv/mediawiki/w/index.php(3): require(string)
#21 {main}
Impact

These warnings are happening steadily in beta cluster for many urls, and are sometimes causing the beta-scap-sync-world job to fail (due to the canary error rate check (which apparently includes warnings)). 7469 hits in the last hour.

Details

Request URL
https://meta.wikimedia.beta.wmflabs.org/wiki/Special:AbuseFilter/examine/log/211492

Event Timeline

Change #1041748 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Disable quick surveys using deprecated configuration

https://gerrit.wikimedia.org/r/1041748

Change #1041748 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable quick surveys using deprecated configuration

https://gerrit.wikimedia.org/r/1041748

Mentioned in SAL (#wikimedia-operations) [2024-06-12T20:17:23Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:1041748|Disable quick surveys using deprecated configuration (T367128)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-12T20:19:57Z] <cjming@deploy1002> jdlrobson, cjming: Backport for [[gerrit:1041748|Disable quick surveys using deprecated configuration (T367128)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-12T20:29:22Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:1041748|Disable quick surveys using deprecated configuration (T367128)]] (duration: 11m 59s)

Should be fixed now.

Change #1043880 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Cleanup: Remove wgNavigationTimingSurveyName

https://gerrit.wikimedia.org/r/1043880

Change #1043880 merged by jenkins-bot:

[operations/mediawiki-config@master] Cleanup: Remove wgNavigationTimingSurveyName

https://gerrit.wikimedia.org/r/1043880

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:32:58Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:1043880|Cleanup: Remove wgNavigationTimingSurveyName (T367128)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:35:34Z] <cjming@deploy1002> jdlrobson, cjming: Backport for [[gerrit:1043880|Cleanup: Remove wgNavigationTimingSurveyName (T367128)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:41:27Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:1043880|Cleanup: Remove wgNavigationTimingSurveyName (T367128)]] (duration: 08m 29s)