Page MenuHomePhabricator

Provide detailed reports for wikis currently passing contrast checks
Closed, ResolvedPublic3 Estimated Story Points

Description

Background

  • Prior to wider dark mode deployment for desktop, we would like to deepen the accessibility checks we perform for wikis we

User story

  • As a designer, I want to understand the accessibility of dark mode across wikis so that I can gauge preparation for deployment

Requirements

  • Perform manual checks of the night mode checker with top 1000 articles: Wikis for which dark mode has fewer accessibility concerns than light mode according to https://night-mode-checker.wmcloud.org/
Array.from(document.querySelectorAll('.ontrack')).map((s)=>s.querySelector('a').getAttribute('href').split('-')[0])
  • Perform manual checks of the night mode checker with top 1000 articles: Wikis for which dark mode has up to 20% more errors than light mode according to https://night-mode-checker.wmcloud.org/
  • Publish results for discussion

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

n/a

Acceptance criteria

see requirements

Communication criteria - does this need an announcement or discussion?

n/a

Rollback plan

n/a
This task was created by Version 1.0.0 of the Web team task template using phabulous

Event Timeline

It would be nice if we could configure the contrast checker to "ignore" elements that aren't text or icons. This would exclude things like borders from our counts because they don't need to meet the same contrast threshold as interactive elements.

The checks should only be on text right now. We unfortunately cannot test for icons with this tool.

For the following lists of wikis, perform manual checks of the night mode checker with 1000 articles:

What wikis are we wanting to test on - there is no list.

Wikis for which the difference between dark and light mode is less than 20%

This probably should be qualified in terms of percentage increase/decrease. Does this mean we see at least a 20% decrease in accessibility issues when switching from light to dark theme?

For the following lists of wikis, perform manual checks of the night mode checker with 1000 articles:

What wikis are we wanting to test on - there is no list.

The list would depend on the day we test (since we might see some improvements between now and next week when we start testing). Right now the requirement is "Wikis for which dark mode has fewer accessibility concerns" based on https://night-mode-checker.wmcloud.org/ - I'll add a link to the checker to make this clearer

Wikis for which the difference between dark and light mode is less than 20%

This probably should be qualified in terms of percentage increase/decrease. Does this mean we see at least a 20% decrease in accessibility issues when switching from light to dark theme?

A couple of options:

  • Wikis for which the difference in the number of errors between dark and light mode is less than 20% of the total number of errors
  • Wikis for which dark mode has up to 20% more errors than light mode according to https://night-mode-checker.wmcloud.org/ (I think this definition is a little bit clearer - I'll add it)
ovasileva updated the task description. (Show Details)
Jdlrobson raised the priority of this task from High to Needs Triage.Jun 13 2024, 5:41 PM
Jdlrobson triaged this task as High priority.

A blocker for the upcoming Minerva deployment

Jdlrobson lowered the priority of this task from High to Medium.Jun 20 2024, 4:55 PM
ovasileva raised the priority of this task from Medium to High.Jun 24 2024, 5:13 PM

We do not currently have a way to automate this. Since manual checks take a significant amount of time, we decided to proceed with 500 articles instead of 1000.

Discussed in standup. We will be making the deploy decisions on which deployment tier (logged-out and logged-in deploy or logged-in only deploy) wikis will get on dark mode based on the results for desktop only. We will compare these to the automated results from Minerva for the top 50 articles, but will make the decision based on desktop so wikis have dark mode consistently across wiki on both desktop and mobile