Gallery (traditional mode) thumbnails should use border-subtle, same as other thumbnails
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pcoombe
	Tue, Jun 25, 4:59 AM

Description

The <gallery> tag in traditional mode has thumbnails with a hardcoded border of 1px solid #c8ccd1. They don't look good in dark mode, and don't match other media thumbnails

Screenshot 2024-06-24 at 21.31.45.png (844×1 px, 889 KB)

They could be changed to use the border-subtle design token, matching other thumbnails

Screenshot 2024-06-24 at 21.54.53.png (834×1 px, 884 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Use border-subtle for gallery (traditional mode) thumbnails	mediawiki/core	master	+1 -1

Customize query in gerrit

Event Timeline

Pcoombe created this task.Tue, Jun 25, 4:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Jun 25, 4:59 AM

Change #1049291 had a related patch set uploaded (by Pcoombe; author: Pcoombe):

[mediawiki/core@master] Use border-subtle for gallery (traditional mode) thumbnails

https://gerrit.wikimedia.org/r/1049291

gerritbot added a project: Patch-For-Review.Tue, Jun 25, 5:01 AM

Change #1049291 merged by jenkins-bot:

[mediawiki/core@master] Use border-subtle for gallery (traditional mode) thumbnails

https://gerrit.wikimedia.org/r/1049291

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Tue, Jun 25, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 25, 8:30 PM

Jdlrobson added a project: Web-Team-Backlog.Wed, Jun 26, 6:58 PM

Jdlrobson moved this task from Incoming to FY2024-25 Q1 Sprint 1 on the Web-Team-Backlog board.Wed, Jun 26, 8:09 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 1); removed Web-Team-Backlog.

ovasileva triaged this task as Medium priority.Thu, Jun 27, 3:11 PM

ovasileva moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

Jdlrobson added projects: dark-mode, patch-welcome.Fri, Jun 28, 2:57 AM

Jdlrobson moved this task from Backlog to Web on the dark-mode board.Fri, Jun 28, 3:03 AM

Should be fixed by @Pcoombe's patch.

Jdlrobson awarded a token.Sat, Jun 29, 2:05 AM

	F55865573: Screenshot 2024-06-24 at 21.54.53.png
	Tue, Jun 25, 4:59 AM

	F55865414: Screenshot 2024-06-24 at 21.31.45.png
	Tue, Jun 25, 4:59 AM

Gallery (traditional mode) thumbnails should use border-subtle, same as other thumbnailsClosed, ResolvedPublicActions

Description

Details

Event Timeline

Gallery (traditional mode) thumbnails should use border-subtle, same as other thumbnails
Closed, ResolvedPublic
Actions