SkinMinervaTest.php fails when run in a suite with SpecialAvailableBadgesTest.php
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	ArthurTaylor
	Tue, Jun 25, 9:01 AM

Description

Problem

The SkinMinervaTest class fails if run in a test suite with SpecialAvailableBadgesTest before it. 1 test errors and 3 tests fail. Running the classes individually causes no problems.

Steps to reproduce
In a Mediawiki checkout with the Wikibase extension and Minerva skin installed.

Copy phpunit.dist.xml to phpunit.xml
Add a test suite with the following two tests:

 <testsuite name="failing_group">
    <file>extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialAvailableBadgesTest.php</file>
    <file>skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php</file>
</testsuite>

Run the named test suite:

mw docker mediawiki exec -- composer run phpunit:entrypoint -- --testsuite failing_group

Observed behaviour
The test run fails:

$ mw docker mediawiki exec -- composer run phpunit:entrypoint -- --testsuite failing_group
> phpunit '--testsuite' 'failing_group'
Running with MediaWiki settings because there might be integration tests
PHPUnit 9.6.16 by Sebastian Bergmann and contributors.

....F..FF....E..................                                  32 / 32 (100%)

Time: 00:01.601, Memory: 62.50 MB

There was 1 error:

1) MediaWiki\Minerva\SkinMinervaTest::testGetTabsDataNoPageTabs
RuntimeException: Database backend disabled

/var/www/html/w/includes/libs/rdbms/loadbalancer/LoadBalancerDisabled.php:72
...

--

There were 3 failures:

1) MediaWiki\Minerva\SkinMinervaTest::testHasPageActions with data set #2 (0, 'Main Page', 'view', false)
Failed asserting that true matches expected false.

/var/www/html/w/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php:90

2) MediaWiki\Minerva\SkinMinervaTest::testHasPageTabs with data set #1 (array(false), 0, 'Main Page', 'view', false)
Failed asserting that true matches expected false.

/var/www/html/w/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php:122

3) MediaWiki\Minerva\SkinMinervaTest::testHasPageTabs with data set #2 (array(false), 1, 'Main Page', 'view', false)
Failed asserting that true matches expected false.

/var/www/html/w/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php:122
===

ERRORS!
Tests: 32, Assertions: 51, Errors: 1, Failures: 3.

Expected Behaviour
The tests should pass.

Details

	Subject	Repo	Branch	Lines +/-
	Add strict types to modified test file	mediawiki/extensions/Wikibase	master	+1 -0
	Remove deprecated `setContentLang` call	mediawiki/extensions/Wikibase	master	+0 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T361118 [REPO][CLIENT][SW] Reduce CI test runtime for Wikibase and related extensions
Open	ArthurTaylor	T365567 [REPO][CLIENT][SW] Implement PHPUnit test suite splitting as composer tasks
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	pmiazga	T50217 Speed up MediaWiki PHPUnit build by running integration tests in parallel
Open	None	T365976 [REPO][CLIENT][SW] Create a `composer phpunit:prepare-parallel-test-suites` command to split suite into smaller groups
Resolved	None	T368369 SkinMinervaTest.php fails when run in a suite with SpecialAvailableBadgesTest.php

Event Timeline

ArthurTaylor created this task.Tue, Jun 25, 9:01 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Jun 25, 9:01 AM

ArthurTaylor added a parent task: T365976: [REPO][CLIENT][SW] Create a `composer phpunit:prepare-parallel-test-suites` command to split suite into smaller groups.Tue, Jun 25, 9:02 AM

Maintenance_bot moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.Tue, Jun 25, 9:29 AM

Maintenance_bot added a project: Wikidata.

Had a look into this. This seems to be (as usual) a combination of incomplete setUp/tearDown and global state.

In SpecialAvailableBadgesTest, we set the language to qqx:

	protected function setUp(): void {
		parent::setUp();

		$this->setContentLang( 'qqx' );
		$this->setUserLang( 'qqx' );
	}

setContentLang here is deprecated, there is no corresponding tearDown, and the code seems unnecessary (the test passes if the setup is removed).

In SkinMinerva, hasPageActions relies on a check of $title->isMainPage():

	private function hasPageActions() {
		$title = $this->getTitle();
		return !$title->isSpecialPage() && !$title->isMainPage() &&
			$this->getContext()->getActionName() === 'view';
	}

and Title::isMainPage was changed (in Sep 2023 - T302186) to include a cached copy of a main page object:

	public function isMainPage() {
		/** @var Title|null */
		static $cachedMainPage;
		if ( $cachedMainPage === null ) {
			$cachedMainPage = self::newMainPage();
		}
		return $this->equals( $cachedMainPage );
	}

This equals check seems to be sensitive to the language in use. With language set to qqx, the main page gets the key (mainpage), whereas by default it has the key Main_Page. This difference causes the comparison to fail when the two tests are run together in the same suite, sending the code down the getActionName path.

For now, I propose simply to remove the setUp in SpecialAvailableBadgesTest and see what happens.

Change #1049495 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove deprecated `setContentLang` call

https://gerrit.wikimedia.org/r/1049495

gerritbot added a project: Patch-For-Review.Tue, Jun 25, 9:48 AM

ArthurTaylor moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.Tue, Jun 25, 9:49 AM

ArthurTaylor removed ArthurTaylor as the assignee of this task.Tue, Jun 25, 10:40 AM

ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.

hoo moved this task from Ready for Peer Review to Ready for Tech Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Tue, Jun 25, 4:42 PM

Change #1049495 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove deprecated `setContentLang` call

https://gerrit.wikimedia.org/r/1049495

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Tue, Jun 25, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 25, 6:30 PM

ArthurTaylor closed this task as Resolved.Thu, Jul 4, 10:17 AM

ArthurTaylor moved this task from Ready for Tech Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.

Change #1052273 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Add strict types to modified test file

https://gerrit.wikimedia.org/r/1052273

gerritbot added a project: Patch-For-Review.Fri, Jul 5, 9:33 AM

Change #1052273 merged by jenkins-bot: