Page MenuHomePhabricator
Create Task
Maniphest T368575

Fix 2010 TemplateWizard in night theme
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
A warning is shown that is not night mode compatible

Screenshot 2024-06-26 at 21.19.14.png (1×1 px, 105 KB)

Now make some edits
Try to close the dialog

You will get a white wash of the dialog

Screenshot 2024-06-26 at 21.19.37.png (1×1 px, 137 KB)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Related Objects

Event Timeline

TheDJ created this task.Wed, Jun 26, 7:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Jun 26, 7:22 PM
TheDJ mentioned this in T367362: Fix 2010 Wikitext editor in night theme.Wed, Jun 26, 7:22 PM
Jdlrobson edited projects, added Community-Tech; removed Web-Team-Backlog.Wed, Jun 26, 8:06 PM
Jdlrobson subscribed.

Hey Community Tech you are listed as the maintainers on TemplateWizard on https://www.mediawiki.org/wiki/Developers/Maintainers - dark mode is going to be deployed on 16th to desktop for select wikis and as it stands it will ship with this bug.

We can add notheme class as a short-term fix if needed - let us know!

MusikAnimal subscribed.Wed, Jun 26, 9:36 PM

F55899824 has the background set from .oo-ui-processDialog-errors, so that should be fixed in OOUI.

It looks like otherwise we only need to do something about the background color from .ext-templatewizard-templatetitlebar

Jdlrobson added a project: OOUI.Wed, Jun 26, 9:58 PM
Jdlrobson moved this task from Backlog to Web on the dark-mode board.Fri, Jun 28, 3:02 AM
Jdlrobson added a project: patch-welcome.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits