Page MenuHomePhabricator
Create Task
Maniphest T368617

Internal error on Special:AllEvents
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Visit the following page
https://en.wikipedia.beta.wmflabs.org/wiki/Special:AllEvents?wpSearch=&wpMeetingType=1&wpStartDate=&wpEndDate=&limit=250

Note, if the limit is set to 31 or less then there is no error
If the limit is 32 or more then the internal error will occur

What happens?:

message
[Zn1pGoK92-DHSApvUnHDkwAAAEc] /wiki/Special:AllEvents?limit=250&wpEndDate=&wpMeetingType=1&wpSearch=&wpStartDate= TypeError: Return value of MediaWiki\Extension\CampaignEvents\MWEntity\CampaignsCentralUserLookup::getUserName() must be of the type string, bool returned
trace
from /srv/mediawiki/php-master/extensions/CampaignEvents/src/MWEntity/CampaignsCentralUserLookup.php(111)
#0 /srv/mediawiki/php-master/extensions/CampaignEvents/src/MWEntity/UserLinker.php(54): MediaWiki\Extension\CampaignEvents\MWEntity\CampaignsCentralUserLookup->getUserName(MediaWiki\Extension\CampaignEvents\MWEntity\CentralUser)
#1 /srv/mediawiki/php-master/extensions/CampaignEvents/src/MWEntity/UserLinker.php(78): MediaWiki\Extension\CampaignEvents\MWEntity\UserLinker->generateUserLink(MediaWiki\Extension\CampaignEvents\MWEntity\CentralUser)
#2 /srv/mediawiki/php-master/extensions/CampaignEvents/src/Pager/EventsListPager.php(284): MediaWiki\Extension\CampaignEvents\MWEntity\UserLinker->generateUserLinkWithFallback(MediaWiki\Extension\CampaignEvents\MWEntity\CentralUser, string)
#3 [internal function]: MediaWiki\Extension\CampaignEvents\Pager\EventsListPager->MediaWiki\Extension\CampaignEvents\Pager\{closure}(MediaWiki\Extension\CampaignEvents\Organizers\Organizer)
#4 /srv/mediawiki/php-master/extensions/CampaignEvents/src/Pager/EventsListPager.php(282): array_map(Closure, array)
#5 /srv/mediawiki/php-master/extensions/CampaignEvents/src/Pager/EventsListPager.php(255): MediaWiki\Extension\CampaignEvents\Pager\EventsListPager->getOrganizersText(stdClass)
#6 /srv/mediawiki/php-master/extensions/CampaignEvents/src/Pager/EventsListPager.php(162): MediaWiki\Extension\CampaignEvents\Pager\EventsListPager->formatRow(stdClass)
#7 /srv/mediawiki/php-master/includes/pager/IndexPager.php(601): MediaWiki\Extension\CampaignEvents\Pager\EventsListPager->getRow(stdClass)
#8 /srv/mediawiki/php-master/extensions/CampaignEvents/src/Special/SpecialAllEvents.php(114): MediaWiki\Pager\IndexPager->getBody()
#9 /srv/mediawiki/php-master/extensions/CampaignEvents/src/Special/SpecialAllEvents.php(42): MediaWiki\Extension\CampaignEvents\Special\SpecialAllEvents->showFormAndEvents()
#10 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(719): MediaWiki\Extension\CampaignEvents\Special\SpecialAllEvents->execute(NULL)
#11 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(1694): MediaWiki\SpecialPage\SpecialPage->run(NULL)
#12 /srv/mediawiki/php-master/includes/actions/ActionEntryPoint.php(502): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#13 /srv/mediawiki/php-master/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#14 /srv/mediawiki/php-master/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#15 /srv/mediawiki/php-master/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}

What should have happened instead?:

User should see the Special:AllEvents page

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
1.43.0-alpha

Other information (browser name/version, screenshots, etc.):
Chrome

Screenshot 2024-06-27 at 8.31.08 AM.png (1×2 px, 844 KB)

Details

SubjectRepoBranchLines +/-
Fix uncaught exception in AllEvents for deleted usersmediawiki/extensions/CampaignEventsmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

vaughnwalters created this task.Thu, Jun 27, 1:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Jun 27, 1:33 PM
vaughnwalters mentioned this in T365271: Special:AllEvents user should not be able to select a To date that is before the From date.Thu, Jun 27, 1:34 PM
Daimona updated the task description. (Show Details)Thu, Jun 27, 1:47 PM
Daimona mentioned this in T368620: Error logs in beta have vanished.Thu, Jun 27, 2:00 PM
Daimona subscribed.Thu, Jun 27, 2:10 PM

I found out that the event causing the exception is https://meta.wikimedia.beta.wmflabs.org/wiki/Special:EventDetails/119, whose organizer's account has been deleted. I still have to reproduce the actual exception though, and T368620 certainly doesn't help.

Daimona claimed this task.Thu, Jun 27, 2:24 PM
Daimona edited projects, added Campaign-Tools (Campaign-Tools-Current-Sprint); removed Campaign-Tools.
Daimona moved this task from Needs Input / Design in progress to In Progress 💻 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

I have a fix for this and will push it shortly. What I still need to understand is why phan didn't flag the problem.

Daimona added a comment.Thu, Jun 27, 2:45 PM
In T368617#9930694, @Daimona wrote:

What I still need to understand is why phan didn't flag the problem.

Filed as https://github.com/phan/phan/issues/4863.

gerritbot added a comment.Thu, Jun 27, 2:47 PM

Change #1050392 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Fix uncaught exception in AllEvents for deleted users

https://gerrit.wikimedia.org/r/1050392

gerritbot added a project: Patch-For-Review.Thu, Jun 27, 2:47 PM
Daimona moved this task from In Progress 💻 to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Thu, Jun 27, 2:48 PM
gerritbot added a comment.Sun, Jun 30, 8:04 AM

Change #1050392 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix uncaught exception in AllEvents for deleted users

https://gerrit.wikimedia.org/r/1050392

Maintenance_bot removed a project: Patch-For-Review.Sun, Jun 30, 8:30 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Sun, Jun 30, 9:00 AM
Daimona moved this task from Code Review to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Sun, Jun 30, 12:15 PM
vaughnwalters closed this task as Resolved.Mon, Jul 1, 3:08 PM
vaughnwalters moved this task from QA 🐛 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

✅ User should see the Special:AllEvents page

Screenshot 2024-07-01 at 10.08.09 AM.png (1×2 px, 338 KB)

This is working correctly now - marking as done / resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits