Page MenuHomePhabricator

Change sysop_plwiki logo and favicon
Closed, ResolvedPublic

Description

Please change logo and favicon of sysop_plwiki (https://wikipedia-pl-sysop.wikimedia.org/) to https://commons.wikimedia.org/wiki/File:Wikipedia_Administrator.svg as on other sysop-wikis

Event Timeline

Hi @Superpes15

I think it would be best if you could deploy these configuration changes for us:

$url_LogoSvg = "https://upload.wikimedia.org/wikipedia/commons/d/d1/Wikipedia_Administrator.svg";
$url_LogoPng = "https://upload.wikimedia.org/wikipedia/commons/thumb/d/d1/Wikipedia_Administrator.svg/114px-Wikipedia_Administrator.svg.png";
$wgLogos = array(
	'icon' => $url_LogoPng,		// path to icon, the primary logo for Vector
	'1x' => $url_LogoPng,		// path to 1x version
	'2x' => $url_LogoPng,		// path to 2x version
	'svg' => $url_LogoSvg,		// path to svg version
);
$wgAppleTouchIcon = $url_LogoPng;

I assume 1x and 2x are required but don't actually need to be different. This shows 1x, 2x in minimal config: https://www.mediawiki.org/wiki/Manual:$wgLogos#Simple_example

I assume $wgAppleTouchIcon will be used for 2FA services like Authy. AFAIK only some Android versions support SVG for app icons, so I think a PNG file is needed.

Sorry, this should be better:

<?php

$url_LogoSvg = "https://upload.wikimedia.org/wikipedia/commons/d/d1/Wikipedia_Administrator.svg";
$fn_LogoPng = fn($size) => "https://upload.wikimedia.org/wikipedia/commons/thumb/d/d1/Wikipedia_Administrator.svg/${size}px-Wikipedia_Administrator.svg.png";
$wgLogos = [
	'icon' => $url_LogoSvg,		// path to icon, the primary logo for Vector
	'1x' => $fn_LogoPng(135),		// path to 1x version
	'2x' => $fn_LogoPng(270),		// path to 2x version
	'svg' => $url_LogoSvg,		// path to svg-icon (should replace 1x/2x in most places)
];
$wgAppleTouchIcon = $fn_LogoPng(114);
$wgFavicon = $fn_LogoPng(48); // <link rel="icon" href="...">

If I'm reading the code correctly 'svg' should replace other icons in most cases (docs say something different, but e.g. SkinModule.php is using $logo['svg'] as default). Default size might be too big, but we can fix that in CSS, so not a problem.

Simply configure (one of logos and favicon are missing) as sysop-itwiki.

Sorry, this should be better:

<?php

$url_LogoSvg = "https://upload.wikimedia.org/wikipedia/commons/d/d1/Wikipedia_Administrator.svg";
$fn_LogoPng = fn($size) => "https://upload.wikimedia.org/wikipedia/commons/thumb/d/d1/Wikipedia_Administrator.svg/${size}px-Wikipedia_Administrator.svg.png";
$wgLogos = [
	'icon' => $url_LogoSvg,		// path to icon, the primary logo for Vector
	'1x' => $fn_LogoPng(135),		// path to 1x version
	'2x' => $fn_LogoPng(270),		// path to 2x version
	'svg' => $url_LogoSvg,		// path to svg-icon (should replace 1x/2x in most places)
];
$wgAppleTouchIcon = $fn_LogoPng(114);
$wgFavicon = $fn_LogoPng(48); // <link rel="icon" href="...">

If I'm reading the code correctly 'svg' should replace other icons in most cases (docs say something different, but e.g. SkinModule.php is using $logo['svg'] as default). Default size might be too big, but we can fix that in CSS, so not a problem.

Hi, nope, the procedure is not this one, but don't worry, I'll do the patch asap as I already did for itwiki (and I also created the favicon for itwiki, do you think it's fine? it's the mop icon, we use it as favicon)! Unfortunately I had some issue in RL and now I'm handling the backlog on wiki! I think I can schedule the patch for the deployment tomorrow (on Wednesday) or on Thursday :)

Change #1051469 had a related patch set uploaded (by Wargo; author: Wargo):

[operations/mediawiki-config@master] Set logo and favicon for sysop_plwiki

https://gerrit.wikimedia.org/r/1051469

Hi @Wargo, as I said I'll create a patch in the next hour (and I assigned myself the task, so this means that I'll working on it, and it's not nice to see other user creating patches without asking), but since you created a patch, should I create a patch, or do you want to continue with your change? Please note that you have to use git and install Python, tox, pngquant, zopflipng, svgo and rsvg-convert as explained in the readme and cannot perform a logo change via the gerrit web interface, thanks!

should I create a patch, or do you want to continue with your change?

OK, please continue.

Change #1051469 abandoned by Wargo:

[operations/mediawiki-config@master] Set logo and favicon for sysop_plwiki

Reason:

Wrong process

https://gerrit.wikimedia.org/r/1051469

Change #1051757 had a related patch set uploaded (by Superpes15; author: Superpes15):

[operations/mediawiki-config@master] [sysop_plwiki] Change the logo/icon and the favicon

https://gerrit.wikimedia.org/r/1051757

Superpes15 renamed this task from Change sysop_plwiki logo to Change sysop_plwiki logo and favicon.Jul 4 2024, 9:30 AM
This comment was removed by Wargo.

Change #1051757 merged by jenkins-bot:

[operations/mediawiki-config@master] [sysop_plwiki] Change the logo/icon and the favicon

https://gerrit.wikimedia.org/r/1051757

Mentioned in SAL (#wikimedia-operations) [2024-08-26T22:02:44Z] <zabe@deploy1003> Started scap sync-world: Backport for [[gerrit:1051757|[sysop_plwiki] Change the logo/icon and the favicon (T368712)]], [[gerrit:1052063|[arbcom_itwiki] Enable importing from itwiki (T369264)]]

Mentioned in SAL (#wikimedia-operations) [2024-08-26T22:04:48Z] <zabe@deploy1003> superpes, zabe: Backport for [[gerrit:1051757|[sysop_plwiki] Change the logo/icon and the favicon (T368712)]], [[gerrit:1052063|[arbcom_itwiki] Enable importing from itwiki (T369264)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-08-26T22:09:58Z] <zabe@deploy1003> Finished scap sync-world: Backport for [[gerrit:1051757|[sysop_plwiki] Change the logo/icon and the favicon (T368712)]], [[gerrit:1052063|[arbcom_itwiki] Enable importing from itwiki (T369264)]] (duration: 07m 13s)

Change #1067305 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Revert apparent fix

https://gerrit.wikimedia.org/r/1067305

Change #1067305 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert apparent fix

https://gerrit.wikimedia.org/r/1067305

Mentioned in SAL (#wikimedia-operations) [2024-08-27T12:30:12Z] <zabe@deploy1003> Started scap sync-world: Backport for [[gerrit:1067305|Revert apparent fix (T368712)]]

Mentioned in SAL (#wikimedia-operations) [2024-08-27T12:33:54Z] <zabe@deploy1003> zabe: Backport for [[gerrit:1067305|Revert apparent fix (T368712)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-08-27T12:38:33Z] <zabe@deploy1003> Finished scap sync-world: Backport for [[gerrit:1067305|Revert apparent fix (T368712)]] (duration: 08m 20s)

Zabe subscribed.

Favicon not generated.

Should be fixed