JS error on page load on mobile Uncaught TypeError: Cannot read properties of null (reading 'includes')
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 17 2024, 6:04 PM

Description

https://logstash.wikimedia.org/goto/6f9d387b3d9f7e2d9f7553bec3386777

Steps to replicate the issue (include links if applicable):

Visit https://meta.m.wikimedia.org/wiki/Community_Wishlist

What happens?:

JS error on page load

"Uncaught TypeError: Cannot read properties of null (reading 'includes')

TypeError: Cannot read properties of null (reading 'includes')\n    at WebUtil.isWishView (https://meta.m.wikimedia.org/w/load.php?lang=en&modules=ext.gadget.WishlistIntake&skin=minerva&version=1ezd8:24:587)\n    at WebUtil.isWishRelatedPage (https://meta.m.wikimedia.org/w/load.php?lang=en&modules=ext.gadget.WishlistIntake&skin=minerva&version=1ezd8:25:161)\n    at HTMLDocument.eval (https://meta.m.wikimedia.org/w/load.php?lang=en&modules=ext.gadget.WishlistIntake&skin=minerva&version=1ezd8:59:423)\n    at mightThrow (https://meta.m.wikimedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.discussionTools.init%7Cjquery.ui%7Cmobile.startup&skin=minerva&version=1urqx:180:648)\n    at process (https://meta.m.wikimedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.discussionTools.init%7Cjquery.ui%7Cmobile.startup&skin=minerva&version=1urqx:181:309

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Related Objects

Mentioned Here: T370839: Improve mobile support of the Community Wishlist

Event Timeline

Jdlrobson created this task.Jul 17 2024, 6:04 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptJul 17 2024, 6:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson updated the task description. (Show Details)Jul 17 2024, 6:04 PM

Umherirrender added a project: JavaScript.Jul 17 2024, 7:02 PM

JWheeler-WMF moved this task from New & TBD Tickets to Darwin's Fox (July 15-26, 2024) on the Community-Tech board.Jul 22 2024, 8:28 PM

JWheeler-WMF edited projects, added Community-Tech (Darwin's Fox (July 15-26, 2024)); removed Community-Tech.

MusikAnimal changed the subtype of this task from "Bug Report" to "Production Error".Jul 22 2024, 8:45 PM

@Jdlrobson Do you know why mw.config.get('wgCategories') doesn't work on mobile? That sounds like a MW Core bug, or perhaps MobileFrontend.

Currently, wgCategories being set is essential to a functioning Wishlist.

Related, we've noticed wgCategories isn't set on action=edit, action=info or action=history -- despite the categories already being shown on the page in all cases but the latter.

For now, I'm thinking we should disable mobile editing entirely for the Wishlist.

MusikAnimal claimed this task.Jul 23 2024, 4:31 AM

MusikAnimal moved this task from Backlog to in development on the Community-Tech (Darwin's Fox (July 15-26, 2024)) board.

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/224

Add mobile support and fix some prod errors

MusikAnimal moved this task from in development to Feedback and review on the Community-Tech (Darwin's Fox (July 15-26, 2024)) board.Jul 23 2024, 8:24 AM

samwilson merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/224

Add mobile support and fix some prod errors

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2024, 1:30 AM

MusikAnimal moved this task from Feedback and review to QA on the Community-Tech (Darwin's Fox (July 15-26, 2024)) board.Jul 24 2024, 2:00 AM

MusikAnimal moved this task from QA to Feedback and review on the Community-Tech (Darwin's Fox (July 15-26, 2024)) board.