Page MenuHomePhabricator

Impossible to move page A to B if B is redirected to C, even with delete rights
Closed, ResolvedPublicBUG REPORT

Description

This is a bizarre bug. I got an email from another admin on jawiki, who said they coudln't move 勝利の女神_(曖昧さ回避) to 勝利の女神 per a requested move (Click here to go to Special:Movepage). The destination page is a 1-revision redirect to another page, which ought to be overwritable with the delete user right.

I myself gave it a try but I couldn't either, because of a permission error. I tried the same thing on testwiki but that worked.

Update:
It seems like it's systematically impossible to move a page to another existing page that's redirected to yet another page (i.e. can't move A to B when B is a redirect to C). I observed the same bug on testwiki.

Event Timeline

Dragoniez renamed this task from Admins can't move a page to another existing page on jawiki to Impossible to move page A to B if B is redirected to C.Jul 22 2024, 4:30 PM
Dragoniez triaged this task as High priority.
Dragoniez updated the task description. (Show Details)
Dragoniez renamed this task from Impossible to move page A to B if B is redirected to C to Impossible to move page A to B if B is redirected to C, even with delete rights.Jul 22 2024, 4:37 PM

Oh, um, this might be related to the delete-redirect right I added

Change #1055980 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] SpecialMovePage: fix logic to check `delete-redirect`

https://gerrit.wikimedia.org/r/1055980

Actually, caused by ad1e36d6f6d94827b4928094c708e8340d086e5b so thankfully its only been an issue for a few weeks rather than since 77781b08c7d9268b8ba6aea8ac8e667ba5666d57 4 years ago - just a missing !

@Dragoniez for now you can tell the jawiki admin that they can go to action=delete for the target and delete it manually

Actually, caused by ad1e36d6f6d94827b4928094c708e8340d086e5b so thankfully its only been an issue for a few weeks rather than since 77781b08c7d9268b8ba6aea8ac8e667ba5666d57 4 years ago - just a missing !

Oh I see, that seems like it. Actually, I was looking through change logs, suspecting there might be some "inverted" booleans. Seems like I wasn't quite wrong.

@Dragoniez for now you can tell the jawiki admin that they can go to action=delete for the target and delete it manually

Got it. Thank you for the patch!

Change #1055980 merged by jenkins-bot:

[mediawiki/core@master] SpecialMovePage: fix logic to check `delete-redirect`

https://gerrit.wikimedia.org/r/1055980

I'm sorry about that. Thanks for the bug report and the fix. I'll backport the fix today.

Change #1056003 had a related patch set uploaded (by Bartosz Dziewoński; author: DannyS712):

[mediawiki/core@wmf/1.43.0-wmf.14] SpecialMovePage: fix logic to check `delete-redirect`

https://gerrit.wikimedia.org/r/1056003

Change #1056003 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.14] SpecialMovePage: fix logic to check `delete-redirect`

https://gerrit.wikimedia.org/r/1056003

Mentioned in SAL (#wikimedia-operations) [2024-07-22T20:50:06Z] <catrope@deploy1002> Started scap sync-world: Backport for [[gerrit:1056003|SpecialMovePage: fix logic to check delete-redirect (T370669)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-22T20:52:39Z] <catrope@deploy1002> catrope, matmarex: Backport for [[gerrit:1056003|SpecialMovePage: fix logic to check delete-redirect (T370669)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-22T21:09:19Z] <catrope@deploy1002> Finished scap: Backport for [[gerrit:1056003|SpecialMovePage: fix logic to check delete-redirect (T370669)]] (duration: 19m 12s)

matmarex assigned this task to DannyS712.

The fix has been deployed to all Wikimedia wikis.

The fix has been deployed to all Wikimedia wikis.

Thanks!