Page MenuHomePhabricator
Create Task
Maniphest T371167

Improve test coverage for maintenance scripts in core
Open, Needs TriagePublic
Actions

Description

The maintenance scripts in core are nearly all untested, with a 5% test coverage for the folder reported by https://doc.wikimedia.org/cover/mediawiki-core/maintenance/index.html.

Testing these maintenance scripts is important, as a bug in some of the more important scripts could cause issues. It also makes it easier to run less-used maintenance scripts, without having to check that they have not broken due to regressions.

Details

SubjectRepoBranchLines +/-
Test initUserPreference.php and fix a bug with itmediawiki/coremaster+62 -7
Test initSiteStats.phpmediawiki/coremaster+120 -0
Test invalidateUserSessions.phpmediawiki/coremaster+95 -0
Test addSite.phpmediawiki/coremaster+75 -5
Test SchemaMaintenancemediawiki/coremaster+618 -1
Test findDeprecated.phpmediawiki/coremaster+133 -9
Add tests for deleteEqualMessages.phpmediawiki/coremaster+195 -0
Test purgePage.phpmediawiki/coremaster+115 -0
Test patchSql.phpmediawiki/coremaster+34 -0
Expand CreateAndPromoteTestmediawiki/coremaster+74 -0
Expand tests for rename user maintenance scriptsmediawiki/coremaster+258 -2
Test exportSites.php and importSites.phpmediawiki/coremaster+69 -2
Partly test deleteTag.phpmediawiki/coremaster+37 -0
Fix broken deleteSelfExternals.php and test itmediawiki/coremaster+109 -13
Start on tests for userOptions.phpmediawiki/coremaster+88 -4
Test grep.phpmediawiki/coremaster+108 -9
Expand MigrateUserGroupTestmediawiki/coremaster+9 -2
Expand ResetUserEmailTestmediawiki/coremaster+57 -0
Start on tests for updateExtensionJsonSchema.phpmediawiki/coremaster+51 -0
Move BenchmarkerTest and MaintenanceTest into includes foldermediawiki/coremaster+60 -2
Expand RollbackEditsTestmediawiki/coremaster+15 -0
Test alltrans.php and dumpMessages.phpmediawiki/coremaster+126 -42
Expand CleanupWatchlistTestmediawiki/coremaster+23 -7
Expand GetTextMaintTestmediawiki/coremaster+54 -0
Expand ProtectTestmediawiki/coremaster+26 -0
Expand GetLagTimesTestmediawiki/coremaster+12 -8
Test validateRegistrationFile.phpmediawiki/coremaster+51 -0
Test makeTestEdits.phpmediawiki/coremaster+49 -0
Test changePassword.phpmediawiki/coremaster+71 -0
Test getReplicaServer.phpmediawiki/coremaster+30 -0
Test parse.phpmediawiki/coremaster+41 -0
Test runJobs.phpmediawiki/coremaster+62 -0
Test LoggedUpdateMaintenancemediawiki/coremaster+112 -0
Mark FakeMaintenance as excluded for test coveragemediawiki/coremaster+1 -0
Remove unreachable default branch in getConfiguration.phpmediawiki/coremaster+3 -3
Fully test createBotPassword.phpmediawiki/coremaster+113 -1
Start on tests for install.phpmediawiki/coremaster+34 -2
Test dumpRev.phpmediawiki/coremaster+31 -0
Test deleteOrphanedRevisions.phpmediawiki/coremaster+73 -0
Start on tests for renameUser.phpmediawiki/coremaster+82 -0
Test fixUserRegistration.phpmediawiki/coremaster+71 -0
Start on tests for resetAuthenticationThrottle.phpmediawiki/coremaster+115 -0
Test jsparse.phpmediawiki/coremaster+51 -1
Test checkComposerLockUpToDate.phpmediawiki/coremaster+97 -10
Test moveBatch.phpmediawiki/coremaster+125 -1
Test deleteOldRevisions.phpmediawiki/coremaster+127 -6
Test purgeOldText.phpmediawiki/coremaster+47 -0
Exclude boilerplate maintenance code from code coverage reportsmediawiki/coremaster+878 -0
Test removeInvalidEmails.phpmediawiki/coremaster+87 -0
Test invalidateBotPasswords.phpmediawiki/coremaster+64 -0
Start on tests for update.phpmediawiki/coremaster+37 -0
Test addChangeTag.phpmediawiki/coremaster+38 -0
Test getConfiguration.phpmediawiki/coremaster+158 -1
Test fixDoubleRedirects.phpmediawiki/coremaster+117 -0
Test edit.phpmediawiki/coremaster+200 -0
Test cleanupWatchlist.phpmediawiki/coremaster+69 -0
Test findClasses.phpmediawiki/coremaster+63 -4
Expand MaintenanceTestmediawiki/coremaster+24 -0
Test deleteArchivedRevisions.phpmediawiki/coremaster+52 -0
ViewCLITest: Cover non-text content models toomediawiki/coremaster+14 -0
Fix blockUsers.php handling of an invalid performer optionmediawiki/coremaster+10 -1
Test protect.php for invalid arguments and optionsmediawiki/coremaster+15 -0
ShowJobsTest: Cover the filter check branchmediawiki/coremaster+10 -0
Test clearInterwikiCache.phpmediawiki/coremaster+54 -0
Partially test manageJobs.phpmediawiki/coremaster+52 -0
ResetPageRandomTest: Cover the other option check branchmediawiki/coremaster+12 -0
Expand GetTextMaintTestmediawiki/coremaster+17 -0
Test wikiBirthday.phpmediawiki/coremaster+45 -2
Test code in Maintenance class that calls ::fatalErrormediawiki/coremaster+72 -2
Test renameRestrictions.phpmediawiki/coremaster+47 -0
Expand tests for undelete.phpmediawiki/coremaster+25 -0
Expand tests for resetUserEmail.phpmediawiki/coremaster+19 -1
Expand tests for sql.phpmediawiki/coremaster+49 -1
Expand DeleteUserEmailTest test invalid username argumentmediawiki/coremaster+16 -0
Test view.phpmediawiki/coremaster+48 -0
Test resetPageRandom.phpmediawiki/coremaster+83 -2
Test createAndPromote.php for invalid arguments and optionsmediawiki/coremaster+17 -0
Fix GetTextMaintTestmediawiki/coremaster+3 -3
Test showJobs.phpmediawiki/coremaster+73 -0
Test rollbackEdits.phpmediawiki/coremaster+112 -0
Test migrateUserGroup.phpmediawiki/coremaster+104 -15
Partly test expireTemporaryAccounts.phpmediawiki/coremaster+40 -0
Test purgeExpiredUserrights.phpmediawiki/coremaster+35 -0
Test purgeExpiredBlocks.phpmediawiki/coremaster+24 -0
Test purgeMessageBlobStore.phpmediawiki/coremaster+28 -0
Test rebuildmessages.phpmediawiki/coremaster+23 -0
Test purgeExpiredWatchlistItems.phpmediawiki/coremaster+64 -0
Test showSiteStats.phpmediawiki/coremaster+47 -0
Test deleteBatch.phpmediawiki/coremaster+95 -0
Test checkBadRedirects.phpmediawiki/coremaster+84 -0
Test deleteDefaultMessages.phpmediawiki/coremaster+104 -0
Test sql.phpmediawiki/coremaster+46 -0
Test updateArticleCount.phpmediawiki/coremaster+84 -0
Test blockUsers.phpmediawiki/coremaster+167 -0
Test checkUsernames.phpmediawiki/coremaster+32 -0
Test CheckSignatures.phpmediawiki/coremaster+77 -0
Expand DeleteUserEmailTestmediawiki/coremaster+26 -10
Test attachLatest.phpmediawiki/coremaster+71 -0
Test resetUserEmail.phpmediawiki/coremaster+62 -0
Test protect.phpmediawiki/coremaster+55 -0
Test createAndPromote.php for adding rights to existing usermediawiki/coremaster+71 -0
Test pageExists.phpmediawiki/coremaster+35 -0
Test undelete.phpmediawiki/coremaster+40 -0
Test emptyUserGroup.phpmediawiki/coremaster+74 -0
Test getText.phpmediawiki/coremaster+50 -0
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Aug 27 2024, 12:06 PM

Change #1067329 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Exclude boilerplate maintenance code from code coverage reports

https://gerrit.wikimedia.org/r/1067329

gerritbot added a comment.Aug 27 2024, 2:51 PM

Change #1067329 merged by jenkins-bot:

[mediawiki/core@master] Exclude boilerplate maintenance code from code coverage reports

https://gerrit.wikimedia.org/r/1067329

gerritbot added a comment.Aug 29 2024, 6:41 PM

Change #1066707 merged by jenkins-bot:

[mediawiki/core@master] Test purgeOldText.php

https://gerrit.wikimedia.org/r/1066707

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.21; 2024-09-03); removed MW-1.43-notes (1.43.0-wmf.20; 2024-08-27).Aug 29 2024, 7:00 PM
gerritbot added a comment.Aug 29 2024, 8:59 PM

Change #1063756 merged by jenkins-bot:

[mediawiki/core@master] Test deleteOldRevisions.php

https://gerrit.wikimedia.org/r/1063756

gerritbot added a comment.Aug 29 2024, 9:42 PM

Change #1063757 merged by jenkins-bot:

[mediawiki/core@master] Test checkComposerLockUpToDate.php

https://gerrit.wikimedia.org/r/1063757

gerritbot added a comment.Aug 29 2024, 9:45 PM

Change #1066706 merged by jenkins-bot:

[mediawiki/core@master] Test moveBatch.php

https://gerrit.wikimedia.org/r/1066706

gerritbot added a comment.Aug 29 2024, 10:11 PM

Change #1066705 merged by jenkins-bot:

[mediawiki/core@master] Test jsparse.php

https://gerrit.wikimedia.org/r/1066705

Krinkle unsubscribed.Aug 30 2024, 1:29 AM
gerritbot added a comment.Aug 30 2024, 4:34 PM

Change #1069246 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Start on tests for resetAuthenticationThrottle.php

https://gerrit.wikimedia.org/r/1069246

gerritbot added a comment.Aug 30 2024, 4:34 PM

Change #1069247 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Start on tests for renameUser.php

https://gerrit.wikimedia.org/r/1069247

gerritbot added a comment.Aug 30 2024, 4:58 PM

Change #1069248 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test dumpRev.php

https://gerrit.wikimedia.org/r/1069248

gerritbot added a comment.Aug 30 2024, 5:46 PM

Change #1069256 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Fully test createBotPassword.php

https://gerrit.wikimedia.org/r/1069256

gerritbot added a comment.Aug 30 2024, 6:07 PM

Change #1069268 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test deleteOrphanedRevisions.php

https://gerrit.wikimedia.org/r/1069268

gerritbot added a comment.Aug 30 2024, 8:14 PM

Change #1069246 merged by jenkins-bot:

[mediawiki/core@master] Start on tests for resetAuthenticationThrottle.php

https://gerrit.wikimedia.org/r/1069246

gerritbot added a comment.Aug 30 2024, 8:14 PM

Change #1069247 merged by jenkins-bot:

[mediawiki/core@master] Start on tests for renameUser.php

https://gerrit.wikimedia.org/r/1069247

gerritbot added a comment.Aug 30 2024, 8:14 PM

Change #1061453 merged by jenkins-bot:

[mediawiki/core@master] Test fixUserRegistration.php

https://gerrit.wikimedia.org/r/1061453

gerritbot added a comment.Aug 30 2024, 8:14 PM

Change #1069248 merged by jenkins-bot:

[mediawiki/core@master] Test dumpRev.php

https://gerrit.wikimedia.org/r/1069248

gerritbot added a comment.Aug 30 2024, 8:14 PM

Change #1069268 merged by jenkins-bot:

[mediawiki/core@master] Test deleteOrphanedRevisions.php

https://gerrit.wikimedia.org/r/1069268

gerritbot added a comment.Aug 30 2024, 8:17 PM

Change #1069256 merged by jenkins-bot:

[mediawiki/core@master] Fully test createBotPassword.php

https://gerrit.wikimedia.org/r/1069256

gerritbot added a comment.Aug 30 2024, 8:18 PM

Change #1063752 merged by jenkins-bot:

[mediawiki/core@master] Start on tests for install.php

https://gerrit.wikimedia.org/r/1063752

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069963 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test makeTestEdits.php

https://gerrit.wikimedia.org/r/1069963

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069964 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test changePassword.php

https://gerrit.wikimedia.org/r/1069964

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069965 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Mark FakeMaintenance as excluded for test coverage

https://gerrit.wikimedia.org/r/1069965

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069966 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test getReplicaServer.php

https://gerrit.wikimedia.org/r/1069966

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069967 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test runJobs.php

https://gerrit.wikimedia.org/r/1069967

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069968 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test parse.php

https://gerrit.wikimedia.org/r/1069968

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069969 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test userOptions.php

https://gerrit.wikimedia.org/r/1069969

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069970 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test grep.php

https://gerrit.wikimedia.org/r/1069970

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069971 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test updateExtensionJsonSchema.php

https://gerrit.wikimedia.org/r/1069971

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069972 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test validateRegistrationFile.php

https://gerrit.wikimedia.org/r/1069972

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069973 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Fix broken deleteSelfExternals.php and test it

https://gerrit.wikimedia.org/r/1069973

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069974 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test LoggedUpdateMaintenance

https://gerrit.wikimedia.org/r/1069974

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069975 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test alltrans.php and dumpMessages.php

https://gerrit.wikimedia.org/r/1069975

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069976 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Move BenchmarkerTest and MaintenanceTest into includes folder

https://gerrit.wikimedia.org/r/1069976

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069977 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Remove unreachable default branch in getConfiguration.php

https://gerrit.wikimedia.org/r/1069977

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069978 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Expand CleanupWatchlistTest

https://gerrit.wikimedia.org/r/1069978

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069979 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Expand GetLagTimesTest

https://gerrit.wikimedia.org/r/1069979

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069980 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Expand ResetUserEmailTest

https://gerrit.wikimedia.org/r/1069980

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069981 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Expand ProtectTest

https://gerrit.wikimedia.org/r/1069981

gerritbot added a comment.Sep 2 2024, 10:04 AM

Change #1069982 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Expand GetTextMaintTest

https://gerrit.wikimedia.org/r/1069982

gerritbot added a comment.Sep 2 2024, 10:05 AM

Change #1069984 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Expand MigrateUserGroupTest

https://gerrit.wikimedia.org/r/1069984

gerritbot added a comment.Sep 2 2024, 10:05 AM

Change #1069985 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Expand RollbackEditsTest

https://gerrit.wikimedia.org/r/1069985

gerritbot added a comment.Sep 3 2024, 9:05 AM

Change #1069977 abandoned by Dreamy Jazz:

[mediawiki/core@master] Remove unreachable default branch in getConfiguration.php

Reason:

It was just to improve coverage for the file, but you raise a good point so I'll abandon this.

https://gerrit.wikimedia.org/r/1069977

gerritbot added a comment.Sep 3 2024, 9:28 AM

Change #1069965 merged by jenkins-bot:

[mediawiki/core@master] Mark FakeMaintenance as excluded for test coverage

https://gerrit.wikimedia.org/r/1069965

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.22; 2024-09-10); removed MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Sep 3 2024, 10:00 AM
gerritbot added a comment.Sep 3 2024, 3:23 PM

Change #1069974 merged by jenkins-bot:

[mediawiki/core@master] Test LoggedUpdateMaintenance

https://gerrit.wikimedia.org/r/1069974

gerritbot added a comment.Sep 3 2024, 4:15 PM

Change #1069967 merged by jenkins-bot:

[mediawiki/core@master] Test runJobs.php

https://gerrit.wikimedia.org/r/1069967

gerritbot added a comment.Sep 3 2024, 4:20 PM

Change #1069966 merged by jenkins-bot:

[mediawiki/core@master] Test getReplicaServer.php

https://gerrit.wikimedia.org/r/1069966

gerritbot added a comment.Sep 3 2024, 4:20 PM

Change #1069968 merged by jenkins-bot:

[mediawiki/core@master] Test parse.php

https://gerrit.wikimedia.org/r/1069968

gerritbot added a comment.Sep 3 2024, 4:44 PM

Change #1069963 merged by jenkins-bot:

[mediawiki/core@master] Test makeTestEdits.php

https://gerrit.wikimedia.org/r/1069963

gerritbot added a comment.Sep 3 2024, 4:44 PM

Change #1069964 merged by jenkins-bot:

[mediawiki/core@master] Test changePassword.php

https://gerrit.wikimedia.org/r/1069964

gerritbot added a comment.Sep 3 2024, 5:13 PM

Change #1069972 merged by jenkins-bot:

[mediawiki/core@master] Test validateRegistrationFile.php

https://gerrit.wikimedia.org/r/1069972

gerritbot added a comment.Sep 3 2024, 6:37 PM

Change #1069981 merged by jenkins-bot:

[mediawiki/core@master] Expand ProtectTest

https://gerrit.wikimedia.org/r/1069981

gerritbot added a comment.Sep 3 2024, 6:43 PM

Change #1069979 abandoned by Dreamy Jazz:

[mediawiki/core@master] Expand GetLagTimesTest

Reason:

Considering the -1, I'll abandon this and potentially re-create it at a later date.

https://gerrit.wikimedia.org/r/1069979

gerritbot added a comment.Sep 11 2024, 6:16 PM

Change #1069978 merged by jenkins-bot:

[mediawiki/core@master] Expand CleanupWatchlistTest

https://gerrit.wikimedia.org/r/1069978

gerritbot added a comment.Sep 11 2024, 6:17 PM

Change #1069982 merged by jenkins-bot:

[mediawiki/core@master] Expand GetTextMaintTest

https://gerrit.wikimedia.org/r/1069982

gerritbot added a comment.Sep 11 2024, 6:27 PM

Change #1069985 merged by jenkins-bot:

[mediawiki/core@master] Expand RollbackEditsTest

https://gerrit.wikimedia.org/r/1069985

gerritbot added a comment.Sep 11 2024, 6:27 PM

Change #1069975 merged by jenkins-bot:

[mediawiki/core@master] Test alltrans.php and dumpMessages.php

https://gerrit.wikimedia.org/r/1069975

gerritbot added a comment.Sep 11 2024, 6:27 PM

Change #1069971 merged by jenkins-bot:

[mediawiki/core@master] Start on tests for updateExtensionJsonSchema.php

https://gerrit.wikimedia.org/r/1069971

gerritbot added a comment.Sep 11 2024, 6:28 PM

Change #1069976 merged by jenkins-bot:

[mediawiki/core@master] Move BenchmarkerTest and MaintenanceTest into includes folder

https://gerrit.wikimedia.org/r/1069976

gerritbot added a comment.Sep 11 2024, 6:29 PM

Change #1069984 merged by jenkins-bot:

[mediawiki/core@master] Expand MigrateUserGroupTest

https://gerrit.wikimedia.org/r/1069984

gerritbot added a comment.Sep 11 2024, 6:30 PM

Change #1069980 merged by jenkins-bot:

[mediawiki/core@master] Expand ResetUserEmailTest

https://gerrit.wikimedia.org/r/1069980

gerritbot added a comment.Sep 11 2024, 6:30 PM

Change #1069969 merged by jenkins-bot:

[mediawiki/core@master] Start on tests for userOptions.php

https://gerrit.wikimedia.org/r/1069969

gerritbot added a comment.Sep 11 2024, 6:36 PM

Change #1069970 merged by jenkins-bot:

[mediawiki/core@master] Test grep.php

https://gerrit.wikimedia.org/r/1069970

gerritbot added a comment.Sep 11 2024, 6:57 PM

Change #1069973 merged by jenkins-bot:

[mediawiki/core@master] Fix broken deleteSelfExternals.php and test it

https://gerrit.wikimedia.org/r/1069973

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.23; 2024-09-17); removed MW-1.43-notes (1.43.0-wmf.22; 2024-09-10).Sep 11 2024, 7:00 PM
gerritbot added a comment.Sep 13 2024, 9:02 PM

Change #1072811 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Partly test deleteTag.php

https://gerrit.wikimedia.org/r/1072811

gerritbot added a comment.Sep 16 2024, 11:13 AM

Change #1073180 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test exportSites.php and importSites.php

https://gerrit.wikimedia.org/r/1073180

gerritbot added a comment.Sep 16 2024, 11:13 AM

Change #1073181 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test findDeprecated.php

https://gerrit.wikimedia.org/r/1073181

gerritbot added a comment.Sep 16 2024, 10:46 PM

Change #1072811 merged by jenkins-bot:

[mediawiki/core@master] Partly test deleteTag.php

https://gerrit.wikimedia.org/r/1072811

gerritbot added a comment.Sep 16 2024, 10:56 PM

Change #1073180 merged by jenkins-bot:

[mediawiki/core@master] Test exportSites.php and importSites.php

https://gerrit.wikimedia.org/r/1073180

gerritbot added a comment.Oct 8 2024, 8:40 PM

Change #1078747 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Expand tests for rename user maintenance scripts

https://gerrit.wikimedia.org/r/1078747

gerritbot added a comment.Oct 9 2024, 1:11 PM

Change #1078747 merged by jenkins-bot:

[mediawiki/core@master] Expand tests for rename user maintenance scripts

https://gerrit.wikimedia.org/r/1078747

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.27; 2024-10-15); removed MW-1.43-notes (1.43.0-wmf.23; 2024-09-17).Oct 9 2024, 2:00 PM
gerritbot added a comment.Oct 10 2024, 9:16 AM

Change #1079222 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Expand CreateAndPromoteTest

https://gerrit.wikimedia.org/r/1079222

gerritbot added a comment.Oct 10 2024, 5:19 PM

Change #1079222 merged by jenkins-bot:

[mediawiki/core@master] Expand CreateAndPromoteTest

https://gerrit.wikimedia.org/r/1079222

gerritbot added a comment.Oct 14 2024, 10:27 AM

Change #1079964 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Add tests for deleteEqualMessages.php

https://gerrit.wikimedia.org/r/1079964

gerritbot added a comment.Oct 14 2024, 10:27 AM

Change #1079965 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test patchSql.php

https://gerrit.wikimedia.org/r/1079965

gerritbot added a comment.Oct 14 2024, 10:27 AM

Change #1079966 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test purgePage.php

https://gerrit.wikimedia.org/r/1079966

gerritbot added a comment.Oct 14 2024, 10:15 PM

Change #1079965 merged by jenkins-bot:

[mediawiki/core@master] Test patchSql.php

https://gerrit.wikimedia.org/r/1079965

gerritbot added a comment.Oct 15 2024, 2:03 PM

Change #1079966 merged by jenkins-bot:

[mediawiki/core@master] Test purgePage.php

https://gerrit.wikimedia.org/r/1079966

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.28; 2024-10-22); removed MW-1.43-notes (1.43.0-wmf.27; 2024-10-15).Oct 15 2024, 3:00 PM
gerritbot added a comment.Oct 15 2024, 5:41 PM

Change #1079964 merged by jenkins-bot:

[mediawiki/core@master] Add tests for deleteEqualMessages.php

https://gerrit.wikimedia.org/r/1079964

gerritbot added a comment.Oct 15 2024, 5:41 PM

Change #1073181 merged by jenkins-bot:

[mediawiki/core@master] Test findDeprecated.php

https://gerrit.wikimedia.org/r/1073181

gerritbot added a comment.Nov 4 2024, 9:21 AM

Change #1087127 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test addSite.php

https://gerrit.wikimedia.org/r/1087127

gerritbot added a comment.Nov 4 2024, 9:21 AM

Change #1087128 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test SchemaMaintenance

https://gerrit.wikimedia.org/r/1087128

gerritbot added a comment.Nov 4 2024, 1:49 PM

Change #1087128 merged by jenkins-bot:

[mediawiki/core@master] Test SchemaMaintenance

https://gerrit.wikimedia.org/r/1087128

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Nov 4 2024, 2:00 PM
gerritbot added a comment.Nov 4 2024, 2:58 PM

Change #1087127 merged by jenkins-bot:

[mediawiki/core@master] Test addSite.php

https://gerrit.wikimedia.org/r/1087127

Jdforrester-WMF added a comment.Nov 6 2024, 3:12 PM

Update as of 2024-11-06 is that this is now up nearly five-fold, to 23.44% (by comparison, includes/ is 44.05%. Do we have a target for "good enough" so we can close this, or is it doomed to be forever open? :-)

Dreamy_Jazz added a comment.EditedNov 6 2024, 10:23 PM
In T371167#10296499, @Jdforrester-WMF wrote:

Do we have a target for "good enough" so we can close this, or is it doomed to be forever open? :-)

Hmm. I don't have anything specific in mind. Perhaps at 44% it would definitely be resolved, and possibly sooner if I don't see any other maintenance scripts that are not too complicated to write tests for.

Looking at other similar "test coverage is very low, increase please" tickets, I've seen anything from 35% to 90%.

gerritbot added a comment.Nov 6 2024, 11:38 PM

Change #1087994 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test invalidateUserSessions.php

https://gerrit.wikimedia.org/r/1087994

gerritbot added a comment.Nov 7 2024, 12:09 AM

Change #1087995 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test initSiteStats.php

https://gerrit.wikimedia.org/r/1087995

gerritbot added a comment.Nov 7 2024, 2:48 PM

Change #1087994 merged by jenkins-bot:

[mediawiki/core@master] Test invalidateUserSessions.php

https://gerrit.wikimedia.org/r/1087994

gerritbot added a comment.Nov 7 2024, 2:49 PM

Change #1087995 merged by jenkins-bot:

[mediawiki/core@master] Test initSiteStats.php

https://gerrit.wikimedia.org/r/1087995

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.3; 2024-11-12); removed MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Nov 7 2024, 3:00 PM
gerritbot added a comment.Nov 8 2024, 1:40 PM

Change #1088563 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test initUserPreference.php and fix a bug with it

https://gerrit.wikimedia.org/r/1088563

gerritbot added a comment.Nov 12 2024, 6:09 PM

Change #1088563 merged by jenkins-bot:

[mediawiki/core@master] Test initUserPreference.php and fix a bug with it

https://gerrit.wikimedia.org/r/1088563

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.4; 2024-11-19); removed MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).Nov 12 2024, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits