Wikibase CI broken: MergeLexemesTest::testRequestByUserWithoutPermission_accessIsDenied: writeapidenied != permissiondenied
Closed, ResolvedPublic
Actions

Description

Seen in this build for this eminently harmless change:

1) Wikibase\Lexeme\Tests\MediaWiki\Api\MergeLexemesTest::testRequestByUserWithoutPermission_accessIsDenied
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'writeapidenied'
+'permissiondenied'

I assume this is due to T294397: Drop writeapi MediaWiki right and WikibaseLexeme needs a similar fix to Wikibase: Remove usage of writeapi userright.

Details

	Subject	Repo	Branch	Lines +/-
	Update tests for removal of writeapi right	mediawiki/extensions/WikibaseLexeme	master	+18 -17

Customize query in gerrit

Related Objects

Mentioned Here: T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel
T294397: Drop writeapi MediaWiki right

Event Timeline

Lucas_Werkmeister_WMDE created this task.Aug 2 2024, 10:27 AM

Hm, there should actually be a couple more test failures – e.g. tests/phpunit/mediawiki/Api/AddFormTest.php also fails for me locally. I wonder why I don’t see these in CI… could it be related to the work in T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel (which is currently enabled in Wikibase)?

Lucas_Werkmeister_WMDE claimed this task.Aug 2 2024, 10:32 AM

Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team (Wikidata.org Slice).

Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.

Change #1059279 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Update tests for removal of writeapi right

https://gerrit.wikimedia.org/r/1059279

gerritbot added a project: Patch-For-Review.Aug 2 2024, 10:46 AM

In T371679#10038101, @Lucas_Werkmeister_WMDE wrote:

Hm, there should actually be a couple more test failures – e.g. tests/phpunit/mediawiki/Api/AddFormTest.php also fails for me locally. I wonder why I don’t see these in CI… could it be related to the work in T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel (which is currently enabled in Wikibase)?

I’m looking into this further in WikibaseLexeme and Wikibase, but in the meantime the CI fix itself is ready for review.

In T371679#10038213, @Lucas_Werkmeister_WMDE wrote:

In T371679#10038101, @Lucas_Werkmeister_WMDE wrote:

Hm, there should actually be a couple more test failures – e.g. tests/phpunit/mediawiki/Api/AddFormTest.php also fails for me locally. I wonder why I don’t see these in CI… could it be related to the work in T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel (which is currently enabled in Wikibase)?

I’m looking into this further in WikibaseLexeme and Wikibase, but in the meantime the CI fix itself is ready for review.

Okay, I’ve now seen a failure of that test reported in both WikibaseLexeme and Wikibase CI, so I guess it was just not visible in the other build. (Maybe it exited before the other test ran?) So my concerns about the test splitting are assuaged again :)

Change #1059279 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update tests for removal of writeapi right

https://gerrit.wikimedia.org/r/1059279

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2024, 12:30 PM

Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 2 2024, 12:58 PM

Lucas_Werkmeister_WMDE claimed this task.

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Done on the Wikidata Dev Team (Wikidata.org Slice) board.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 2 2024, 1:00 PM

Sorry for the trouble!

The remaining codesearch hits for writeapidenied seem unproblematic.