Page MenuHomePhabricator
Create Task
Maniphest T371837

Performance Spike: Create a Pool of "Hot" Executor Processes to Eliminate wasmedge Startup Costs
Closed, ResolvedPublic
Actions

Description

Description

Our runtime analysis has revealed that, at the moment, the biggest bottleneck for function calls is related to starting the wasmedge processes.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • create an abstraction around the ExecutorProcess
  • create the ExecutorPool, an async producer/consumer queue which maintains a pool of active wasmedge processes, initialized on startup and replenished whenever an executor finished execution

Completion checklist

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (5b29ba9)mediawiki/extensions/WikiLambdamaster+1 -1
wikifunctions: Upgrade prod evaluators from 2024-08-16-153209 to 2024-08-20-132618 with new WASM pool codeoperations/deployment-chartsmaster+6 -50
wikifunctions: Set some better default memory/CPU levels for evaluatorsoperations/deployment-chartsmaster+5 -6
wikifunctions: Upgrade staging evaluators from 2024-08-16-153209 to 2024-08-20-132618 with new WASM pool codeoperations/deployment-chartsmaster+2 -2
tests: Skip a number of FunctionCall and PerformTest tests that have broken in Beta Clustermediawiki/extensions/WikiLambdamaster+118 -107
wikifunctions: Upgrade staging evaluators from 2024-08-16-153209 to 2024-08-16-153209 with new WASM pool codeoperations/deployment-chartsmaster+46 -0
wikifunctions: Upgrade evaluators from 2024-07-23-225548 to 2024-08-16-153209operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2024-07-19-164024 to 2024-08-13-135124operations/deployment-chartsmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmassaro created this task.Aug 5 2024, 4:55 PM
CodeReviewBot added a project: Patch-For-Review.Aug 5 2024, 4:55 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/149

Implement a Promise-based mutex.

cmassaro added a parent task: T367933: [25Q1] Performance improvements.Aug 5 2024, 4:56 PM
CodeReviewBot added a comment.Aug 8 2024, 3:32 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/149

Implement a Promise-based mutex.

CodeReviewBot added a comment.Aug 8 2024, 3:34 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/247

Update function-schemata sub-module to HEAD (2f6062d)

CodeReviewBot added a comment.Aug 8 2024, 3:50 PM

gengh merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/247

Update function-schemata sub-module to HEAD (2f6062d)

Maintenance_bot removed a project: Patch-For-Review.Aug 8 2024, 4:30 PM
CodeReviewBot added a comment.Aug 9 2024, 9:12 AM

jforrester updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/212

Draft: Update function-schemata sub-module to HEAD (4066f82)

CodeReviewBot added a project: Patch-For-Review.Aug 9 2024, 9:18 AM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/47

Update function-schemata sub-module to HEAD (92aa4ac)

CodeReviewBot added a comment.Aug 9 2024, 8:53 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/250

Draft: Add ExecutorPools, which will maintain collections of hot executors.

CodeReviewBot added a comment.Aug 13 2024, 12:02 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/47

Update function-schemata sub-module to HEAD (92aa4ac)

CodeReviewBot added a comment.Aug 13 2024, 1:51 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/212

Update function-schemata sub-module to HEAD (5a95191)

CodeReviewBot added a comment.Aug 16 2024, 12:37 AM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/253

Run top-level Express server with wasmedge env enabled.

CodeReviewBot added a comment.Aug 16 2024, 3:32 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/253

Eliminate nested subprocesses; enable wasmedge using env variables.

Jdforrester-WMF assigned this task to cmassaro.Aug 19 2024, 8:28 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
CodeReviewBot added a comment.Aug 20 2024, 1:26 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/250

Add ExecutorPools, which will maintain collections of hot executors.

gerritbot added a comment.Aug 20 2024, 1:46 PM

Change #1064031 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-07-19-164024 to 2024-08-13-135124

https://gerrit.wikimedia.org/r/1064031

gerritbot added a comment.Aug 20 2024, 1:46 PM

Change #1064032 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-07-23-225548 to 2024-08-16-153209

https://gerrit.wikimedia.org/r/1064032

gerritbot added a comment.Aug 20 2024, 1:49 PM

Change #1064031 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-07-19-164024 to 2024-08-13-135124

https://gerrit.wikimedia.org/r/1064031

gerritbot added a comment.Aug 20 2024, 1:57 PM

Change #1064032 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-07-23-225548 to 2024-08-16-153209

https://gerrit.wikimedia.org/r/1064032

gerritbot added a comment.Aug 20 2024, 2:08 PM

Change #1064035 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade staging evaluators from 2024-08-16-153209 to 2024-08-16-153209 with new WASM pool code

https://gerrit.wikimedia.org/r/1064035

Jdforrester-WMF triaged this task as High priority.Aug 20 2024, 2:13 PM
gerritbot added a comment.Aug 20 2024, 2:19 PM

Change #1064035 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade staging evaluators from 2024-08-16-153209 to 2024-08-16-153209 with new WASM pool code

https://gerrit.wikimedia.org/r/1064035

gerritbot added a comment.Aug 20 2024, 8:00 PM

Change #1064085 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] tests: Skip a number of FunctionCall and PerformTest tests that have broken in Beta Cluster

https://gerrit.wikimedia.org/r/1064085

gerritbot added a comment.Aug 20 2024, 8:12 PM

Change #1064085 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] tests: Skip a number of FunctionCall and PerformTest tests that have broken in Beta Cluster

https://gerrit.wikimedia.org/r/1064085

gerritbot added a comment.Aug 21 2024, 8:35 PM

Change #1064466 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade staging evaluators from 2024-08-16-153209 to 2024-08-20-132618 with new WASM pool code

https://gerrit.wikimedia.org/r/1064466

gerritbot added a comment.Aug 21 2024, 8:35 PM

Change #1064467 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Set some better default memory/CPU levels for evaluators

https://gerrit.wikimedia.org/r/1064467

gerritbot added a comment.Aug 21 2024, 8:35 PM

Change #1064468 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade prod evaluators from 2024-08-16-153209 to 2024-08-20-132618 with new WASM pool code

https://gerrit.wikimedia.org/r/1064468

gerritbot added a comment.Aug 21 2024, 8:39 PM

Change #1064466 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade staging evaluators from 2024-08-16-153209 to 2024-08-20-132618 with new WASM pool code

https://gerrit.wikimedia.org/r/1064466

gerritbot added a comment.Aug 21 2024, 8:50 PM

Change #1064467 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Set some better default memory/CPU levels for evaluators

https://gerrit.wikimedia.org/r/1064467

gerritbot added a comment.Aug 21 2024, 8:56 PM

Change #1064468 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade prod evaluators from 2024-08-16-153209 to 2024-08-20-132618 with new WASM pool code

https://gerrit.wikimedia.org/r/1064468

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Aug 22 2024, 12:46 PM
Jdforrester-WMF closed this task as Resolved.Aug 23 2024, 1:57 PM
gerritbot added a comment.Sep 5 2024, 2:51 PM

Change #1070964 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5b29ba9)

https://gerrit.wikimedia.org/r/1070964

gerritbot added a comment.Sep 11 2024, 3:16 PM

Change #1070964 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5b29ba9)

https://gerrit.wikimedia.org/r/1070964

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits