Trying to add a nonexistent group to an aggregate group should have a better error message
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Discovered from T372226

https://meta.wikimedia.org/wiki/Special:ApiSandbox#action=aggregategroups&format=json&do=associate&aggregategroup=agg-Community_Wishlist_wishes&group=ddfgfdg&groupname=sdfsdf&token=bc34768595fb4099fb29ca3790fd85e466b9706f%2B%5C&formatversion=2

{
    "error": {
        "code": "internal_api_error_TypeError",
        "info": "[82225218-0c04-4822-a871-129b909b45dd] Caught exception of type TypeError",
        "errorclass": "TypeError"
    },
    "servedby": "mw-api-ext.eqiad.main-857c9bf676-j425k"
}

This user error should be reported to the user as a user error, not an internal API error that enters the logs

Details

	Subject	Repo	Branch	Lines +/-
	Extra validity check for aggregate group	mediawiki/extensions/Translate	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: T372226: Community Wishlist bot is down

Event Timeline

Pppery created this task.Aug 12 2024, 2:19 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2024, 2:19 AM

Change #1061617 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Translate@master] Extra validity check for aggregate group

https://gerrit.wikimedia.org/r/1061617

gerritbot added a project: Patch-For-Review.Aug 12 2024, 3:42 AM

abi_ assigned this task to Samwilson.Aug 12 2024, 7:01 AM

abi_ triaged this task as Medium priority.

abi_ set the point value for this task to 1.

abi_ added a project: LPL Essential (LPL Essential 2024 Jul-Oct).

abi_ moved this task from Sprint Backlog to Pending Deployment on the LPL Essential (LPL Essential 2024 Jul-Oct) board.

Aklapper changed the subtype of this task from "Task" to "Production Error".Aug 12 2024, 7:31 AM

Change #1061617 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Extra validity check for aggregate group

https://gerrit.wikimedia.org/r/1061617

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.18; 2024-08-13).Aug 12 2024, 8:01 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 12 2024, 8:30 AM

abi_ added a project: Localization Infrastructure FY2023-24.Aug 12 2024, 10:31 AM

Pppery merged a task: T372315: TypeError: Argument 1 passed to MediaWiki\Extension\Translate\MessageGroupProcessing\AggregateGroupManager::supportsAggregation() must implement interface MessageGroup, null given, called in /srv/mediawiki/php-1.43.0-wmf.17/ext.Aug 12 2024, 6:41 PM

Pppery added a subscriber: MusikAnimal.

Returns

{
    "error": {
        "code": "invalidgroup",
        "info": "Group does not exist or is invalid",
        "docref": "See https://meta.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/&gt; for notice of API deprecations and breaking changes."
    },
    "servedby": "mw-api-ext.eqiad.main-5744d5b77-f2jrb"
}

Trying to add a nonexistent group to an aggregate group should have a better error messageClosed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERRORActions

Description

Details

Related Objects

Event Timeline

Trying to add a nonexistent group to an aggregate group should have a better error message
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions